vinitshahdeo / jobtweets Goto Github PK

Currently the percentage of positive, negative & neutral tweets are shown in terminal. It's better to represent the same in pie chart.

these variables must be loaded from the .env file so they don't have to enter the code just to modify them
consumer_key = 'XXXXXXXXXXXX'
consumer_secret = 'XXXXXXXXXXXX'
access_token = 'XXXXXXXXXXXX'
access_token_secret = 'XXXXXXXXXXXX

and this issue could be assigned to me

The keys used to authenticate with Twitter API are exposed. I think you already know this but you might forgot to .gitignore the personal keys. Its not safe to expose these keys out as recommended by twitter.

Just a suggestion 🙃 🤗

Description

The Twitter API keys should never be added to a code file because of security reasons. Exchanging the files with someone or uploading them somewhere can result in a potential security threat (An example commit from your repository (I hope they have been regenerated now) - here).

Possible fix

Using environment variables one can store these keys somewhere else (not in the file) but can still access them using the os library. This is the standard way of using sensitive API keys in a python project.

Edit: Just saw #35 oops, my bad.

Currently, the query is hardcoded in jobtweets.py i.e.

tweets = api.get_tweets(query = 'Job Opportunities', count = 500)

Taking the input for query (i.e. #hashtag) from the user through CLI seems better!

Question to answer?

Can we take input as a comma-separated string for processing multiple hashtags at a time?

Enter hashtags: jobs, openings, job opportunities

Note:

• Make changes only in jobtweets.py
• Your PR should not break the functionality of the existing code.
• Add me( @vinitshahdeo ) as reviewer
• Do not make any changes to other files.