Git Product home page Git Product logo

Comments (3)

psalm-github-bot avatar psalm-github-bot commented on September 26, 2024

I found these snippets:

https://psalm.dev/r/808fd263bd
<?php

/**
 * @return -1|positive-int
 */
function getInt():int {
    if (rand(0,1)) {
        return 234;
    }
    return -1;
}

class C {
    /** @var positive-int|null */
    private $p;
    
    function doFoo():void {
        $i = getInt();
        if ($i === -1) {
            $i = null;
        }
        $this->p = $i;
    }
}
Psalm output (using commit ef3b018):

ERROR: InvalidPropertyAssignmentValue - 22:20 - $this->p with declared type 'int<1, max>|null' cannot be assigned type 'int<0, max>|null'

from psalm.

jack-worman avatar jack-worman commented on September 26, 2024

Simplified: https://psalm.dev/r/4998359b55

The root issue seems to be -1|positive-int getting wrongly converted to int<-1, max>.
Technically it isn't wrong, just more general than it needs to be.

from psalm.

psalm-github-bot avatar psalm-github-bot commented on September 26, 2024

I found these snippets:

https://psalm.dev/r/4998359b55
<?php

/**
 * @return -1|positive-int
 */
function foo(): int { return random_int(0, 1) ? -1 : 1; }

$a = foo();

/** @psalm-trace $a */
Psalm output (using commit ef3b018):

INFO: Trace - 10:23 - $a: int<-1, max>

INFO: UnusedVariable - 8:1 - $a is never referenced or the value is not used

from psalm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.