Comments (3)
I found these snippets:
https://psalm.dev/r/808fd263bd
<?php
/**
* @return -1|positive-int
*/
function getInt():int {
if (rand(0,1)) {
return 234;
}
return -1;
}
class C {
/** @var positive-int|null */
private $p;
function doFoo():void {
$i = getInt();
if ($i === -1) {
$i = null;
}
$this->p = $i;
}
}
Psalm output (using commit ef3b018):
ERROR: InvalidPropertyAssignmentValue - 22:20 - $this->p with declared type 'int<1, max>|null' cannot be assigned type 'int<0, max>|null'
from psalm.
Simplified: https://psalm.dev/r/4998359b55
The root issue seems to be -1|positive-int
getting wrongly converted to int<-1, max>
.
Technically it isn't wrong, just more general than it needs to be.
from psalm.
I found these snippets:
https://psalm.dev/r/4998359b55
<?php
/**
* @return -1|positive-int
*/
function foo(): int { return random_int(0, 1) ? -1 : 1; }
$a = foo();
/** @psalm-trace $a */
Psalm output (using commit ef3b018):
INFO: Trace - 10:23 - $a: int<-1, max>
INFO: UnusedVariable - 8:1 - $a is never referenced or the value is not used
from psalm.
Related Issues (20)
- Allow suppressing a psalm issue for a single Attribute or parameter HOT 1
- "Could not get class storage for X" HOT 1
- Taint analysis: allow marking properties as taint sources? HOT 2
- `non-empty-string` false positive detection HOT 4
- Return type: subtype of type HOT 1
- Inherit `value-of` class constant (static behavior) HOT 1
- @psalm-require-extends does not consider generics HOT 1
- Bug when using "@template" HOT 2
- Non-null template value HOT 1
- False-positive `ReservedWord` issue HOT 3
- Docbloc: callable() is not a valid method HOT 1
- Implode of literal-string should be inferred as literal-string HOT 1
- `''` check is loosing literal-string type HOT 1
- `literal-string is non-empty-literal-string` seems to be considered as always true HOT 2
- Internal annotation is propagated to non internal child class HOT 1
- Proposed syntax to document the execution lifetime of callable parameters HOT 1
- [LSP] Method Psalm\Internal\LanguageServer\LanguageServer::cancelRequest() does not exist HOT 6
- UnusedParam false positive when param assigned by reference HOT 2
- `MismatchingDocblockReturnType` with `iterable|object` HOT 1
- UnusedFunctionCall false positive on mail standard extension HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psalm.