When doing an early return on '' === $string the lite

I found these snippets: https://psalm.dev/r/6e2018c6b3</summary

`''` check is loosing literal-string type about psalm HOT 1 OPEN

VincentLanglet commented on July 4, 2024

`''` check is loosing literal-string type

from psalm.

Comments (1)

psalm-github-bot commented on July 4, 2024

I found these snippets:

https://psalm.dev/r/6e2018c6b3

<?php

/**
 * @param literal-string $s
 */
function foo1(string $s): void
{
    if ('' === $s) {
        return;
    }
    
    /** @psalm-trace $b */
    $b = $s;
}

/**
 * @param literal-string $s
 */
function foo2(string $s): void
{
    if (!$s) {
        return;
    }
    
    /** @psalm-trace $b */
    $b = $s;
}

Psalm output (using commit 08afc45):

INFO: Trace - 13:5 - $b: non-empty-string

INFO: UnusedVariable - 13:5 - $b is never referenced or the value is not used

INFO: Trace - 26:5 - $b: non-empty-literal-string

INFO: UnusedVariable - 26:5 - $b is never referenced or the value is not used

from psalm.

Related Issues (20)

Report error for float used with modulo HOT 1
Psalm PHP notice when using modulo, bitwise or,... on non-int HOT 1
Suppress `MissingClassConstType` if the class is `final` HOT 1
Suggestion: Allow empty `<errorLevel>` in `psalm.xml` (i.e. suppress everywhere) HOT 2
PHP 8.2 has PHP Error: Creation of dynamic property PhpParser\Node\Stmt\... HOT 4
CI: phpunit should fail on deprecated notices HOT 1
TooManyArguments false positive HOT 1
`MissingClassConstType` error still appears when specify type annotation `/** @var int **/` HOT 3
Wrong `MixedArgumentTypeCoercion` HOT 1
int range returns incorrect result for pow HOT 1
Psalm is unable to detect type of object shape when trying to call callable property. HOT 1
InvalidArgument error introduced in 5.24 HOT 6
ArrayAccess with nullable value and ?? gives PossiblyNullReference HOT 3
FalsePositive ImpureVariable in constructor HOT 1
Support declaring known type variadic named arguments HOT 1
Add error for negated file ops in loop when clearstatcache isn't called HOT 1
Enum::from and Enum::tryFrom doesn't work with templates HOT 1
psalm-if-this-is crashes with enums HOT 2
enums: can't assign a value to value-of<Enum> HOT 1
Type bounds for generic parameters HOT 1

`''` check is loosing literal-string type about psalm HOT 1 OPEN

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent