Git Product home page Git Product logo

timeless-jewels's Introduction

timeless-jewels's People

Contributors

shafouz avatar vilsol avatar zorgie avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

timeless-jewels's Issues

trade issue

When clicking trade I get 4 count boxes, which I assume is correct to look at each conqueror, but they are all the same conqueror instead of being all 4.
This happened with militant faith regardless of which conqueror i select, i only get venarius in the results.
It is possible this is user error, but I have tried it several times. Also tried with elegant hubris and each "count" box populated as cadiro on the trade site

Snag_e4e605
Snag_e59bf7
Snag_e6150f
Snag_e66ec8

Wrong node description

If you socket Glorious Vanity 4202 of Doryani in the socket next to Avatar of the Hunt, The second node on the right leading up to avatar of the hunt is labeled "always freeze enemies on hit" when in game it gives a 4% chance to freeze.

[Feature Request] Restrict counted stats to selected nodes

Timeless jewels in some areas can affect quite a large number of nodes, too many to feasibly allocate, and some nodes are too travel-expensive.

But it all gets counted into the number of matches.

Therefore, ideally, we'd be able to count only matches that replace selected nodes, rather than all nodes in area.

I've poked around and don't seem to be able to do this currently, but please let me know if I've just missed it.

Wrong value displayed

Hello,
I've been looking for a timeless-jewel that is placed in spot near Supreme Ego. Acording to the site https://vilsol.github.io/ jewel: Elegant Hubris (Caspiro) 15300 should have 3 rarity nodes. On Balistics and Dire torment it's ok but should be another one on Master Sapper place (previously True Strike spot -> it is now further and circle don't reach it). However in game there is 12% non-curse aura effect. I guess problem happened because passive tree changed a bit.

Some mods are not available for search

When using the tool https://vilsol.github.io/timeless-jewels , a couple mods were not available for search.

Ex: to Cold Resistance, to Chaos Resistance, increased Movement Speed, increased Area of Effect(those are mods I check because they were important for my build).

Additional information: I cloned the repo to try to check if I could fix since only a couple are missing, but I do not know go but this might help debugging.

File alternate_passive_additions.json.gz has no mistakes as far as I checked.

I don't know what "possible_stats.json.gz" is doing but it has all the keys that are used in "alternate_passive_additions.json.gz"(even from the mods that are missing from search).

File "stat_descriptions.json.gz" has "list":[{"string":"{0:+d}% to Fire Resistance"}]} and "list":[{"string":"{0:+d}% to Lightning Resistance"}]} but is missing "list":[{"string":"{0:+d}% to Chaos Resistance"}]} and "list":[{"string":"{0:+d}% to Cold Resistance"}]}. I believe the mods that can't be searched are missing from this file.

I was gonna try to fix myself by running https://github.com/Vilsol/go-pob-data and making a text-text comparison with "stat_descriptions.json.gz" but when I tried hosting a copy of this repo(https://github.com/Vilsol/timeless-jewels) myself I got a blank page in github.io. I hope this shorten the work you need to do to fix it.

bug: more than 28 jewels

if the trade group displays more than 28 jewels, the following ones will not be displayed in the trade poe, and there is no way to group the following ones

[Feature Request] Addtional timeless jewel searching

When searching through Glorious vanity for example would it be possible to create a way to search for a sum of a mod?

lets say searching Non-Curse Aura effect. I can search the number of nodes but each nodes varies in how much it gives. So I have to scroll through every seed to add it up to check if its the amount I need.

thanks either way. I love this tool. what an amazing job you did creating this!

Glorious Vanity Jewel's "Ritual of Flesh" nodes show inflated life regen numbers

When selecting Glorious Vanity and any conqueror, the "Ritual of Flesh" nodes appear to have "Regenerate #% of life per second" nodes that are way outside of the possible values. For example:

image

(The shown selection is seed 486)

This problem persists throughout the few jewel slots I looked at. The values range from 50% to almost 80% life regen per second, while as per poewiki.net, Ritual of Flesh should only provide the following:

(6-10)% increased maximum Life
Regenerate (0.7-1.2)% of Life per second

Non-working trade

After clicking the trade button, a website opens with unselected stats
Screenshot_1
Screenshot_2

"Grouped" trade search - link generation

Hi, I recently noticed that the "grouped" trade does not generate properly the filter in PoE trade website. Please redo all steps below to see the issue.

Scenario:

  1. configure website jewel search
    1.a) pick jewel type. - for example: "Brutal Restraint"
    1.b) pick conqueror type. - for example: "Asenath"
    1.c) add desired stat. - for example: "#% increased Flask Charges gained"
    1.d) select min (default 0) and weight (default 1). - for example min = 0, weight = 1
    1.e) select min total weight (default 1). for example: min total weight = 2
    1.f) pick desired jewel slot in tree. - for example: right side of ranger
    1.g) deselect all small and notable passives
    1.h) select: "Herbalism", "Intuition", "Careful Conservationist" - (this one is incorrect due to not updated tree in 3.21)

  2. after config is done, click search button.
    2.a) wait for the program to search desired jewel bases
    2.b) check if 1 jewel base for 3 passives is present
    2.c) check if 55 jewel bases for 2 passives are present
    2.d) click "grouped" to change from purple to blue color
    2.e) click "trade" and be redirected to PoE web trade page.

  3. check filter specifics
    3.a) check if 1 jewel base for 3 passives is present
    3.b) check if all 55 jewel bases for 2 passives are present present

  • 55 or 56, not sure if the 3 passive jewel is counted once or twice

ISSUE:
56 (55*) jewel bases are not present in filter search and are not searched in trade window API
total maximum searchable bases around 28-ish.

EXPECTED:
desired outcome: 56 (55*) bases are present in filter search and are searchable in the PoE trade window API

Trade query is too complex

If you are to check all the options on trade by the Trade button at the top of the screen changing one conqueror after another, the query will contain all conquerors instead of selected one, but gonna use the same seeds. Checking the fourth one will even result in "query is too complex" note on poe site.

image

[ui] Highlight selected option

Hi, thanks a lot for making this tool, one issue I have is when checking a large list of options it's hard to see which one is currently selected as you can see on screenshot.

It would be nice to have some kind of highlight for it if possible.

Screenshot 2024-01-14 132713

Blank page when hitting trade

Hi,

I'm currently trying to look for a glorious vanity, xibaqua, with the physical damage leeched as life mod on either expertise, dynamo or ancestral knowledge. When I hit the trade button it just doesn't load. The trade link generated is very long so I imported it in a text file below.

tradejewel

trade.txt

Same issue on Firefox and Chrome.

[Feature Request] Show only notables that are selected

Would it be possible to add a toggle button, which only shows the notables in the list on the left which I have actually selected?
For example in this image:
grafik
There are some notables that I do not have allocated on the passive tree, but it stills lists them on the left as if I would get them when I plugin that jewel in my passive tree.
With this configuration from the image, "Swift Venoms" (at the bottom of the circle) would give me 1% life regen, but I don't even have that allocated ingame, so it doesn't help me at all.

Searching Jewels

image
Add 5th option "Any" or "All". Because manually checking all other Conquerors and pressing "Search" again for every single jewel isn't good.

Trade Button Includes Results for all Conquerers

I set up the following search, selecting a particular conqueror and relevant stats:
image

I found a great jewel and hit the trade button. Note that the tree display shows the keystone linked to my chosen conqueror (Doryani = Corrupted Soul):
image

However, the trade link on the seed sends me to the trade page for that seed but with all conquerors selected:
image

It should probably includ only the selected conqueror so that people who are a little dumb(like me) buy the correct the jewel :)

The trade button at the top of the seed selection only shows trades for the correct conqueror:
image

Thanks!

Wrong conquerors.

At least on Brutal Restraint
there is not a single one conqueror which matching the description of the jewels

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.