Git Product home page Git Product logo

Comments (6)

new-sankaku avatar new-sankaku commented on July 17, 2024 1

We passed each other.
I have confirmed that the PR has been approved.
Thank you for your response.

I have attached a video of before and after the modification.
Thank you for the quick response.

BEFORE

miniPaint.-.image.editor_Before_2024-03-20.05-00-42.mp4

AFTER

miniPaint.-.image.editor_After_2024-03-20.05-07-31.mp4

from minipaint.

viliusle avatar viliusle commented on July 17, 2024

Can you help me to reproduce issue on live? I see that I need to use text tool and add Chinese text. But no luck so far.
Or this is only case with extra events, causing issues for other developers?

Test string used:

第一行。
第二行。
最后一行

from minipaint.

new-sankaku avatar new-sankaku commented on July 17, 2024

Are you asking for a test with Chinese input? I am a Japanese user, so I will install the Chinese language pack and check.

By additional events, are you referring to the ones implemented in the Pull Request, such as compositionstart and compositionend? These events occur in languages that use an IME, so I believe the impact would be on users in those language regions. If this doesn't answer your question, please correct me.

from minipaint.

viliusle avatar viliusle commented on July 17, 2024

I mean is there simple way to reproduce this issue, so I can double check that your PR works? But if you are Japanese user, I will trust you and only double check English. No need to install Chinese language.

from minipaint.

viliusle avatar viliusle commented on July 17, 2024

English is fine. I included your PR manually (wanted to ignore dist/* files).
Thank you for PR.

from minipaint.

viliusle avatar viliusle commented on July 17, 2024

Pushed to live.

from minipaint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.