Hello, First of all, I want to thank you for providing such an amazi

You can change it on <a href="https://github.com/viliusle/miniPaint/blob/master/src/js

Change the Default Setting of transparent to On about minipaint HOT 6 CLOSED

takuyaW commented on August 17, 2024

Change the Default Setting of transparent to On

from minipaint.

Comments (6)

takuyaW commented on August 17, 2024 1

I have confirmed that the issue persists even when using an incognito window. Upon reviewing the code again, I identified that the problem is due to the load_default_values method in the base-gui.js file, where the setting is being changed to false. I plan to resolve this issue by changing the relevant code part to true. Thank you.

miniPaint/src/js/core/base-gui.js

Lines 92 to 103 in df0f259

 //transparency 

 var transparency_cookie = this.Helper.getCookie('transparency'); 

 if (transparency_cookie === null) { 

 //default 

 config.TRANSPARENCY = false; 

 } 

 if (transparency_cookie) { 

 config.TRANSPARENCY = true; 

 } 

 else { 

 config.TRANSPARENCY = false; 

 }

from minipaint.

viliusle commented on August 17, 2024 1

Oh, in that case it looks like bug, I would try to remove line 96 at all, since default value should be in config.php- it could solve your issue.

from minipaint.

takuyaW commented on August 17, 2024 1

Thank you for your quick reply.
I think there is a similar problem with the LANG variable, just like when config.TRANSPARENCY doesn't load correctly the first time. In this scenario, I think config.LANG should be loaded if lang is null.

miniPaint/src/js/core/base-gui.js

Lines 287 to 300 in df0f259

 load_translations() { 

 var lang = this.Helper.getCookie('language'); 

 //load from params 

 var params = this.Helper.get_url_parameters(); 

 if(params.lang != undefined){ 

 lang = params.lang.replace(/([^a-z]+)/gi, ''); 

 } 

 if (lang != null && lang != config.LANG) { 

 config.LANG = lang.replace(/([^a-z]+)/gi, ''); 

 this.Tools_translate.translate(config.LANG); 

 } 

 }

from minipaint.

viliusle commented on August 17, 2024

You can change it on config file, rebuild it from sources code and you will have modified version with that change.

If you are talking about changing it for everybody on https://viliusle.github.io/miniPaint/ - this is interesting, but it requires more opinions, research.

from minipaint.

takuyaW commented on August 17, 2024

I tried making the changes in the config file and ran npm run build, but unfortunately, I didn't see the expected change to a transparent state. It seems that just changing the config settings may not be enough.

from minipaint.

viliusle commented on August 17, 2024

after change, use incognito window (or delete cookies), because once you save settings, it is saved in cookies. Settings works only if user is new and does not have any settings saved yet.

from minipaint.

Change the Default Setting of transparent to On about minipaint HOT 6 CLOSED

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	//transparency
	var transparency_cookie = this.Helper.getCookie('transparency');
	if (transparency_cookie === null) {
	//default
	config.TRANSPARENCY = false;
	}
	if (transparency_cookie) {
	config.TRANSPARENCY = true;
	}
	else {
	config.TRANSPARENCY = false;
	}

	load_translations() {
	var lang = this.Helper.getCookie('language');

	//load from params
	var params = this.Helper.get_url_parameters();
	if(params.lang != undefined){
	lang = params.lang.replace(/([^a-z]+)/gi, '');
	}

	if (lang != null && lang != config.LANG) {
	config.LANG = lang.replace(/([^a-z]+)/gi, '');
	this.Tools_translate.translate(config.LANG);
	}
	}