Git Product home page Git Product logo

nftmarketplace's People

Contributors

vilijan avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

nftmarketplace's Issues

Deploy to mainnet?

I see there is a section for deploying to testnet. What about mainnet?

App is trying to use more and more id's

I've downloaded your code, created the config file, but the soft tries to get id โ„–3 if there are 2 in total, โ„–4 if there are 3 etc. What can I do to make it work properly? Thanks!

Questions

Nice work, I learned a lot. A few questions though (please let me know if this is not the right place)

  1. Why a contract for each NFT? in solidity this can be done in 1 contract, is it because each account can only have up to 1000 nft?
  2. Why a separate escrow account/address? why can't I use the stateful contract address as escrow account?
  3. why buyer pay seller directly? shouldn't buyer pay escrow account, escrow account deducts a percentage fee and pay the remaining to seller?

In general, this is quite different than solidity, I am not sure this is a better design or a workaround due to technical limitation, such as 1000 maximum nft.

Thanks for your time

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.