vijendra / checkr Goto Github PK

@vijendra Are you able to remove the legacy gem from Ruby gems using the gem yank method?

We should remove it to prevent new users from running the old version which has a pretty serious issue that can be hard to debug. (#5) We can also free up the namespace for the official Checkr gem.

Currently this does not work with rails (which is sad :-s).

Due to the following https://github.com/vijendra/checkr/blob/master/lib/checkr/core_ext.rb#L27-L30. There is a conflict with rails lib (see here)

I got the following error

Failure/Error: @user = FactoryGirl.create(:user)
     ActiveRecord::StatementInvalid:
       PG::UndefinedTable: ERROR:  relation "availabilitys" does not exist
       LINE 5:                WHERE a.attrelid = '"availabilitys"'::regclas...
                                                 ^
       :               SELECT a.attname, format_type(a.atttypid, a.atttypmod),
                            pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod
                       FROM pg_attribute a LEFT JOIN pg_attrdef d
                         ON a.attrelid = d.adrelid AND a.attnum = d.adnum
                      WHERE a.attrelid = '"availabilitys"'::regclass
                        AND a.attnum > 0 AND NOT a.attisdropped
                      ORDER BY a.attnum

We probably should use rails function when available?

I don't know how no one has submitted this issue yet, but including the checkr gem in our project causes rails to completely ignore all inflections, which destroys most interaction with our database (i.e. the plural of "property" is now "propertys").

This renders this gem completely unusable. Any help?

After renaming the gem to checkr-rb, you now must manually require Checkr to use it.

To reproduce on a fresh install:

• Add checkr-rb to the Gemfile

$> rails c

rails c> Checkr
NameError: uninitialized constant Checkr

rails c> require 'checkr'
rails c>Checkr
Checkr

It looks like Bundler is no longer autloading. It looks like it autoloads based on gem name. Not sure of the best way to tell it how to load the gem properly.

In the meantime, we may consider updating the Readme to reflect needing to require checkr

require 'checkr'
Checkr.configure do |c|
  c.api_key   = ENV['CHECKR_API_KEY']
end