victorwesterlund / php-libmysqldriver Goto Github PK

You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ') LIMIT 1' at line 1

This is caused by run_query() only checking if the value for $param is null, not if it's empty.

"SELECT NULL FROM <table> WHERE () LIMIT 1"

PHP 8.1 introduced a new method execute_query() which abstracts prepared statemend binding and execution. It should definitely be used instead of the custom-made implementation in this library.

Release 3.1.1 introduced a bug when passing null to select() (I really need to sort of CI testing..)

Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated

I'm considering making the MySQL->flatten() method also run MySQL->limit(1) since it has the same effect.

Example:

// Flatten returned array to first entity if set
public function flatten(bool $flag = true): self {
	$this->flatten = $flag;

	// Set LIMIT 1 if flatten flag is enabled, or unset if turned off
	$this->limit($this->flatten ? 1 : null);

	return $this;
}

I'm not sure tho if this could have other unwanted side-effects when for example removing the flatten flag with flatten(false). LIMIT would still be 1. Or if we simply remove the LIMIT all together, any LIMIT set before this will be forgotten and wiped and I'm not sure either if it's worth storing the last LIMIT in an instanced property.. It might be overkill.

Add further abstraction methods for SELECT, INSERT, and UPDATE.

Right now it's pretty annoying to dynamically filter a statement.

The PHP sources in this repo have an insane mix of tab- and space indented blocks. VScode handles it well, but look awful on GitHub.