vicberg / combatmaster Goto Github PK

When you stop combat it'll send the menu to the chat window twice. Once from the commandHandler() function:

Then once more from the stopCombat() function:

I solved this by commenting out the code on line 1579 since the Command Handler is also sending the main menu, but with my lack of familiarity, my solution may not be the correct one. Hope this helps =)

Error: Firebase.update failed: First argument contains NaN in property 'rotation' Error: Firebase.update failed: First argument contains NaN in property 'rotation' at Ba (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:9:186) at Ba (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:10:207) at Aa (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:8:462) at Ea (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:10:403) at J.update (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:146:318) at TrackedObj._doSave (/home/node/d20-api-server/api.js:905:27) at Timeout.later [as _onTimeout] (/home/node/d20-api-server/node_modules/underscore/underscore-umd.js:1153:39) at listOnTimeout (internal/timers.js:549:17) at processTimers (internal/timers.js:492:7)

I traker this error that in animateActiveTokenMarker function line 1986

let rotation_duration = 1000 * parseInt(state[combatState].config.turnorder.animateMarkerDuratio);
is change to
let rotation_duration = 1000 * parseInt(state[combatState].config.turnorder.animateMarkerWait);

it error clear.

please this code fix

The variable is defined, earlier, as "remove" but referenced here with a "d"

Affects newly added conditions

I don't know if this is intended, but spells that don't allow "override" currently don't apply concentration. Something like "bless" has concentration but doesn't need an override.

[btw, awesome project - lots of work, this is pretty great!]

Hey, thanks for this script. I'm using the one in roll20 (1.8?) and really like it. I was thinking about adding a feature to allow you to add tokens to an already started encounter as a way to learn the roll20 API. Before I get too far in I wanted to see if that was of interest or if there's another way to do it that I'm missing.