Git Product home page Git Product logo

Comments (5)

ric2016 avatar ric2016 commented on June 25, 2024

This is a general issue in other Vesta custom modules as well (e.g. extended relationships chart).

Usually, Router.php (starting at line 120) takes care of private trees by redirecting to the home page. This doesn't work for generic module routes though (of the form /module/{module}/{action}{/tree}), because it isn't clear whether the tree is mandatory.

Therefore, we'll have to handle this specifically in the respective module actions, or we have to register explicit routes with mandatory trees.

I think the latter approach is preferable anyway (with the potential issue of url clashes, as discussed here).

from vesta_shared_places.

ro-la avatar ro-la commented on June 25, 2024

OK - I dont understand your language :-)

So - my understanding is - its a known bug/behavior, has something to do with private trees, and it cannot be corrected so easy:-)

I cann live with this, makes no problem for me.

from vesta_shared_places.

ric2016 avatar ric2016 commented on June 25, 2024

No, that was more of a internal note for me, because I don't have time to fix it right away. It will be fixed in the next release.

from vesta_shared_places.

ric2016 avatar ric2016 commented on June 25, 2024

Note that this is also a bug in webtrees for certain other urls, see this issue. I'll handle the Shared Places list once this is fixed in webtrees.

from vesta_shared_places.

ric2016 avatar ric2016 commented on June 25, 2024

Mainly fixed in the latest release (also for other custom modules, namely the charts), except for the Shared Places list. - This remaining issue is now fixed via webtrees #3171, no additional adjustment required in the custom module apparently.

from vesta_shared_places.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.