Errors "unexpectedly empty!" in webtrees log files about vesta_shared_places HOT 13 OPEN

The error can be reproduced with issue vesta-webtrees-2-custom-modules/vesta_common#105.

However, vesta-webtrees-2-custom-modules/vesta_common#105 is probably not the only root cause for the error message, because it is a very specific situation (wrong date range in source) and the error message in the logs occurs very often.

from vesta_shared_places.

I'll have to investigate this - Maybe shared places where no name is given for the date of the event are not handled properly (in any case the cause seems to be date-related, as seen in vesta-webtrees-2-custom-modules/vesta_common#105).

from vesta_shared_places.

The related issue is now fixed (in code, no release yet).
I'm a bit skeptical that this fix fully resolves this issue though.

Is there anything special about the shared places in your tree that seem to trigger the error (e.g. 'Sachsen-Anhalt')? Such as a complex structure of names and parents, restricted to specific dates?

from vesta_shared_places.

Is there anything special about the shared places in your tree that seem to trigger the error (e.g. 'Sachsen-Anhalt')? Such as a complex structure of names and parents, restricted to specific dates?

Well, I make al ot of use of the SOUR:DATA:EVEN:DATE structure to describe sources. In a number of cases, the date ranges use the same start and end date, e.g. "DATE FROM 1926 TO 1926" in the following example.

0 @S9931@ SOUR
1 TITL Standesamt Mannheim, Sterberegister 1926 Band 1
1 REPO @R7517@
2 CALN Mannheim, Deutschland, Sterberegister, 1870-1950, Mannheim 1926 Band 1
3 MEDI ELECTRONIC
1 DATA
2 EVEN DEAT
3 DATE FROM 1926 TO 1926
3 PLAC Mannheim, Stadtkreis Mannheim, Baden-Württemberg, DEU
4 _LOC @P9928@

I analyzed the webtrees error logs in more depth and exported all the errors "unexpectedly empty!" related to shared places, see attached CSV file.
webtrees-logs.csv

I also tried to get an overview over the pattern of the "'xxx&#039" strings in the error logs. It seems that these are search strings for shared places. Sometimes, a substring of the shared place name is used. It looks like this is done while still typing the full name. The following screenshots show an overview over all errors in the logs. The related places seem to have no common pattern. While "Sachsen-Anhalt" is linked to more than 700 individuals and has a lot of sub-ordinated places, "Mannheim" is only linked to 2 individuals and is the lowest place in the hierarchie.

from vesta_shared_places.

Thank you for your help -

It looks like this is done while still typing the full name.

Yes - you'll see a 500 response code in the browser development tools in this case (but otherwise it just appears as if nothing is found, so the error isn't directly visible on the page).

In a number of cases, the date ranges use the same start and end date, e.g. "DATE FROM 1926 TO 1926" in the following example.

This format (same date in FROM and TO) may be handled improperly, I'll have to check that.
Out of curiosity: Is there a specific reason why you use "DATE FROM 1926 TO 1926" and not just "DATE 1926" here?

from vesta_shared_places.

Out of curiosity: Is there a specific reason why you use "DATE FROM 1926 TO 1926" and not just "DATE 1926" here?

In this sub-structure of a source, Gedcom requires to provide a date range:

SOURCE_RECORD:=
n @<XREF:SOUR>@ SOUR {1:1}
+1 DATA {0:1}
+2 EVEN <EVENTS_RECORDED> {0:M} p.50
+3 DATE <DATE_PERIOD> {0:1} p.46

I could use DATE FROM 01 JAN 1926 TO 31 DEC 1926. However, in a lot of cases, this would add information, which I do not know or have no proof of.

from vesta_shared_places.

In this sub-structure of a source, Gedcom requires to provide a date range:

Oh, I never realized it should be a date period instead of a date value - Probably because webtrees doesn't enforce that. I'll create an issue for this in webtrees.

from vesta_shared_places.

I cannot seem to reproduce the error after the fix from vesta-webtrees-2-custom-modules/vesta_common#105 . If you apply that fix, do you still get these errors?

from vesta_shared_places.

I can confirm that the bugfix fixes the specific behavior reported in vesta-webtrees-2-custom-modules/vesta_common#105.

Like mentioned above, there might be other root causes for the issue. After applying the bugfix, I did not get any new errors. I will keep watching the error logs, since the errors only occurs occasionally/sometimes and I do not know how to reproduce it.

from vesta_shared_places.

Thanks - if the error shows up again, the extended error message (last commit) should at least give a hint how to reproduce it.

from vesta_shared_places.

O.k, I installed the code from the last commit. If I find a new error message in the logs, I will report it.

from vesta_shared_places.