webtrees Geographic data after creating shared places about vesta_shared_places HOT 15 CLOSED

No, this seems dubious.

Do the newly created shared places have proper hierarchiers, or do you now e.g. have a top-level shared place 'Aarau' as well?

In the module configuration, is 'Use hierarchical shared places' checked?

from vesta_shared_places.

Randomly checked shared places have proper hierarchies, e.g. 'Aarau' is a lowest level place with a higher-level Aargau and 'Aargau' has higher-level 'Švýcarsko' (Switzerland). In the list of shared places there is only one place 'Aarau'.
In the module configuration, the 'Use hierarchical shared places' is checked.
I am using 3-level place hierarchy - Place (city, village etc.), Region, Country. In USA - Place, State, USA.

from vesta_shared_places.

Ok, that's all as it should be.
Do these unexpected top-level entries show up in the place hierarchy as well, or only in geographic data?
I'll try to reproduce this.

Edit: Another thing to check: Do you use 'pending changes', or are changes you make auto-accepted?

from vesta_shared_places.

These "new" top-level entries show up in geographic data only.
I am not using pending changes, they are accepted automatically.

from vesta_shared_places.

Thanks for the feedback.
So far, I identified a likely related issue #57 - I'll fix that first and see if that helps.

from vesta_shared_places.

I have fixed the underlying issue in #57 (hopefully this was actually the cause).

I guess it would be tricky for you to test this again. Anyway it shouldn't occur again. I'm afraid you'll have to clean up the 'geographic data' manually (or delete rows without coordinates directly in the database table, but make sure to backup everything if you do that!).

from vesta_shared_places.

Richard - no progress. I have tested it like this:

1. Restored geographic data and tree data from GEDCOM to the state before. i.e. without shared places.
2. Upgraded vesta modules to 2.0.11.3.0.
3. Used 'Data fix > Create missing shared places from tree-independent data, and add missing XREFs' as in my initial post above.

Now the gepgraphic data look again the same like on the screenshot in the initial post.
What more, the shared places are not created correctly, only the highest places have coordinates and have no link to lower levels.
If it helps you I can introduce an admin user for you on my webtrees test site and send its credentials to you by email.
Please let me know.

from vesta_shared_places.

Uh, that's not good - sorry about that.

What more, the shared places are not created correctly, only the highest places have coordinates and have no link to lower levels.

So this is worse than before now? Bah.

I think the easiest way for me to test and fix this issue is by using your test GEDCOM on my local system, you can send it to me at [email protected]. Of course I'll only use the GEDCOM for testing and delete it afterwards.

from vesta_shared_places.

I sent 2 files to [email protected]
Josef

from vesta_shared_places.

I think I fixed the issue now (*) - The root cause was that for a place "A, B, C", a check for map coordinates was made using only "A". That lead to the additional entries in "Geographic Data", and also to missing shared places because no coordinates could be found.

By the way, I also found and fixed another issue - This should result in a much faster execution of large data fixes via "Update all".

Edit: (*) I tested the data fix with your tree and everything seems to be in order now.

from vesta_shared_places.

Thank you for good news. You'll probably create new release of vesta modules?

from vesta_shared_places.

The new release 2.0.11.3.1 is already available (the new version may not show up yet in your webtrees, but you can download it anyway).

from vesta_shared_places.

OK, I will try it in the morning with fresh brain and let you know.
Josef

from vesta_shared_places.

With 2.0.11.3.1 the issue is fixed as long as I can say so far - many thanks, Richard!
The geographic data list remains untouched and randomly checked shared places have correct coordinates.

from vesta_shared_places.

Glad to hear it - Let me know if there are any other other issues. There are so many different use cases for shared places that it is easy to miss something; although this was a rather obvious bug.

from vesta_shared_places.