verygoodsecurity / vgs-show-ios Goto Github PK

Looks like the iOS documentation is not updated.

I did everything mentioned in the document but still some how it wasn't showing the card number nor the expiry date later I figured out that content path mentioned in documentation was the reason it was't working I had to change the path and it worked.

As per the documentation

cardNumberLabel.contentPath = "cardData.cardNumber" // didn't work not showing any data
expDateLabel.contentPath = "cardData.expDate" // didn't work not showing any data

Instead I had to change path to this.

cardNumberLabel.contentPath = "id" // working
expDateLabel.contentPath = ""expiry_mm_yyyy"" //  working

Thanks

Describe the bug
The SDK is always sending POST requests

To Reproduce
Steps to reproduce the behavior:

1. Use the DemoApp
2. Inside the loadData func change the request to use .get
3. Request is sent as POST

Expected behavior
Send the request as GET

Possible Solution
On APIClient.swift, line 129 is missing the method param, due to that it's using the default .post:
sendDataRequestWithURL(requestURL, path: path, payload: payload, block: block)

expected:
sendDataRequestWithURL(requestURL, path: path, method: method, payload: payload, block: block)

Describe the bug
It doesn't support VoiceOver, VoiceOver can't read card number/cvc/exp for blind user, and as a developer, I have not found a way to make it support VoiceOver, because card number/cvc/exp is not accessibility.