verybigthings / g.frame Goto Github PK

Please update the .getRoundedPlane function of RoundedPlane in utils inside the core module
It would be great to get a GMesh instead of a regular Mesh

In ActionController.ts line 198 we have super.on instead of super.once. That leads to multiple triggering events

https://nodejs.org/en/blog/npm/peer-dependencies/

Not sure how it will look like.. But let's think about it.
Viewer -> AbstractModule
|---> PerspectiveCamera is instance
|---> WebGLRenderer is instance
|---> Scene is instance

Or we can divide viewer in to several pieces:

WebGLModule -> WebGLRenderer
PerspectiveCameraModule -> PerspectiveCamera
Scene is always in ModulesProcessor as main root Object3D

Any thoughts? 🤔

Currently user has to write next code to access OrbitControls:

const orbitControls = modulesProcessor.modulesInstances.get(DesktopModule)[1];

It should be the same as for DesktopActionController, so just accessing Agent:

const controls = modulesProcessor.agents.get(Controls);

ControlsAgent should provide user with ability to set different positions for different platforms. For example:

const controls: ControlsAgent = modulesProcessor.agents.get(Controls);
controls.setPositions({
    DESKTOP: new Vector3(1,2,3) / [1, 2, 3] / 0,
    QUEST: new Vector3(1,2,3) / [1, 2, 3] / 0,
    PLATFORM_Z: new Vector3(1,2,3) / [1, 2, 3] / 0
})

The same should be for rotations.
To get specific controls, user can write next code:

const controls: ControlsAgent = modulesProcessor.agents.get(Controls);
const orbitControls: OrbitControls = controls.getSpecific(OrbitControls);

To be continued...

We should provide examples how to use Physics.
We should add Pipe for Primitives.

I am using the same algorithm to proceed with left and right controller using events on .move using the scene as the Object3D in ActionController.on(...)
This results in fully working code for the left controller, but the right controller is not working as intended because it always fails this check:
if (event.data.intersection.object)

What is Bootstrap class? Bootstrap class (BC) is used to define application start point. Exactly here all the application logic will be described. From BC come all features.
What is the main difference between AbstractModule and BC? AbstractModule has wider lifecycle than BC. But BC gets ModulesProcessor instance as argument during initialisation. AbstractModule gets only part of it during afterInit.
Why do we need it? Just because we can 😂. But really, because of lifecycle and easier (more standard) management from ModulesProcessor side.
When do we need it? For sure before opensourcing this framework.
How could we support old applications? No way to support. We should go with new version.