Git Product home page Git Product logo

Comments (5)

NerdLogic avatar NerdLogic commented on June 26, 2024 1

Yes all of that should be part of the repo so I think it is better to commit all tests and also show how to run them locally. We would like the code to be tested first locally before opening a PR and triggering github actions.

There is a test target now in the makefile that will get run on PR requests and can also be run locally before creating a PR request. It should use docker-compose to set up an environment and test dblink.

from dblink.

oualib avatar oualib commented on June 26, 2024 1

@NerdLogic I think we can close this one, no?

from dblink.

roypaulin avatar roypaulin commented on June 26, 2024

I think we need both unit tests and integration/regression tests and they will part of the Github Actions.
So it would nice to get all the test scripts before starting the actions.

from dblink.

oualib avatar oualib commented on June 26, 2024

@mfelici can you please send to @roypaulin the Unit Tests you have?

from dblink.

roypaulin avatar roypaulin commented on June 26, 2024

Yes all of that should be part of the repo so I think it is better to commit all tests and also show how to run them locally. We would like the code to be tested first locally before opening a PR and triggering github actions.

from dblink.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.