Git Product home page Git Product logo

Comments (3)

roypaulin avatar roypaulin commented on June 23, 2024

Why do we need 2 Makefiles ? We only need one where we can add any target we want. We use docker only to build dblink, which is convenient, but you can also use this same Makefile to build dblink in a non-docker environment. It is not specific to docker.

from dblink.

mfelici avatar mfelici commented on June 23, 2024

from dblink.

roypaulin avatar roypaulin commented on June 23, 2024

I understand, but
1-there is only 1 target in that Makefile that is specific to docker that's why it doesn't make sense for me to create another Makefile. Everything is already there to compile and install dblink on non-docker environment. we can easily improve it and the documentation.

2-vertica/dblink for now is only used by VerticaPyLab, mfelici/dblink is the one customers use (right?), so is there any pressure I am not aware of?

3-OSTAG, VERTICA_VERSION are only for internal use, we can make that clear.

I understand your concern, it is just that renaming it into Makefile.docker makes it look like it is just for docker when that's not the case. It is just that it also offers the possibility to use docker containers for building(which is pretty convenient for internal use, testing and release) but you can still use it on your own vertica environment.

The priority now is releasing 23.3.0 *.so file for dblink and once it's done I am going to work on improving the readme. So that instructions are clear for everyone.

from dblink.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.