"Run All" is stopped by cells where all code is commented out about spylon-kernel HOT 10 CLOSED

The Scala interpreter is returning http://www.scala-lang.org/files/archive/nightly/2.12.x/api/2.12.x/scala-compiler/scala/tools/nsc/interpreter/Results$$Incomplete$.html for a comment-only input. It returns the same thing for a cell with code x = {.

from spylon-kernel.

Wonder if we can use pygments for this?

from spylon-kernel.

Wonder if we can use pygments for this?

Aren't you on vacation? 😀

from spylon-kernel.

Toree marks all cases of incomplete as a syntax error (https://github.com/apache/incubator-toree/blob/87a9eb8ad08406ce0747e92f7714d4eb54153293/kernel/src/main/scala/org/apache/toree/kernel/protocol/v5/interpreter/tasks/ExecuteRequestTaskActor.scala#L95).

Either we go with that or we start having heuristics for special cases like "all of the lines in the cell are comments."

from spylon-kernel.

Is that the cause of Toree raising sytnax errors when the last line in a cell is a comment?

from spylon-kernel.

Certainly happens when the comment is the only thing in the cell. I don't know if it's the same spot in the code that logs the syntax error for a cell that has some code and a comment on the last line in Toree. (That oddity doesn't happen in spylon-kernel).

I'm leaning toward simply treating Results.Incomplete as an error (with output, not the silence it currently logs) and not inventing special parsing logic for the cell-with-comments-only case.

from spylon-kernel.

So Toree executes line by line. This is basically the exact same problem.

from spylon-kernel.

We can probably parse a scala code block with pygments and determine if it's all "blank".

from spylon-kernel.

Whatever causes this behavior (empty results returned by code-only cell) also worsens #26. If you run a cell with nothing but comments, all future print behaviors are disabled.

from spylon-kernel.

The withOut block wrapping that probably needs to be done per call to interpret to fix #26 will also implicitly fix this.

from spylon-kernel.