Git Product home page Git Product logo

Comments (4)

veeenu avatar veeenu commented on August 12, 2024 1

The solution to this issue will be implemented like the rocket crate: by defining feature-flagged macros that reexport the existing macros from log if the feature is active, and do nothing otherwise.

from hudhook.

veeenu avatar veeenu commented on August 12, 2024

That's a great idea, thank you. General refactoring is already planned for a new minor release sometime in the near future, so this could very well be part of that.

from hudhook.

veeenu avatar veeenu commented on August 12, 2024

Decided to postpone this too for a later release because the implementation resulted quite tricky and I don't want to invest too much energy on it right now.

I leave a sketch of a possible solution here. It doesn't compile, tries to cloak the macros but it results in some weird scoping issues. I'd consider an alternative solution, if possible.

from hudhook.

veeenu avatar veeenu commented on August 12, 2024

Now that we have tracing, this might not be necessary and in fact could be dealt with by just setting up the subscribers.

@Jakobzs, you have worked on tracing, do you know how these two could be achieved and if my hypotheses are correct?

  • Completely suppress logging (hypothesis: if you just don't depend on tracing-subscriber in your client, you don't pay any of the runtime cost of having tracing macros?)
  • Filtering out all messages coming from hudhook (do some filtering when setting up tracing-subscriber on the client -- do you have a snippet of what this could look like?)

from hudhook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.