Comments (12)
Huh! I thought it did, actually. My bad. Planning to release 0.7
at some point soonish so that fix can get in. Thank you for reporting this.
from hudhook.
What hudhook
version are you on? And how are you using the docking branch? This issue occurred before but it has now been fixed and a new release with the fix is on crates.io.
from hudhook.
Oh It was v0.6.1...
I started my project about a month ago with that version,
and thought I'm still using newest release because of github's stupid "3 weeks ago".
I'm really sorry for wasting your time.
from hudhook.
Same problem occured with hudhook v0.6.5
This time I can reliably reproduce it.
Try clicking outside the game window while focused triggers crash.
2024-04-08.22-01-12.mp4
To make sure I did cargo clean, update and build about three times and it still happens.
from hudhook.
All inputs on our end are correctly passed through add_mouse_event
. I do not know where that assertion could be triggered. Are you by chance doing ui.io_mut()[something] = ...
in your code? That is discouraged and will trigger the assertion above.
from hudhook.
As far as I know imgui::Ui
doesn't have io_mut()
method so it's certainly not happening.
For imgui::Context::io_mut()
which can be accessed on before_render()
,
there's some logic to update Io.delta_time
and Io.mouse_draw_cursor
.
from hudhook.
Right about ui.io_mut
, it's not a thing.
Have you tried what happens if you don't perform that logic? Please try to identify if any changes on your end result in this behavior going away so we can pinpoint the problem.
from hudhook.
Removed everything except hooking part but crash still happens.
use hudhook::{hooks::dx11::ImguiDx11Hooks, ImguiRenderLoop};
struct BlankContext;
impl ImguiRenderLoop for BlankContext {
fn render(&mut self, _ui: &mut imgui::Ui) {}
}
hudhook::hudhook!(ImguiDx11Hooks, BlankContext);
from hudhook.
You mentioned the docking branch in your first message. How are you accessing that? Are you compiling against a different underlying version of imgui
?
I reviewed our code but I couldn't find code paths that can ever hit that assertion, and also I do not have access to that game to test it myself. I need more information, a lot of it, if we hope to find out anything about this at all.
I encourage you to clone the repo locally and introduce log statements nearby the input related code, or at least implement the on_window_proc
method and log what messages are received by the game window, and report your findings. Thank you!
from hudhook.
After the first close of this issue I opt out for imgui docking because it seems unnecessary to me.
I accessed it via docking
feature of imgui
crate by the way.
I didn't test anything about the feature, so I've no idea it would work well with hudhook or not.
I will add log and collect info about why did it happen.
Slow progression expected since I'm not familiar with rust. (I'm C# main)
from hudhook.
There's no rush! Take your time. This is open source, it's all based on volunteering whatever time one wants or can. 😁
from hudhook.
I thought current release v0.6.5 includes commit f058304 (fix for #172).
Found out it doesn't, while checking for #176 breaking change on latest source.
I recompiled and checked over ten times with denial.
With hudhook = { git = "https://github.com/veeenu/hudhook.git", rev = "f058304463a28e0bd328dc35c85fabaeb0559bee" }
, problem is gone.
So ultimately I was trying to re-solve already fixed problem for two weeks. 🤦♂️
Thank you for your help.
from hudhook.
Related Issues (20)
- Update documentation
- Replace texture image data HOT 4
- Update `hudbook`
- Outdated HookBuilder documentation HOT 1
- `DirectComposition` is not implemented on Wine HOT 19
- A way to work together with detour ? HOT 4
- Errors on Resident Evil 2 and Testing on Other Games HOT 7
- Automated testing harness
- Add performance metrics
- Bump to `windows` 0.53
- Write a coobook
- An issue with version 0.6.5 HOT 8
- Support uploading images of any width HOT 1
- DX8 HOT 2
- Question about loading and using font HOT 3
- Plan for 0.7 HOT 4
- need ways to filter certain windows message, without blocking everything HOT 1
- hudhook pipeline doesn't report `delta_time` to imgui runtime HOT 1
- Bump imgui-rs to 0.12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hudhook.