Comments (8)
Vectorized
commented on July 2, 2024
Oh... u want 2612? We can add it. Nice suggestion.
from dn404.
Vectorized
commented on July 2, 2024
Not sure how many dapps would actually benefit from 2612.
from dn404.
commented on July 2, 2024
@Vectorized Maybe we want this instead? https://github.com/Uniswap/permit2 😈
from dn404.
AmadiMichael
commented on July 2, 2024
What if we go the route of auto approval of permit2 similar to polygon's POL token
from dn404.
Vectorized
commented on July 2, 2024
2612 or permit2… which one is cheaper?
from dn404.
AmadiMichael
commented on July 2, 2024
Depends. Permit2 can be used gaslessly so integrating it optionally here means that users do not have to approve permit2 for max uint256 beforehand. On the other hand, with 2612, not sure how many dapps use it.
Though it's important to think of the malicious signing attack vector that it introduces
from dn404.
Vectorized
commented on July 2, 2024
What is the canonical Permit2 address?
from dn404.
Vectorized
commented on July 2, 2024
Oh, saw it in POL.
from dn404.
Related Issues (20)
- DoS Vector: Transfering relatively large amounts of DN404 always `oog`s HOT 6
- 🐞 At example contract **NFTMintDN404** the minting checking allows to mint only once. HOT 3
- Get the NFT inventory of the wallet. HOT 1
- Revert on dn404Fallback if fn selector is not recognized. HOT 1
- ✨ Overrideable _msgSender() HOT 1
- Inquiry on Potential Gas or Security Issues for Large Supply Collections HOT 1
- I've completely rebuilt ERC404 to fix all issues(?)
- Problem for configuration setbaseuri tokenuri HOT 7
- Batch Minting like 721A's HOT 2
- ⚡️ Make tokenURI into internal _tokenURI
- Enhancing Liquidity for Existing NFTs: Implementing Lock-up Mechanism to Return DN404 Tokens with Matching Token IDs HOT 6
- Transfer on/off HOT 2
- Dosn't work with SafeTransferLib ? HOT 1
- ⚡️ Use updated FindFirstSet formulation
- ✨ Overrideable option to safe transfer NFTs
- 📢 Audit fixes incoming
- Set log handlers as internal virtual instead of private HOT 2
- ✨ Zero Indexed optionality
- ✨Omnichain compatibility using LayerZero
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dn404.