Enhancing Liquidity for Existing NFTs: Implementing Lock-up Mechanism to Return DN404 Tokens with Matching Token IDs about dn404 HOT 6 OPEN

Rough idea: fill in all 10k bits in the exists bitmap.

Then whenever a token is wrapped, we will directly mint on the exact ID.

When it's burned in DN404, unset the bit in the exists bitmap.

from dn404.

Thanks, I've written a contract based on your idea and will start testing it soon, I'll update and come here again.

https://github.com/abitofdots/convertERC721toDN404

from dn404.

@abitofdots You gotta prefill all 10k bits in exists bitmap too. It will cost some gas on deploy, but your customers won't need to pay that much gas.

Also, for _isTokenLocked, use Solady's LibBitmap, or the built-in bitmap in DN404. To save more gas.

from dn404.

Thnks you really ! Following what you said, I prefilled the existing bitmap with all 10,000 bits and replaced the existing bitmap with solady's LibBitmap.

Could you check the revised contract one more? Even if it's rough, It'd be very helpful for me.

https://github.com/abitofdots/convertERC721toDN404/blob/main/contracts/convertERC721toDN404.sol

from dn404.

@abitofdots Can you write some tests to ensure that only the original owner of the token can unwrap the token?

Don't take my word for an approval of safety. I'm only 10% alert right now.

Something we will need to account for the edge case of collection where the token IDs start from 0 instead of 1. But this is homework for another day.

from dn404.

Sure. I'll have the tests ready and share it with you soon. Thanks for your fast feedback always.

from dn404.