vechicin / debugging Goto Github PK

According to the code review this morning I'm sharing the findings of this activity:

• There is a bug setting the content of the result at the element because you're calling the function appendChild using a number as argument instead of an element, instead of that you might use textContent with the result of the formula or create a child element using document.createElement.
• I found two issues with the formula:
  • The first one is about performance and the limit of the cycles you need to run, so in the line 5 you could check i <= num just to be sure you reach all the possibilities
  • The second one is about the values you're adding to the Fibonacci array, so it's necessary to create a temporary variable to receive the value of the Fibonacci in line 7, check if this result is not bigger than the number, if that happens break the cycle, else save this result in the Fibonacci array.

Thank you very much for allowing me to test your code!