vbuterin / bitcoinjs-lib Goto Github PK

This class could be a great target for integration testing

The over-generalization/factory pattern is unnecessary. Implement as toBytes, toWif, toBin, etc. Same goes for import.

The signatures for an m-of-n transaction should be in the same order as the pubkeys. This seems to not be documented anywhere, but its expected to be that way (from #bitcoin-dev):

How does the matching between pubkeys and signatures work with m-of-n transactions? I'm looking here https://github.com/bitcoin/bitcoin/blob/master/src/script.cpp#L915-L935 and trying to debug it, and it seems like it never attempts one of the sigs against its matching pubkey
does it rely on some specific signature ordering or something?
shesek: yes, the signatures have to be in the same order as the public keys

I am still using my own handling for multisig signatures (it was written when I was still using the original bitcoinjs-lib, which doesn't support that), so I'm fixing it there right now, but I'll send a pull request to fix that once I move to using Script.createMultiSigInputScript (on my TODO list, along with a bunch of other stuff that I implemented in app-land that are now part of your fork).

It's never in sync anyway. As soon as we can create a stable release, we can minify per minor version.

CryptoJS seems discontinued, while SJCL is being maintained very hard.

SJCL includes hmac and sha512 needed for the HD wallets, and it also has support for window.crypto.getRandomValues() (https://github.com/bitwiseshiftleft/sjcl/blob/master/core/random.js#L455).

I think SJCL is a better choice.

This has to be the freshest bitcoinjs codebase on the net.
Its great to see how ative it is from the issues tracker.

Can we update the README and demos to convey stable features in this codebase?

I am trying to validated a pubkey and address pairs.
Is there a comparable function in bitcoinjs to pubkeytoaddress in pybitcointools that would create the same result?