vbardales / chai-properties Goto Github PK

Hi,

Thanks for this very nice chai plugin! IMHO, this functionality so useful, it should be integrated into the chai proper.

But here is the issue I've ran into this issue when using it. Currently, if the object under test has a property X that is itself an object, the assertion will only check that properties of expected.X are a subset of properties in actual.X. This may be dangerous as the users may be expecting the full comparison, and be missing hidden problems such as this one:

chai.expect({permissions: {limited: true, admin: true}})
  .to.have.properties({permissions: {limited: true}});

It would be nice to perform full equality rather than the subset check on the members of the expected properties, either by default or as a selectable option.
Thanks!

Chai 4 has been out for a while but chai-properties requires Chai <4.

chai-properties module is using the lodash's older version which is having vulnerability issue.

I tried raising a PR for the same. But I don't have access to create a branch in this repo.
Can we please have this change in package.json ?

"dependencies": {
    "lodash": "~4.17.11"
  }

Negated functions (subject.should.not.have.properties({ a: '1' });) aren't implemented but are shown in the README.

Line where negated functions throw error

Hi, and thanks for this.
I'm just starting with chai and couldn't believe it's not in the default assertions, TBH.
If you could register your lib on bower it could be helpful.
Thanks!