Git Product home page Git Product logo

vanilla-jsx's Issues

Fragments do not parse recursively

Hello,

I noticed a bug in your package today while testing it out: The Fragment() function only parses arrays one level deep. This means that components that use a return statement like the following will render a bunch of text nodes that read "[object HTMLElement]" to the document.

return (
    <>
      <SingleComponent prop={value} />
      {anArrayOfComponents}
    </>
  )

The following worked for me to correct this:

exports.Fragment = ({ children } = {}) => {
  const fragment = document.createDocumentFragment();

  if (!!children) {
    const flat = flattenChildren(children)
    flat.forEach(child => {
      fragment.appendChild(child)
    })
  }

  return fragment;
}

function flattenChildren (children) {
  let flat = []
  if (Array.isArray(children)) {
    children.forEach((child) => {
      flat = flat.concat(flattenChildren(child))
    });
  } else {
    flat.push(children);
  }
  return flat
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.