valksgodottools / godotutils Goto Github PK

Instead emit an event Logger::AddMessage that other projects can subscribe to

Context: I am working on developing a game server and I would like to know where to read / write to banned_players.json.

Should it be stored in
A) Local AppData
B) Roaming AppData
C) Local Game Folder
D) Somewhere else

I'm trying to get a demo going for this multiplayer code.

Implementing it all here https://github.com/Valks-Games/Sandbox2

Proving to be a challenge. All help is welcome.

Several people have recommended that I should replace all opcode enums with bytes.

The Packet classes get mapped to bytes.

I have tried to do this twice now and I've failed both times.

Why do this? To remove all ugly generics from ENetServer and ENetClient. Also this will simplify server.Send() as it will no longer require you to pass in a opcode as the packet class itself would act as the opcode. Also you would no longer have to worry about defining a opcode for each packet class you make.

If anyone can help me figure this out, it would be greatly appreciated!

Relevant Code

https://github.com/Valks-Games/GodotUtils/blob/fcabde81b7b68d73e8fb76185212a01b0d2567c4/Console/UIConsole.cs#L97

How to Reproduce

Spam console with text until the console scroll on the right becomes visible. In other words spam enough text to the console until it goes off screen. Then make sure you are scrolled to the very top of the console. Then re-open the console and you will notice that the console does not scroll to the bottom.

For example

var color = new UILabeledColorPickerButton(new LabeledColorPickerButtonOptions()); // <------
color.ValueChanged += v => Logger.Log(v);
AddChild(color);

Another example

var optionButton = new UILabeledOptionButton(new LabeledOptionButtonOptions("SomeTest", "AnotherOption")); // <------

optionButton.ValueChanged += (item) =>
{
	Logger.Log(item);
};

AddChild(optionButton);

There has to be a better approach to this.