Git Product home page Git Product logo

fullstak-auth-nextjs's Introduction

fullstak-auth-nextjs's People

Contributors

vahid-nejad avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

fullstak-auth-nextjs's Issues

Issues with refresh token

Great job on the template.

On refresh I noticed three issues:

  1. Although it successfully returns a new access token, it doesn't persist the new access token in the session which can also cause the refresh backend endpoint to be called multiple times, generating a new access token each time.

May be related to this: Tokens rotation does not persist the new token

Potential fix: Handling session updates & Updating the session

  1. The backend passes a field for expiresIn to determine the expiration of the access token. Why not just read the expiration directly from the jwt payload exp field?

Example in the jwt callback:

const jwtAccessPayload = JSON.parse(atob(access_token.split('.')[1]))
const AccessExpired = Date.now() >= jwtAccessPayload.exp * 1000
if (!AccessExpired) return token

If concerns about time difference, can also reduce jwt payload exp time given vs Date.now() by a few seconds

Can use the same logic to check refresh token expiration and that leads me to the third issue.

  1. No handling of the Refresh Token expiration?

Several ways to handle:
Redirect to login and update the session with the new jwt access and refresh tokens upon success.
Redirect to login and upon success redirect to previous page user was accessing.
Redirect to logout - bad UX if user was in the middle of changing data requiring an unexpired access and refresh token.

Middleware could be a solution for some of the issues as well - example middleware

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.