usuiat / zoomable Goto Github PK

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• Update compose to v1.5.0-alpha03 (androidx.compose.ui:ui-util, androidx.compose.ui:ui-tooling-preview, androidx.compose.ui:ui-tooling, androidx.compose.ui:ui-test-manifest, androidx.compose.ui:ui-test-junit4, androidx.compose.ui:ui, androidx.compose.runtime:runtime, androidx.compose.foundation:foundation, androidx.compose.animation:animation-core)

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update androidGradle to v8.0.1 (com.android.library, com.android.application)
• Update dependency org.jetbrains.kotlin.android to v1.8.21
• Update dependency org.jetbrains.kotlinx:kotlinx-coroutines-test to v1.7.0
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

The centroid of the gesture may not match the centroid of the zoom animation.

Double-tap followed by an upward drag will enlarge the image, while a downward drag will shrink it.

Is there an existing issue for this?

• I have searched the existing issues

Describe the problem

As of now, Zoomable supports a "double-tap + drag" zoom. Is it possible to support the arguably more usual "double-tap" zoom?
For example, it's a feature supported by PhotoView or Discord's image viewer.

Describe the solution

How it works:

• Double-tap once: scale = max scale / 2
• Double-tap again: scale = max scale
• Double-tap again: resets zoom
  See https://github.com/Baseflow/PhotoView/blob/master/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java#L231

Thanks.

Currently the alpha version support of Compose has been included in the main branch.
This makes it difficult to add new features.
Therefore, I will change the branch operation.

• Move the alpha version support of Compose to a dedicated branch.
• Merge v1.4.x support of Compose to the main branch.

We need to define the range requirement of maxScale argument of ZoomState constructor.

androidx foundation version : 1.5.0-beta01 (there's some api changes regarding the pager)
androidx material3 version : 1.1.0-alpha01

Zoomable modifier and gestures works just fine with scrolling for the first 2 pages on latest HorizontalPager, then it stops registering the gesture (clicks still works). In order to restore the functionality a configuration changes is required (rotate screen for ex).

I suspect the 1.5.0-beta01 is the culprit, but I would like your opinion regarding a possible fix regarding this sudden lack of registration.

After some debugging found out that the gesture is happening, but it cancels/stops just before zoomState.applyGesture in Zoomable.kt

I'm using coil's AsyncImages inside an HorizontalPager but since the time between the double tap zoom is kinda long, swiping relatively fast leads to unwanted zooms.
Im pretty sure this can be fixed by making the time between the 2 taps shorter.

Example: https://gyazo.com/2bc85ed503b4d5ab4772b610accbcd0d
In this example i wasn't trying to zoom in the images, but just to swipe between them.
Could you please fix it?

Modifier.zoomable stops working after swipeing the page of HorizontalPager.

With compose 1.5.0, this issue occurs. (I confirmed with 1.5.0-beta02)
With compose 1.4.3, it does not occur.

This may be a problem on the compose library side, but I will also investigate if it is possible to work around it on the Zoomable side.
If you know more information please let me know.

Related issues

• #64
• #73

There's some cases like the Gallery use case where the user can toggle systemui on single tap

I've tried adding the onSingleTap unit in the library but there's a small bug where if the zoom is quite high (> 5f), and a single tap is registered, there's a slight movement in the offset on every tap

Example code:

private suspend fun PointerInputScope.detectTransformGestures(
    ..
    onSingleTap: () -> Unit = {},
    enableOneFingerZoom: Boolean = true,
) = awaitEachGesture {
     ..
     if (isTap) {
     // Vertical scrolling following a double tap is treated as a zoom gesture.
        if (enableOneFingerZoom) {
        val secondDown = awaitSecondDown(firstUp)
            if (secondDown != null) {
                ..
            } else onSingleTap()
        ..
        } else onSingleTap()
     }
     
     onGestureEnd()
}