ustayready / credking Goto Github PK

Hello. The way that the clean_up function is currently set up allows for Lambda functions that are not created by CredKing to be deleted. This occurred in my cloud environment; CredKing was the tool that deleted these functions, confirmed via CloudTrail.

Instead of calling list_functions, I would suggest passing the 'arns' list defined on line 64 in credking.py to the clean_up function and then simply deleting the ARNs that you know were created by CredKing. This would prevent other Lambda functions that were not created by CredKing from being deleted during the clean up process.

I've modified the script to display the public IP that is in use by the lambda, and it seems "rotating IP addresses with each request." doesn't work properly. Each region has it's own public IP, but attempts that are scheduled on the same region use the same public IP until it is rotated by aws after a couple of hours.

Is there anything I'm missing?

hi,

when i run the command, i dont see any failed or success messages in the response. It should at least show any failed tries if the credentials didn't work.

python3 credking.py --plugin gmail --userfile users.txt --passwordfile test --access_key --secret_access_key

2020-10-29 06:21:54] Execution started at: 2020-10-29 06:21:54.211060
[2020-10-29 06:21:54] Loading credentials from users.txt and test
[2020-10-29 06:21:54] No validate function found for plugin: gmail
[2020-10-29 06:21:54] Creating build deployment for plugin: gmail
[2020-10-29 06:22:00] Created lambda arn:aws:lambda:us-east-2:313147307370:function:gmail_375711230 in us-east-2
[2020-10-29 06:22:00] User/Password Combinations: 40
[2020-10-29 06:22:00] Total Regions Available: 15
[2020-10-29 06:22:00] Total Lambdas: 1
[2020-10-29 06:22:00] Launching spray using arn:aws:lambda:us-east-2:313147307370:function:gmail_375711230...
[2020-10-29 06:22:02] Cleaning up lambdas in us-east-2...
[2020-10-29 06:22:02] Destroying arn:aws:lambda:us-east-2:313147307370:function:gmail_375711230:1 in region: us-east-2
[2020-10-29 06:22:02] End Time: 2020-10-29 06:22:02.186279
[2020-10-29 06:22:02] Total Execution: 7.975219 seconds

I even submitted few valid Gmail credentials in there that I know work but I didn't see any response back.