usox / hackttp Goto Github PK

You probably want use type Facebook\HackTest\DataProvider

If request_output is directly passed, then writing to the stream will take effect immediately.

Nothing should be written to real output until it's actually dealt finished

For example:

await $r->withHeader('foo', vec['bar'])->getBody()->writeAsync("Herp derp");

... the header will not be set as the response body will have been sent before anything else can be done with the request

e.g. an equivalent to (new Zend\Diactaros\Response\SapiEmitter())->emit($response);

hhvm/hack-http-request-response-interfaces#10

We need to check whether the current header handling complies with the rules provided by the interfaces (normalization and such)

ServerRequest is currently untested due to some open issues on the interface side. Those issues are withdrawn (for now), so we can finalize ServerRequest

AIUI once that's done, this is ready to use for the brave :)

This has an \HH\Asio\join(), which is unsafe; https://github.com/hhvm/hsl-experimental/pull/127/files#diff-580930ba292ece1b544999243167b56dR213 is an example of how this can stall forever (as well as being bad for performance)

It's nice to have unittests, but we really need some integration-tests, too... But wait until #6 is finished

I've already added some code regarding a potential UriInterface change in hhvm/hack-http-request-response-interfaces#12. Not sure if this will be accepted, so I guess there will be more work todo...

hhvm/hack-http-request-response-interfaces#11

a5ba0a2 is needed; HHVM 4.109 includes has the HSL built-in, including the change that led to that commit.

Currently, there is only UploadedStream. So we need at least an UploadedFile version to deal with files which have been uploaded - maybe more to come...

I expected to be passing in a handle

this issue is encountered with $_FILES and $_COOKIE

reproduce :

$_FILES :

$_FILES = [
    'slide-shows' => [
      'tmp_name' => [
        // Note: Nesting *under* tmp_name/etc
        0 => ['slides' => [0 => __FILE__, 1 => __FILE__]],
      ],
      'error' => [0 => ['slides' => [0 => 0, 1 => 0]]],
      'name' => [0 => ['slides' => [0 => 'foo.txt', 1 => 'bar.txt']]],
      'size' => [0 => ['slides' => [0 => 123, 1 => 200]]],
      'type' => [0 => ['slides' => [0 => 'text/plain', 1 => 'text/plain']]],
    ],
  ];

$_COOKIE :

$_COOKIE = [
  'foo' => ['bar', 'bar' => 'baz', 'qux' => 'dux'],
  'bar' => ['bar' => ['baz' => ['qux' => 'dux']]]
];

see : https://github.com/azjezz/http-normalizer#normalize

Waiting for hhvm/hack-http-request-response-interfaces#13 to be resolved...

Currently, the -dev dependencies are effectively non-dev dependencies in the typechecker.

Can be worked around with ignored_paths, but should ideally be ignored.

$ hh_client
vendor/usox/hackttp/tests/RequestFactoryTest.hh:15:12,15: Unbound name (typing): Usox\HackMock\mock (Typing[4107])
vendor/usox/hackttp/tests/RequestFactoryTest.hh:15:12,15: Unbound name: Usox\HackMock\mock (a global constant) (Naming[2049])
vendor/usox/hackttp/tests/RequestFactoryTest.hh:15:12,15: Unbound name: Usox\HackMock\mock (a global function) (Naming[2049])
vendor/usox/hackttp/tests/RequestFactoryTest.hh:17:5,12: Unbound name (typing): Usox\HackMock\prospect (Typing[4107])
vendor/usox/hackttp/tests/RequestFactoryTest.hh:17:5,12: Unbound name: Usox\HackMock\prospect (a global constant) (Naming[2049])
vendor/usox/hackttp/tests/RequestFactoryTest.hh:17:5,12: Unbound name: Usox\HackMock\prospect (a global function) (Naming[2049])

For example, https://github.com/hhvm/hsl/blob/master/.gitattributes