usagi-coffee / tree-sitter-abl Goto Github PK

View Code? Open in Web Editor NEW

4.0 3.0 0.0 12.81 MB

OpenEdge ABL grammar for tree-sitter

License: MIT License

Python 0.01% C++ 0.01% JavaScript 0.50% Rust 0.05% C 99.44%

openedge-abl tree-sitter tree-sitter-parser abl parser 4gl openedge progress progress4gl

tree-sitter-abl's People

Contributors

Stargazers

Watchers

tree-sitter-abl's Issues

Error when using few related tables

Error when using few related tables (for each, each; for each, last; for each, first...)

Class_statement is not identified as the whole class (ends with first END statement).

Issues when parsing objects

Example:

FUNCTION GET_STUFF RETURNS Progress.Json.ObjectModel.JsonObject (cParam1 AS CHARACTER):
    DEFINE VARIABLE jsonTableRow AS Progress.Json.ObjectModel.JsonObject NO-UNDO.
    RETURN jsonTableRow.
END FUNCTION.

Result on one of the nodes:
Type: ERROR
Text: Progress.Json.ObjectModel.JsonObject (cParam1 AS

Implement REPEAT statement

This snippet returns an error:

repeat while true:
end.

It should be easy as REPEAT has basically identical structure to DO statement.

Error for comment with "//"

Currently, parser does not understand comments defined using //

Lock modifier is not detected if it's located before where clause.

Example:
find Vacation no-lock where Vacation.id = 123.

Result:
Parser isn't able to recognize no-lock before where clause. It returns ERROR type node.

Incorrect parsing

In this statement it picks "Order" as OR

More operator precedence issues

First of all, thank you for fixing the previous issue (#2) so fast!

While experimenting a bit more, I found more precedence errors; the grammar currently parses the following code incorrectly:

x = NOT 2 + 2 = 5.

Giving the following syntax tree:

(source_code
  (statement
    (variable_assignment
      (assignment
        (identifier)
        (expression
          (binary_expression
            (additive_expression
              (expression
                (unary_expression
                  (expression
                    (number_literal))))
              (additive_operator)
              (expression
                (comparison
                  (expression
                    (number_literal))
                  (comparator)
                  (expression
                    (number_literal))))))))
      (terminator))))

As if it were equivalent to x = ((NOT 2) + (2 = 5)). instead of x = (NOT ((2 + 2) = 5))..

Note that the issue doesn't occur for x = NOT 5 = 2 + 2..

Issues when parsing default error scope statement

Examples:
ROUTINE-LEVEL ON ERROR UNDO, THROW.

BLOCK-LEVEL ON ERROR UNDO, THROW.

Result:
Parser error on , THROW node

Errors on ASSIGN

Code is from https://docs.progress.com/bundle/openedge-oo-abl-develop-applications-117/page/Sample-classes.html

Error on ABSTRACT keyword

Code is from https://docs.progress.com/bundle/openedge-oo-abl-develop-applications-117/page/Sample-classes.html

USING is not identified.

Can't use logic operators in expressions

The following code fails to parse:

x = YES AND NO.
y = YES OR NO.

Tree-sitter generates the following AST:

(source_code
  (statement
    (variable_assignment
      (assignment
        (identifier)
        (ERROR
          (expression
            (boolean_expression)))
        (expression
          (boolean_expression)))
      (terminator)))
  (statement
    (variable_assignment
      (assignment
        (identifier)
        (ERROR
          (expression
            (boolean_expression)))
        (expression
          (boolean_expression)))
      (terminator))))

Grammar railroad diagram

Using this page https://meimporta.eu/tree-sitter/json2ebnf.html we can get a navigable railroad diagram for tree-sitter grammars like this project.

Unary minus can't be used with many expressions

Trying to use the unary minus operator with parenthesized expressions, function calls, object accesses, or field accesses result in the error trees being generated. Example:

w = -(0).
x = -f().
y = -table.field.
z = -obj:method().

For the example above, the grammar generates the following tree:

(source_code
  (variable_assignment
    (assignment
      (identifier)
      (ERROR)
      (parenthesized_expression
        (number_literal))))
  (variable_assignment
    (assignment
      (identifier)
      (ERROR
        (unary_expression
          (identifier)))
      (comparison_expression
        (identifier)
        (unary_expression
          (identifier)))))
  (abl_statement
    statement: (identifier))
  (variable_assignment
    (assignment
      (identifier)
      (ERROR
        (unary_expression
          (identifier)))
      (function_call
        function: (identifier)))))

Error in multi-level sorting

Temp-table parsing is not implemented

Currently, temp-table parsing is not implemented.

Parentheses are not working

Wrong precedence of unary expression w/ logical expressions

NOT x < 10 AND x = 10

Parses to

(unary_expression
  (logical_expression
    (comparison_expression
      (identifier)
      (number_literal))
    (comparison_expression
      (identifier)
      (number_literal)))))))

As if it was NOT (x < 10 AND x = 10), should be (NOT x < 10) AND x = 10.

Error on OVERRIDE keyword

Code is from https://docs.progress.com/bundle/openedge-oo-abl-develop-applications-117/page/Sample-classes.html

Error on this method.

Code is from https://docs.progress.com/bundle/openedge-oo-abl-develop-applications-117/page/Sample-classes.html

Error when parsing ELSE block

Example:

define variable a as integer no-undo.
define variable b as integer no-undo.

if a = b then message "A".
else do:
    message "B".
end.

Result:
Does not work when ELSE has do-end block

Method is identified as abl_statement.

Interface is identified as abl_statement.

Incorrect precendence of the `NOT` operator

In test/corpus/basic.txt, the expected output of z = NOT y > 5. is incorrectly defined as:

(variable_assignment
  (assignment
    (identifier)
    (expression
      (comparison
        (expression
          (unary_expression
            (expression
              (identifier))))
        (comparator)
        (expression
          (number_literal)))))
  (terminator))

As if it were equivalent to z = ((NOT y) > 5)., but OpenEdge ABL interprets this as being equivalent to z = (NOT (y > 5))..

The issue stems from the fact that the NOT operator is defined as having a higher precedence than the comparison operator in grammar.js, contrary to the precedence table given in the ABL reference.

The same issue occurs in the "FIND FIRST (no terminator) statement" and the "TERNARY EXPRESSION (parenthesised) statement" test cases.

Wrong precedence of logical operators

While working on #6, I identified a case where the parser emits an incorrect syntax tree, for the following code:

y = x < 10 OR x = 10.

Here's the emitted syntax tree:

(source_code
  (statement
    (variable_assignment
      (assignment
        (identifier)
        (expression
          (comparison
            (expression
              (identifier))
            (comparator)
            (expression
              (logical_expression
                (expression
                  (number_literal))
                (logical_operator)
                (expression
                  (comparison
                    (expression
                      (identifier))
                    (comparator)
                    (expression
                      (number_literal)))))))))
      (terminator))))

The code is parsed as if it were equivalent to:

y = (x < (10 OR (x = 10))).

But the OpenEdge ABL parses it as:

y = ((x < 10) OR (x = 10)).

usagi-coffee / tree-sitter-abl Goto Github PK

tree-sitter-abl's People

Contributors

Stargazers

Watchers

tree-sitter-abl's Issues

Recommend Projects

Recommend Topics

Recommend Org