urre / acf-fold-flexible Goto Github PK

Hey! Seems to be an issue with the icons on the foldable fields in the latest versions of your plugin + ACF Pro.

They're all showing by default, and on toggling a field they all disappear.

Uploaded a video here: http://quick.as/22jzcpej2

Advanced Custom Fields PRO v5.3.10
ACF Fold Flexible Content v1.3.1

Hey! Awesome plugin, however I noticed that if you click directly on the arrow icon, the field doesn't toggle (although the icon does).

I've recorded an example:
https://www.dropbox.com/s/rnfvnx8uehsqz48/acf_fold_flex_bug.mov?dl=0

If so, how can I do this please.

When clicking on the header area, sometimes the field doesn't hide its content. The header gets gray and a plus icon appears though.

Sometimes, the active state of a section gets wrong. I think your plugin assumes that all sections are initially closed. But starting from ACF PRO v5 (I think), the open/closed states of the flexible content sections is saved. An open section will be kept open when reloading/updating the edit screen.

This screenshot illustrates the problem:

Section 6 is ok.
Section 7 is closed but highlighted.
Section 8 is open but not highlighted.

This doesn't seem to work with ACF pro. Would be nice to see some support for it :)

I don't have time to do a pull request, but I notice that the "open" class is not correctly added/removed from newly added fields when they are collapsed/expanded. (i.e. they always stay blue)

This could be fixed by passing a selector to on() at line 96 of acf-fold-flexible.admin.js:

$('.acf-postbox').on('click', '.acf-fc-layout-handle', function() {