Git Product home page Git Product logo

uk-modulus-checking's People

Contributors

franciscocardoso avatar gunjam avatar htmlandbacon avatar nelsonbrandao avatar nunofgs avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

uk-modulus-checking's Issues

Can't resolve 'fs'

import UkModulusChecking from 'uk-modulus-checking';
or
const UkModulusChecking = require('uk-modulus-checking')

throwing

`client?843a:157 ./~/uk-modulus-checking/dist/index.js

Module not found: Error: Can't resolve 'fs' in '/Users/Leo/Documents/Projects/thehouseshop/public/rentscore-app/node_modules/uk-modulus-checking/dist'`

Incorrect validation

Some swapped values (accountNumber and sortCode) are being accepted as valid.

Incorrect handling of 9 digit account numbers for non-Santander sort codes

Hi, I am leaving an issue on a few of the modulus checking libraries on Github as they all seem to have the same issue (including our implementation at Monzo Bank). While the Vocalink modulus checking requirements specifically call out that Santander is the only bank that has 9 digit account numbers we have noticed that in practice other banks may also use 9 digit account numbers.

Specifically Coventry Building Society has this information in their FAQ

We use 9 digit account numbers - simply remove the first digit when giving your account number

The best way we thought of handling this would be to specifically use the documented logic in the modulus checking requirements only for sort codes used by Santander. For other 9 digit account numbers we simply remove the leading digit.

Based on this page we have defined this range as

090000-091900
720000-729999
890000-892999
165710

I hope this information helps, let me know if you have any other questions!

Add length validation to sort code

We've received confirmation from IBAN Support that:

The maximum length of a sort code is 6 digits.
The documentation had it wrong, we had just corrected it in the website to avoid further confusion.
You should limit user input to six digits for the sort code field to avoid abnormal results.

Please add a maximum length of 6 validation to the sort code parameter.

Import issue

Hi!
I have problems importing this module.
After installing it via npm and importing it like:

import UkModulusChecking from 'uk-modulus-checking/src'
import UkModulusChecking from 'uk-modulus-checking'
var UkModulusChecking = require('uk-modulus-checking')

I always end up with the same error:

This dependency was not found:

  • fs in ./~/uk-modulus-checking/src/index.js
    To install it, you can run: npm install --save fs

I tried installing fs, but it doesn't change anything.
I am using Vue.js on my project.
Looks like I am missing something to do before importing

Uncaught ReferenceError: exports is not defined

Hi. Just the plugin I was looking for!

In my project I'm using fetch-inject, which basically add the required script to the page when I need it so I don't do any changes with the used plugin.
Unfortunately this plugin gives me this error when I inject to the page.

Do you think you can add the version without Object.defineProperty(exports, "__esModule", { as well?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.