unleashit / npm-library Goto Github PK

If a nested array has only one item, for some reason it is getting a leaf-object css class. If the array has more items, it gets the correct class.

Components affected: Login and Signup

If the submit handlers don't receive a response, Formik stays in loading state. Need to handle the form state in a catch.

Does it render depending on the width of the container?

Issues with defaultProps and HOCs.

Components affected: Login and Signup

When Formik runs a validation of the form, any checkbox fields are getting checked. Only happens when validation finds errors (form submits with the correct request body as long as validation is passing).

Consider moving from webpack to compiling with typescript (and babel?).

Helpful link: https://blog.newrelic.com/engineering/best-practices-shared-ui-libraries/

Reasons:

• no bundle, compile one-to-one
• consumer can receive minor/patch updates of deps directly
• peer deps not listed in webpack externals can bloat webpack bundles
• tree shaking: offer both commonjs and es6 module options
  • babel may be needed for this (not sure if typescript can do it alone)
  • .babelrc can be configured for the two environments (see below)
  • main property with path to es6 added to package.json

Issues:

• if not using Webpack, will need an alternate build system (Gulp?) for sass, images/assets, svgr, etc.
• imports of scss/assets will need to be removed from code. No more CSS Modules

Sample .babelrc for dual module types:

{
"env": {
  "commonjs": {
     "plugins": [
       "transform-runtime",
       ["transform-react-remove-prop-types", { "mode": "wrap" }]
     ],
     "presets": [ "env", "react" ]
 },
 "esmodules": {
    "plugins": [
      "transform-runtime",
      ["transform-react-remove-prop-types", { "mode": "wrap" }]
    ],
    "presets": [
      ["env", { modules: false }],
      "react",
    ]
  }
 }
}

$ BABEL_ENV=commonjs babel src/ --out-dir build/commonjs
$ BABEL_ENV=esmodules babel src/ --out-dir build/es