unix1 / cowboy_fcgi Goto Github PK

Steps to repro:

• make run the example
• curl --http2 -v http://localhost:33080/hello.php

Expected result: response from hello.php

Actual result:

...
http2 error: Invalid HTTP header field was received: frame type: 1, stream: 1, name: [Content-Type], value: [text/plain;charset=UTF-8]
...

Steps to repro:

• make run the example
• create a foo/bar.php file with some PHP content under priv/www directory
• make an HTTP request to /foo/bar.php

Expected result: bar.php executes and its response is received by the client.

Actual result: Cowboy 404 response.

While remaining compatible with rebar3 per #3 move Makefile to use erlang.mk.

Requirements:

• it should still compile with legacy rebar
• it should be fully compatible with rebar3

While testing the fcgi client on Cowboy 2.0.0 using siege, after making some thousands of requests cowboy/ranch will report a crash such as this:

Ranch listener fcgi, connection process <0.830.4>,
stream 1 had its request process <0.842.4> exit with reason {case_clause,undefined}
and stacktrace
[
  {cowboy_http_fcgi,init,2,[{file,"src/cowboy_http_fcgi.erl"},{line,61}]},
  {cowboy_handler,execute,2, [{file,"src/cowboy_handler.erl"},{line,37}]},
  {cowboy_stream_h,execute,3, [{file,"src/cowboy_stream_h.erl"},{line,205}]}
  {cowboy_stream_h,request_process,3,[{file,"src/cowboy_stream_h.erl"},{line,184}]},
  {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}
]

For few seconds the test "hangs" waiting for responses. The requests eventually time out after exactly 15 seconds with 504 (gateway timeout) responses. After this the system recovers and requests may continue.

Line 61-62 in cowboy_http_fcgi are

State = case whereis(Name) of
  Server when is_pid(Server) ->

This means whereis is probably not finding the locally registered process anymore. This means the process has likely crashed.