• I'm submitting a bug report and feature request
  When I trade with RING/ETH pair at app.uniswap.org. An HTTP 500 error occur.

~ curl 'https://api.uniswap.org/v1/quote?protocols=v2%2Cv3&tokenInAddress=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2&tokenInChainId=1&tokenOutAddress=0x9469D013805bFfB7D3DEBe5E7839237e535ec483&tokenOutChainId=1&amount=11613710000000&type=exactIn' \
        -H 'authority: api.uniswap.org' \
        -H 'pragma: no-cache' \
        -H 'cache-control: no-cache' \
        -H 'accept: */*' \
        -H 'origin: https://app.uniswap.org' \
        -H 'sec-fetch-site: same-site' \
        -H 'sec-fetch-mode: cors' \
        -H 'sec-fetch-dest: empty' \
        -H 'referer: https://app.uniswap.org/' \
        --compressed

{"errorCode":"INTERNAL_ERROR","detail":"Unexpected error","id":"1e381"}

I figure out that is a smart-order-router API query, and then I try it by smart-order-router CLI.

~ ./bin/cli quote --tokenIn 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2 --tokenOut 0x9469d013805bffb7d3debe5e7839237e535ec483 --amount 1000 --exactIn --recipient 0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B --protocols v2,v3 --debug
INFO:  [Metric]: TokenListLoad: 1 | Milliseconds
  key: "TokenListLoad"
  value: 1
  unit: "Milliseconds"
INFO:  Found 1 out of 2 tokens in local cache. Checking primary token provider for 1 tokens

  addressesToFindInPrimary: ["0x9469d013805bffb7d3debe5e7839237e535ec483"]
INFO:  Found 0 tokens in primary. Checking secondary token provider for 1 tokens
  addressesToFindInSecondary: ["0x9469d013805bffb7d3debe5e7839237e535ec483"]
DEBUG: About to multicall for symbol across 1 addresses
  calls: [{"target":"0x9469d013805bffb7d3debe5e7839237e535ec483","callData":"0x95d89b41...
DEBUG: About to multicall for decimals across 1 addresses
  calls: [{"target":"0x9469d013805bffb7d3debe5e7839237e535ec483","callData":"0x313ce567...
DEBUG: Results for multicall on decimals across 1 addresses as of block 13900877
  results: [{"success":true,"result":[18]}]
    Error: call revert exception (method="symbol()", errorArgs=null, errorName=null,
    errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.5.0)
    Code: CALL_EXCEPTION

A call revert error occurred, I think the reason is RING's symbol type is bytes32 not the string. This is a historical reason. dapphub/ds-token#28
And there is a lot of token like MKR have the same issue, but the MKR token is in the @uniswap/default-token-list, so it has no effect on MRK.
But other tokens like RING got hit. And I file an issue at Uniswap/default-token-list#1031.
To verify my idea, I added RING to @uniswap/default-token-list locally. It works 🚀

~ ./bin/cli quote --tokenIn 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2 --tokenOut 0x9469d013805bffb7d3debe5e7839237e535ec483 --amount 1000 --exactIn --recipient 0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B --protocols v2,v3
Best Route:
[V2] 85.00% = WETH --> RING, [V3] 15.00% = WETH -- 0.3% --> RING
        Raw Quote Exact In:
                16472715.82
        Gas Adjusted Quote In:
                16470330.17

Gas Used Quote Token: 2385.644467
Gas Used USD: 104.133692
Calldata: 0x5ae401dc0000000000000000000000000000000000000000000000000000000000000064000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000016000000000000000000000000000000000000000000000000000000000000000e4472b43f300000000000000000000000000000000000000000000002e141ea081ca0800000000000000000000000000000000000000000000000b658b561723e7673ef0a70000000000000000000000000000000000000000000000000000000000000080000000000000000000000000ab5801a7d398351b8be11c439e05c5b3259aec9b0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc20000000000000000000000009469d013805bffb7d3debe5e7839237e535ec4830000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000e404e45aaf000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc20000000000000000000000009469d013805bffb7d3debe5e7839237e535ec4830000000000000000000000000000000000000000000000000000000000000bb8000000000000000000000000ab5801a7d398351b8be11c439e05c5b3259aec9b00000000000000000000000000000000000000000000000821ab0d44149800000000000000000000000000000000000000000000000238f21b6c7dcd9b6dd4cb000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
Value: 0x00

  blockNumber: "13900919"
  estimatedGasUsed: "228000"
  gasPriceWei: "121520560130"

• Summary
  There are two ways to fix the issue, Add RING token to @uniswap/default-token-list Uniswap/default-token-list#1031 or support ERC20 which isfunction symbol() view returns (bytes32)

I'm submitting a bug report.

Summary
When trying to run smart-order-router agains local mainnet fork, I get this error:

  code: 'SERVER_ERROR',
  body: '{"jsonrpc":"2.0","id":52,"error":{"code":-32602,"message":"Errors encountered in param 0: Invalid value 4 supplied to : QUANTITY"}}',
  error: Error: Errors encountered in param 0: Invalid value 4 supplied to : QUANTITY
      at getResult (/snapshot/liquidator/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:142:21)
      at processJsonFunc (/snapshot/liquidator/node_modules/@ethersproject/web/lib/index.js:344:22)
      at /snapshot/liquidator/node_modules/@ethersproject/web/lib/index.js:276:46
      at step (/snapshot/liquidator/node_modules/@ethersproject/web/lib/index.js:33:23)
      at Object.next (/snapshot/liquidator/node_modules/@ethersproject/web/lib/index.js:14:53)
      at fulfilled (/snapshot/liquidator/node_modules/@ethersproject/web/lib/index.js:5:58)
      at processTicksAndRejections (node:internal/process/task_queues:96:5) {
    code: -32602,
    data: undefined
  },
  requestBody: '{"method":"eth_feeHistory","params":[4,"latest",[50]],"id":52,"jsonrpc":"2.0"}',
  requestMethod: 'POST',
  url: 'http://127.0.0.1:8550/'
}

Other information
According to this spec, 1st argument of eth_feeHistory needs to be hex-encoded

Similar issue: web3/web3.js#4510

We worked around this by forking EIP1559GasPriceProvider and changing this:

      const feeHistoryRaw = (await this.provider.send('eth_feeHistory', [
        this.blocksToConsider,
        'latest',
        [this.priorityFeePercentile],
      ])) as RawFeeHistoryResponse;

to this:

      const feeHistoryRaw = (await this.provider.send('eth_feeHistory', [
        "0x" + this.blocksToConsider.toString(16),
        'latest',
        [this.priorityFeePercentile],
      ])) as RawFeeHistoryResponse;

Trying to find a route between e.g. NMR and BAL, this fails:

NMR : 0x1776e1F26f98b1A5dF9cD347953a26dd3Cb46671
BAL : 0xba100000625a3754423978a60c9317c58a424e3D

./bin/cli quote --tokenIn 0x1776e1F26f98b1A5dF9cD347953a26dd3Cb46671 --tokenOut 0xba100000625a3754423978a60c9317c58a424e3D --amount 1000 --exactIn --recipient 0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B
Could not find route. Run in debug mode for more info.

But it seems to work ok at https://app.uniswap.org/#/swap

Other pairs do work as expected.

I ran with the debugger (--inspect) but this doesn't give me any more info. I'm using Alchemy as the JSON-RPC host

• I'm submitting a ...
  [ ] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [V] question about how to use this project

• Summary

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

I got ProviderGasError from my own node, I saw the same issue in #10 , but Im not sure what configuration of node should i change

• I'm submitting a ...
  [x ] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary
  routing-api integration tests fail when testing the eth->erc20 (UNI) with exactOut and through V2 pools. Namely, an exact output is not achieved, rather:

      AssertionError: expected '10000.000000000000000171' to equal '10000'
      + expected - actual

      -10000.000000000000000171
      +10000

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

This branch on my fork of routing-api repo reproduces https://github.com/zhongeric/routing-api/tree/eric/swapped-dust-bug-repro

Additionally, the bug can be seen on my fork of this repo SOR: https://github.com/zhongeric/smart-order-router/tree/eric/refactor-integ-tests

we deployed to kintsugi using the deploy script, but the addresses are not the same. the sor package assumes all addresses are the same

• I'm submitting a ...
  [X] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

getting below error :

C:\Users\smart-order-router-main>npm run build
npm WARN config global --global, --local are deprecated. Use --location=global instead.

@uniswap/[email protected] build
run-p compile-v3-types compile-v2-types compile-router compile-external-types && run-p build:*

@uniswap/[email protected] compile-external-types
npx typechain --target ethers-v5 --out-dir src/types/other 'src/abis/**/*.json'

@uniswap/[email protected] compile-v3-types
npx typechain --target ethers-v5 --out-dir src/types/v3 './node_modules/@uniswap/?(v3-core|v3-periphery)/artifacts/contracts/**/*.json'

@uniswap/[email protected] compile-router
npx typechain --target ethers-v5 --out-dir src/types/other './node_modules/@uniswap/swap-router-contracts/artifacts/contracts/**/*.json'

@uniswap/[email protected] compile-v2-types
npx typechain --target ethers-v5 --out-dir src/types/v2 './node_modules/@uniswap/?(v2-core|v2-periphery)/build/UniswapV2.json'

'v3-periphery)' is not recognized as an internal or external command,
operable program or batch file.
'v2-periphery)' is not recognized as an internal or external command,
operable program or batch file.
ERROR: "compile-v3-types" exited with 255.

• I'm submitting a ...
  [ X ] bug report
  [ X ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary
  Rebasing tokens, such as AMPL, do not work correctly on V3. However users can still create pools using them, and those pools end up with invalid prices that can cause the auto router to try and route through them.

We haven't seen an instance of this happening yet, but this is what happened with Fee On Transfer tokens here, which we solved using the TokenValidator lens.

We should find a way to detect rebasing tokens in the auto router and force them to use V2.

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Calculate swap amount based on market price of target pool then get swap using existing routing-api endpoints.

I'm running this code with a local JSON-RPC node but finding it to be pretty slow (8 core 4ghz, 32 GB RAM, all SSDs etc) . It averages around 7 seconds to generate a route, vs ~2-3 seconds for the public endpoint that serves the Uniswap UI. Are there any optimizations that might be used to speed things up? Caching, or excluding certain pools perhaps?

• I'm submitting a ...
  [ x ] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary

If you are using the smart-order-router and calling the route function, when the router calculates the gas price by converting the liquidity in the pool into a number, it throws an error. See error stack V3HeuristicGasModelFactory.getHighestLiquidityUSDPool
Pool address where this error ocurse is: 0x9957c4795ab663622db54fc48fda874da59150ff
ChainId is 1

I assume the number is bigger than Number.MAX_SAFE_INTEGER?

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Call Stack
JSBI.valueOf
node_modules/jsbi/dist/jsbi.mjs (1:1233)
baseGt
node_modules/@uniswap/smart-order-router/node_modules/lodash/lodash.js (3124:0)
baseExtremum
node_modules/@uniswap/smart-order-router/node_modules/lodash/lodash.js (2909:0)
Function.maxBy
node_modules/@uniswap/smart-order-router/node_modules/lodash/lodash.js (16407:0)
V3HeuristicGasModelFactory.getHighestLiquidityUSDPool
node_modules/@uniswap/smart-order-router/build/module/src/routers/alpha-router/gas-models/v3/v3-heuristic-gas-model.js (201:25)
async V3HeuristicGasModelFactory.buildGasModel
node_modules/@uniswap/smart-order-router/build/module/src/routers/alpha-router/gas-models/v3/v3-heuristic-gas-model.js (67:0)
async AlphaRouter.getV3Quotes
node_modules/@uniswap/smart-order-router/build/module/src/routers/alpha-router/alpha-router.js (370:0)
async AlphaRouter.route
node_modules/@uniswap/smart-order-router/build/module/src/routers/alpha-router/alpha-router.js (293:0)

Both Arbitrum and Optimism account for gas differently.

Known differences (not exhaustive list)
Arbitrum gas units are different- opcodes are priced differently, so swaps cost different amounts
Optimism charges a fee based on the size of the calldata that would need to be sent to L1
Arbitrum has 2 seperate gas meters- one for compute and one for storage

We likely need changes to:

1. The heuristics we use for estimating gas on V3 and V2 swaps. Probably need to make this code chain aware and adjust the values

https://github.com/Uniswap/smart-order-router/blob/main/src/routers/alpha-router/gas-models/v3/v3-heuristic-gas-model.ts#L16-L26
https://github.com/Uniswap/smart-order-router/blob/main/src/routers/alpha-router/gas-models/v2/v2-heuristic-gas-model.ts

Easiest way to figure out the new values might be to use Tenderly to fork Arb/Opt, use the CLI to generate swaps that cross different amount of ticks and get the calldata, then simulate the swaps on the Tenderly forks to see how much gas they use

2. How we compute gas price. On Optimism for example eth_gasPrice always return 1000000, which I'm not sure is correct. On Arb its not clear if we capture everything we need by querying eth_gasPrice (also unclear if we need to capture both when estimating gas)

https://github.com/Uniswap/smart-order-router/blob/main/src/providers/on-chain-gas-price-provider.ts

Handle overriding to 5 in routing api

Optimism is updating their sequencer to use a compression alg for lower gas costs. Since we are calculating the gas manually in the gas model we'll need to update the calldata bytes to reflect how the compression is generating calldata.

Referencing this post

Getting this error for WETH->DAI and other pairs, e.g.

WETH : 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
DAI : 0x6B175474E89094C44Da98b954EedeAC495271d0F

./bin/cli quote --tokenIn 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2 --tokenOut 0x6B175474E89094C44Da98b954EedeAC495271d0F --amount 1000 --exactIn --recipient 0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Error: Failed to get 3 quotes. Reasons: ProviderGasError, ProviderGasError, ProviderGasError

I'm submitting a ...

• bug report
• feature request
• question about the decisions made in the repository
• question about how to use this project

Summary

AlphaRouter.routeToRatio uses hard coded swap router address.

https://github.com/Uniswap/smart-order-router/blob/main/src/providers/swap-router-provider.ts#L12
This does not work on the Polygon network.

Other information

I'm trying out the swap-and-add on the Polygon network.

• I'm submitting a ...
  [ ] question about how to use this project

npm run build keeps failing. It says

'v3-periphery)' is not recognized as an internal or external command,
operable program or batch file.

details:

> @uniswap/[email protected] build
> run-p compile-v3-types compile-v2-types compile-router compile-external-types && run-p build:*


> @uniswap/[email protected] compile-v2-types
> npx typechain --target ethers-v5 --out-dir src/types/v2 './node_modules/@uniswap/?(v2-core|v2-periphery)/build/*UniswapV2*.json'


> @uniswap/[email protected] compile-v3-types
> npx typechain --target ethers-v5 --out-dir src/types/v3 './node_modules/@uniswap/?(v3-core|v3-periphery)/artifacts/contracts/**/*.json'


> @uniswap/[email protected] compile-router
> npx typechain --target ethers-v5 --out-dir src/types/other './node_modules/@uniswap/swap-router-contracts/artifacts/contracts/**/*.json'


> @uniswap/[email protected] compile-external-types
> npx typechain --target ethers-v5 --out-dir src/types/other 'src/abis/**/*.json'

'v3-periphery)' is not recognized as an internal or external command,
operable program or batch file.
'v2-periphery)' is not recognized as an internal or external command,
operable program or batch file.
ERROR: "compile-v3-types" exited with 255.

Have tried clear cache and reinstall node_modules,but not working.

Could anybody help me out? Thanks a lot !

• I'm submitting a ...
  [ ] bug report
  [*] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary

This function...

https://github.com/Uniswap/smart-order-router/blob/main/src/routers/alpha-router/functions/calculate-ratio-amount-in.ts#L4

.. is highly useful outside the context of the Alpha Router, but it's not exported from:

https://github.com/Uniswap/smart-order-router/blob/main/src/routers/alpha-router/index.ts

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

• I'm submitting a ...
  [*] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Consider a "swap and add liquidity" transaction using the alpha router where the account has some WETH, some ETH for gas, and no USDC. I want to add liquidity to the WETH/USDC pool, for which I need to first swap about half my WETH to USDC (because my range happens to straddle the current price in the pool pretty evenly).

Calling AlphaRouter.routeToRatio() and passing in a token1Balance of zero USDC will result in this line in the stack...

... throwing an error 'Could not parse fraction'. Multiplying a Fraction by a CurrencyAmount (both from sdk-core) that is zero throws the error.

My stack trace is:

/home/e/r/dro/smart-order-router/node_modules/@uniswap/sdk-core/src/entities/fractions/fraction.ts:38
    throw new Error('Could not parse fraction')
          ^
Error: Could not parse fraction
    at Function.tryParseFraction (/home/e/r/dro/smart-order-router/node_modules/@uniswap/sdk-core/src/entities/fractions/fraction.ts:38:11)
    at Fraction.multiply (/home/e/r/dro/smart-order-router/node_modules/@uniswap/sdk-core/src/entities/fractions/fraction.ts:108:34)
    at Object.calculateRatioAmountIn (/home/e/r/dro/smart-order-router/src/routers/alpha-router/functions/calculate-ratio-amount-in.ts:18:60)
    at AlphaRouter.routeToRatio (/home/e/r/dro/smart-order-router/src/routers/alpha-router/alpha-router.ts:613:26)
    at DRO.<anonymous> (/home/e/r/dro/dro/src/dro.ts:700:70)
    at step (/home/e/r/dro/dro/src/dro.ts:33:23)
    at Object.next (/home/e/r/dro/dro/src/dro.ts:14:53)
    at fulfilled (/home/e/r/dro/dro/src/dro.ts:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

I'd expect this to be quite a common starting state for the account - some of one asset and none of the other in the pool. The SDK docs at https://docs.uniswap.org/sdk/guides/liquidity/swap-and-add use an example with some USDC but no WETH. Nevertheless, could it be that there are no tests that cover this scenario?

• I'm submitting a ...
  [*] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary

Does the smart-order-router repo use a different definition of the Pool class to the v3-sdk repo? I don't understand why I'm getting this error in the IDE:

Argument of type 'import("/home/e/r/dro/dro/node_modules/@uniswap/v3-sdk/dist/entities/position").Position' is not assignable to parameter of type 'import("/home/e/r/dro/dro/node_modules/@uniswap/smart-order-router/node_modules/@uniswap/v3-sdk/dist/entities/position").Position'.
  Types of property 'pool' are incompatible.
    Type 'import("/home/e/r/dro/dro/node_modules/@uniswap/v3-sdk/dist/entities/pool").Pool' is not assignable to type 'import("/home/e/r/dro/dro/node_modules/@uniswap/smart-order-router/node_modules/@uniswap/v3-sdk/dist/entities/pool").Pool'.
      Types have separate declarations of a private property '_token0Price'.ts(2345)

Here's my code:

    ...
    import { CurrencyAmount, Percent, BigintIsh, TradeType, Currency, Fraction } from "@uniswap/sdk-core"
    import { rangeOrderPoolContract, swapPoolContract, quoterContract, positionManagerContract, usdcToken, wethToken, rangeOrderPoolTick, rangeOrderPoolPriceUsdc, rangeOrderPoolPriceUsdcAsBigNumber, rangeOrderPoolTickSpacing, extractTokenId, positionByTokenId, positionWebUrl, tokenOrderIsWethFirst, DEADLINE_SECONDS, VALUE_ZERO_ETHER } from './uniswap'
    import { AlphaRouter } from '@uniswap/smart-order-router'

    async swapAndAddLiquidity() {
      // The order of the tokens in the pool varies from chain to chain, annoyingly.
      // Ethereum mainnet: USDC is first
      // Arbitrum mainnet: WETH is first
      let token0Balance
      let token1Balance

      // The wallet gives us BigNumbers for balances, but Uniswap's CurrencyAmount takes a
      // BigintIsh, which is a JSBI, string or number.
      if (this.wethFirst) {
        token0Balance = CurrencyAmount.fromRawAmount(wethToken, await (await wallet.weth()).toString())
        token1Balance = CurrencyAmount.fromRawAmount(usdcToken, await (await wallet.usdc()).toString())
      }
      else {
        token0Balance = CurrencyAmount.fromRawAmount(usdcToken, await (await wallet.usdc()).toString())
        token1Balance = CurrencyAmount.fromRawAmount(wethToken, await (await wallet.weth()).toString())
      }

      const slot = await rangeOrderPoolContract.slot0()
      const liquidity = await rangeOrderPoolContract.liquidity()

      // A position instance requires a Pool instance.
      let rangeOrderPool: Pool

      if (CHAIN_CONFIG.isTestnet) {
        rangeOrderPool = new Pool(
          usdcToken,
          wethToken,
          FeeAmount.MEDIUM, // Fee: 0.30%
          slot[0].toString(), // SqrtRatioX96
          liquidity.toString(), // Liquidity
          slot[1], // Tick
          // ticks
        )

        // Rather than require minTick and maxTick to be valid, replace them with valid values on
        // testnets. These were observed on a manually created position, therefore they're valid.
        this.minTick = 191580
        this.maxTick = 195840
      }
      else {
        rangeOrderPool = new Pool(
          usdcToken,
          wethToken,
          slot[5], // Fee: 0.30%
          slot[0].toString(), // SqrtRatioX96
          liquidity.toString(), // Liquidity
          slot[1] // Tick
        )
      }

      const p = new Position({
        pool: rangeOrderPool,
        tickLower: this.minTick,
        tickUpper: this.maxTick,
        liquidity: 1
      })

      const router = new AlphaRouter({ chainId: CHAIN_CONFIG.chainId, provider: CHAIN_CONFIG.provider()})

      const routeToRatioResponse = await router.routeToRatio(
        token0Balance,
        token1Balance,
        p, // <-- IDE complains here
        // swapAndAddConfig
        {
          ratioErrorTolerance: new Fraction(1, 100),
          maxIterations: 6,
        },
        // swapAndAddOptions
        {
           swapConfig: {
             recipient: wallet.address,
             slippage: new Percent(5, 100),
             deadline: 100
           },
           addLiquidityOptions: {
             recipient: wallet.address,
           }
         }
      )
    }

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Better handle outages with Infura by falling back to another node provider.

ethers FallbackProvider is not suitable for this, see: ethers-io/ethers.js#1376

Bunyan references window which is not available in webworker. Users can disable logging, but we should provide an alternative way to produce logs in a webworker.

• I'm submitting a ...
  [x] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary
  Upon trying to calculate a route to swap WETH to Holdenomics or Para Token, we have found that in the routers attempts to find a route, it fails to validate the SHINJA contract during route calculation and fails to return a route.

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
  I've attached a debug trace of the swap with holdenomics - the same occurs on Para.
  debug.txt

Define error tolerance for ratio post-swap.
If post-swap ratio is not within error tolerance, retry search with market rate from first search (which likely didn't match up with expectations)
Alternatively, the swap may have moved sqrtPrice of the target pool, which in turn could push the post-swap ratio outside our error tolerance.

ex:
https://localhost:3000/api/quote?protocols=v2%2Cv3&tokenInAddress=0x0d500B1d8E8eF31E21C99d1Db9A6444d3ADf1270&tokenInChainId=137&tokenOutAddress=0xD6DF932A45C0f255f85145f286eA0b292B21C90B&tokenOutChainId=137&amount=10000000000000000000000&type=exactIn

• I'm submitting a ...
  [ x] question about how to use this project

• Summary

Hey can you update your example from your official docs? https://docs.uniswap.org/sdk/guides/auto-router. You are using JSBI.BigInt in the example, but you aren't importing JSBI. What JSBI is this? If I install the one from npm, typescript compiler doesn't like it.

• I'm submitting a ...
  [ ] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [X ] question about how to use this project

• Summary
  I am trying to use the routeToRatio() function in AlphaRouter and I am following the steps given in the SDK guide. I receive this error when trying WETH and USDC pool on mainnet..

""if (token1Balance.currency.wrapped.sortsBefore(token0Balance.currency.wrapped)) {
^
TypeError: Cannot read properties of undefined (reading 'currency')
at AlphaRouter.routeToRatio (/Users/adrian/Documents/ARC/node_modules/@uniswap/smart-order-router/build/main/src/routers/alpha-router/alpha-router.js:148:27)""

To get the token1Balance/token0Balance I am using CurrencyAmount.fromRawAmount() and when I print the Token object returned by this function I see there is no ".wrapped" property, similar to what the error says. Also, when I print token1Balance.currency.wrapped, I receive the Token object, NOT undefined like the error would suggest. I am not sure why I would receive a valid value on my local machine but not once the token1Balance variable is sent to the SDK. I also have tried using parseAmount() as used in the alphaRouter test files but I get the same errors. I have run out of ideas of parameters to change or functions to try, any guidance on this problem would be greatly appreciated.

Here is my code:

const slot0 = await ETH_USDC_MAIN_30.methods.slot0().call();
const feeTier = await ETH_USDC_MAIN_30.methods.fee().call();

const liquidity = await ETH_USDC_MAIN_30.methods.liquidity().call();

const token0 = await ETH_USDC_MAIN_30.methods.token0().call();
const token1 = await ETH_USDC_MAIN_30.methods.token1().call();

let TokenA = new Token(1, token0, 6 , USDC);

console.log("Token A ", TokenA.wrapped);

const TokenB = new Token(1, WETH_Address_Main, 18, "WETH", "Wrapped Ether");
console.log("Token B ", TokenB.wrapped);

const token0Balance = CurrencyAmount.fromRawAmount(TokenA, "1000000000000000000");
// const token0Balance = parseAmount("1000000000000000000", WETH_ethers);
console.log("TOken 0 balance ", token0Balance);

const token1Balance = CurrencyAmount.fromRawAmount(TokenB, "1000000000000000000000");
// const token1Balance = parseAmount("20", TokenB);
console.log("TOken 1 balance ", token1Balance);

const routeToRatioResponse = await router.routeToRatio({
token0Balance: token0Balance,
token1Balance: token1Balance,
position: await new Position({
pool: await new Pool(
TokenA,
TokenB,
Number(feeTier),
slot0.sqrtPriceX96.toString(),
liquidity,
Number(slot0.tick),

  ),
  tickLower: Number("193380"),
  tickUpper: Number("203160"),
  liquidity: 1, //leave as 1
 }),

all done

Would it be possible to get a supgraph on

https://cloudflare-ipfs.com/ipns/api.uniswap.org/v1/pools/v3/

for arbitrum-rinkeby?

• I'm submitting a ...
  [*] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
  This line:

https://github.com/Uniswap/smart-order-router/blob/main/src/routers/alpha-router/functions/calculate-ratio-amount-in.ts#L12

will throw an Error when the optimalRatio passed in is zero, ie. a Fraction with a denominator of 1 but no numerator.

Such a Fraction is easily produced by AlphaRouter.routeToRatio() here:

https://github.com/Uniswap/smart-order-router/blob/main/src/routers/alpha-router/alpha-router.ts#L559

Here's the stack trace from my project code:

/home/e/r/dro/smart-order-router/node_modules/@uniswap/sdk-core/src/entities/fractions/fraction.ts:38
    throw new Error('Could not parse fraction')
          ^
Error: Could not parse fraction
    at Function.tryParseFraction (/home/e/r/dro/smart-order-router/node_modules/@uniswap/sdk-core/src/entities/fractions/fraction.ts:38:11)
    at Fraction.multiply (/home/e/r/dro/smart-order-router/node_modules/@uniswap/sdk-core/src/entities/fractions/fraction.ts:108:34)
    at Object.calculateRatioAmountIn (/home/e/r/dro/smart-order-router/src/routers/alpha-router/functions/calculate-ratio-amount-in.ts:12:28)
    at AlphaRouter.routeToRatio (/home/e/r/dro/smart-order-router/src/routers/alpha-router/alpha-router.ts:606:26)
    at DRO.<anonymous> (/home/e/r/dro/dro/src/dro.ts:670:70)
    at step (/home/e/r/dro/dro/src/dro.ts:33:23)
    at Object.next (/home/e/r/dro/dro/src/dro.ts:14:53)
    at fulfilled (/home/e/r/dro/dro/src/dro.ts:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

In case it matters, the version of JSBI in my codebase is:

"jsbi": "^3.2.4",

whereas in sdk-core v3.0.1 it's:

"jsbi": "^3.1.4",

Please help me

• when i 「npm run test」 it have a bug --> Cannot find module '../types/v3'

Thank you very much

• I'm submitting a ...
  [ ] question about how to use this project

• Summary
  I am going to swap some FRAX with USDC. When I use the EXACT_INPUT mode, the route returns is null. But If I choose the EXACT_OUTPUT mode, the route is correct. I can't figure out what's going on with these two modes. The code is as follows.

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

const FRAX = new Token(
	ChainId.POLYGON,
	'0x45c32fA6DF82ead1e2EF74d17b76547EDdFaFF89',
	18,
	'FRAX',
	'Frax'
);

const USDC = new Token(
	ChainId.POLYGON,
	'0x2791Bca1f2de4661ED88A30C99A7a9449Aa84174',
	6,
	'USDC',
	'USD//C'
);

1. When swap with EXACT_INPUT

        const usdcAmount = CurrencyAmount.fromRawAmount(USDC, JSBI.BigInt(rawAmount));
	const route = await router.route(
		usdcAmount,
		FRAX,
		TradeType.EXACT_INPUT,
		{
			recipient: signer.address,
			slippageTolerance: new Percent(5, 100),
			deadline: Date.now() + 1800
		}
	);

Then I got null route.
2. swap with EXACT_OUTPUT

        const fraxAmount = CurrencyAmount.fromRawAmount(FRAX, JSBI.BigInt(rawAmount));
	const route = await router.route(
		fraxAmount,
		USDC,
		TradeType.EXACT_OUTPUT,
		{
			recipient: signer.address,
			slippageTolerance: new Percent(5, 100),
			deadline: Date.now() + 1800
		}
	);

the route is ok.

• I'm submitting a ...
  [ ] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

• I'm submitting a ...
  [*] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary

For my test position (a symmetrical, in-range position in the WETH/USDC pool with the 0.3% fee), AlphaRouter.calculateOptimalRatio() returns a ratio that is out by about 2%. I've provided a failing test for this in #77.

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)