Git Product home page Git Product logo

k-redux-router's People

Contributors

bpetetot avatar delphinemillet avatar fabienjuif avatar greenkeeper[bot] avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

bpetetot

k-redux-router's Issues

remove middleware

Maybe we can do all we want into a reducer.

This is not the Redux pattern, but whatever

An in-range update of eslint-plugin-import is breaking the build 🚨

The devDependency eslint-plugin-import was updated from 2.18.2 to 2.19.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Commits

The new version differs by 46 commits.

  • 9b76635 Bump to v2.19.0
  • 47a232e [resolvers/webpack] v0.12.0
  • 26ad476 [resolvers/webpack] [deps] update debug, enhanced-resolve, has, interpret, lodash, resolve, semver
  • 3f0e8f3 [resolvers/node] [Deps] update resolve
  • 7190c3e bump utils to v2.5.0
  • a60e5c6 [New] no-commonjs: add allowConditionalRequire option
  • 414c923 [New] enable passing cwd as an option to eslint-import-resolver-webpack
  • 8224e51 [New] order/no-extraneous-dependencies: Alphabetize imports within groups
  • f12ae59 [New] no-duplicates: add a considerQueryString option to handle false positives when using some webpack loaders.
  • 2d3d045 [fix] importType: Accept '@example' as internal
  • 0426f16 [New] order: add pathGroups option to add support to order by paths
  • 99b3fbf [Fix] no-extraneous-dependencies: Add support for export from
  • 21bf8c6 [Fix] no-cycle: should not warn for Flow imports
  • 0cd5e43 [Fix] no-unused-modules: fix crash due to export *
  • 05085bb [flow] no-unused-modules: add flow type support

There are 46 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

need to know parent

So we can bind component like we do in hoc-little-router (absolute or not)

not found

  • We should param notFound wherever we want on route definitions
  • We can assign a code for the notFound, references the screen to print

Exemple

  '/': {
    code: 'main',
    '/login': { code: 'login' },
    '/profile': { code: 'profile' },
    '/search': { code: 'search' },
    '/projects': {
      code: 'projects',
      routeNotFound: 'projectNotFound',
      '/404': {
        code: 'projectNotFound',
      },
      '/:id': {
        code: 'project',
        '/setup': { code: 'setup' },
        '/summary': { code: 'summary' },
        '/measures': { code: 'measures' },
        '/symptoms': { code: 'symptoms' },
        '/diagnostics': { code: 'diagnostics' },
      },
    },
  },
}

An in-range update of jest2 is breaking the build 🚨

There have been updates to the jest2 monorepo:

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the jest2 group definition.

jest2 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of rollup is breaking the build 🚨

The devDependency rollup was updated from 1.14.2 to 1.14.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Release Notes for v1.14.3

2019-06-06

Bug Fixes

  • Generate correct external imports when importing from a directory that would be above the root of the current working directory (#2902)

Pull Requests

Commits

The new version differs by 4 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of react is breaking the build 🚨

There have been updates to the react monorepo:

    • The devDependency react was updated from 16.6.1 to 16.6.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the react group definition.

react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of babel7 is breaking the build 🚨

There have been updates to the babel7 monorepo:

    • The devDependency @babel/cli was updated from 7.6.3 to 7.6.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of lerna is breaking the build 🚨

The devDependency lerna was updated from 3.16.4 to 3.16.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lerna is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Release Notes for v3.16.5

3.16.5 (2019-10-07)

Bug Fixes

  • bootstrap: Run lifecycle scripts in topological queue instead of batches (#2224) (d8d33f7)
  • child-process: Use Set to manage book-keeping instead of mutable integer (5dbea32)
Commits

The new version differs by 13 commits.

  • f057409 chore(release): v3.16.5
  • da7d77d chore(travis): Condense Windows matrix
  • deb25af test(integration): Assert on stable result of git status --porcelain
  • 6618da4 chore(windows): Skip eslint in windows tests
  • 98eb219 chore(windows): Make git subcommands work again
  • dea9745 chore(windows): Debugging git-receive-pack errors (sigh)
  • 5dbea32 fix(child-process): Use Set to manage book-keeping instead of mutable integer
  • 892ebc2 chore(travis): Let prettier have its way with indentation
  • d8d33f7 fix(bootstrap): Run lifecycle scripts in topological queue instead of batches (#2224)
  • afb0414 docs(version): Correct global --conventional-prerelease example
  • 85afdba docs: add pull request section to CONTRIBUTING.md (#2202)
  • 2833d82 docs(version): improve Prerelease section of readme (#2263)
  • 06b7a96 docs: Fixed typo and remove trailing space (#2273)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint is breaking the build 🚨

The devDependency eslint was updated from 5.15.1 to 5.15.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Release Notes for v5.15.2
  • 29dbca7 Fix: implicit-arrow-linebreak adds extra characters (fixes #11268) (#11407) (Mark de Dios)
  • 5d2083f Upgrade: [email protected] (#11513) (Teddy Katz)
  • a5dae7c Fix: Empty glob pattern incorrectly expands to "/**" (#11476) (Ben Chauvette)
  • 448e8da Chore: improve crash reporting (fixes #11304) (#11463) (Alex Zherdev)
  • 0f56dc6 Chore: make config validator params more consistent (#11435) (薛定谔的猫)
  • d6c1122 Docs: Add working groups to maintainer guide (#11400) (Nicholas C. Zakas)
  • 5fdb4d3 Build: compile deps to ES5 when generating browser file (fixes #11504) (#11505) (Teddy Katz)
  • 06fa165 Build: update CI testing configuration (#11500) (Reece Dunham)
  • 956e883 Docs: Fix example in no-restricted-modules docs (#11454) (Paul O’Shannessy)
  • 2c7431d Docs: fix json schema example dead link (#11498) (kazuya kawaguchi)
  • e7266c2 Docs: Fix invalid JSON in "Specifying Parser Options" (#11492) (Mihira Jayasekera)
  • 6693161 Sponsors: Sync README with website (ESLint Jenkins)
  • 62fee4a Chore: eslint-config-eslint enable comma-dangle functions: "never" (#11434) (薛定谔的猫)
  • 34a5382 Build: copy bundled espree to website directory (#11478) (Pig Fang)
  • f078f9a Chore: use "file:" dependencies for internal rules/config (#11465) (Teddy Katz)
  • 0756128 Docs: Add visualstudio to formatter list (#11480) (Patrick Eriksson)
  • 44de9d7 Docs: Fix typo in func-name-matching rule docs (#11484) (Iulian Onofrei)
Commits

The new version differs by 19 commits.

  • f354770 5.15.2
  • cada7a1 Build: changelog update for 5.15.2
  • 29dbca7 Fix: implicit-arrow-linebreak adds extra characters (fixes #11268) (#11407)
  • 5d2083f Upgrade: [email protected] (#11513)
  • a5dae7c Fix: Empty glob pattern incorrectly expands to "/**" (#11476)
  • 448e8da Chore: improve crash reporting (fixes #11304) (#11463)
  • 0f56dc6 Chore: make config validator params more consistent (#11435)
  • d6c1122 Docs: Add working groups to maintainer guide (#11400)
  • 5fdb4d3 Build: compile deps to ES5 when generating browser file (fixes #11504) (#11505)
  • 06fa165 Build: update CI testing configuration (#11500)
  • 956e883 Docs: Fix example in no-restricted-modules docs (#11454)
  • 2c7431d Docs: fix json schema example dead link (#11498)
  • e7266c2 Docs: Fix invalid JSON in "Specifying Parser Options" (#11492)
  • 6693161 Sponsors: Sync README with website
  • 62fee4a Chore: eslint-config-eslint enable comma-dangle functions: "never" (#11434)

There are 19 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of react is breaking the build 🚨

There have been updates to the react monorepo:

    • The devDependency react was updated from 16.12.0 to 16.13.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the react group definition.

react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Release Notes for 16.13.0 (February 26, 2020)

React

  • Warn when a string ref is used in a manner that's not amenable to a future codemod (@lunaruan in #17864)
  • Deprecate React.createFactory() (@trueadm in #17878)

React DOM

Concurrent Mode (Experimental)

Artifacts

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

middleware

I need the middleware to dispatch actions:

  • When URL changes outside redux
window.onpopstate = function(event) {
  alert("location: " + document.location + ", state: " + JSON.stringify(event.state));
};
  • I want users to know there is a change in store, like LOCATION_CHANGED (from redux-little-router)

An in-range update of jest2 is breaking the build 🚨

There have been updates to the jest2 monorepo:

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the jest2 group definition.

jest2 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint-plugin-react is breaking the build 🚨

The devDependency eslint-plugin-react was updated from 7.14.3 to 7.15.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Commits

The new version differs by 30 commits.

  • b45219a Update CHANGELOG and bump version
  • a01198f [Dev Deps] update eslint-config-airbnb-base, eslint-plugin-import, sinon, typescript
  • ab77870 [Deps] update jsx-ast-utils, resolve
  • 32e27b7 [Fix] jsx-indent: Fix false positive when a jsx element is the last statement within a do expression (with tests)
  • 628a4a0 [fix] jsx-curly-brace-presence: fix jsx tags in braces
  • 3124ce0 [Docs] no-access-state-in-setstate: update grammar
  • 4a05fa2 [fix] display-name: Fix false positives
  • c6521ad Change istanbul output directory to ./coverage (default)
  • 5970651 [new] jsx-handler-name: allow false to disable eventHandlerPrefix/eventHandlerPropPrefix
  • 489ced3 [refactor] jsx-curly-braces-presence, jsx-one-expression-per-line, no-danger-with-children: add isWhiteSpaces to lib/util/jsx
  • 9b2db61 [fix] jsx-curly-brace-presence: report unnecessary curly braces with children on next line
  • 781bfff [new] sort-comp: add static-variables grouping
  • 7ccff10 [New] add jsx-no-useless-fragment rule
  • 66725bc [Fix] no-unused-prop-types: false positive with callback
  • 3c72a49 [eslint] disable some options and manually fix valid-jsdoc

There are 30 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of babel-eslint is breaking the build 🚨

The devDependency babel-eslint was updated from 10.0.3 to 10.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

babel-eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Commits

The new version differs by 2 commits.

  • 4bd049e 10.1.0
  • 2c754a8 Update Babel to ^7.7.0 and enable Flow enums parsing (#812)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of lerna is breaking the build 🚨

The devDependency lerna was updated from 3.4.3 to 3.5.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lerna is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Commits

The new version differs by 48 commits.

  • 1c142db chore(release): publish v3.5.0
  • fbf9629 refactor(version): Tweak error code when remote branch does not exist
  • b199f32 refactor(publish): Allow --git-reset to be configured from lerna.json
  • 3b98973 refactor(publish): Gather current tags filtered by --list glob
  • 1aa1712 chore: bump eslint-plugin-jest
  • f4edc76 docs: Remove broken badges
  • bc56839 chore: sync protocol of public registry
  • 1a78f1a chore: reset lockfile
  • 3cb7465 fix(publish): Ignore non-release tags when detecting from-git (#1782)
  • 7ee05d7 feat(version): Add --include-merged-tags option (#1712)
  • e2c0342 docs: Fix link to --git-remote option (#1796) [ci skip]
  • eae5619 feat(publish): Add option --no-git-reset to leave unstaged changes in working tree (#1791)
  • b69a728 feat(run): Log package name and timing in runScriptInPackageCapturing (#1781)
  • 9d36654 feat(import) Add --dest option to explicitly specify import destination (#1772)
  • cd34b48 fix(version): Add friendly error message when remote branch doesn't exist (#1741)

There are 48 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

route not found not handled properly

versions:

"@k-redux-router/core": "^0.4.6",
"@k-redux-router/react-k-ramel": "^0.4.6",

when heading to an undefined route, the app just crash, with this error:

Uncaught TypeError: Cannot read property 'code' of undefined
    at o.i.toShow (index.es.js:1)
    at o.value (index.es.js:1)
    at callComponentWillMount (react-dom.development.js:11829)
    at mountClassInstance (react-dom.development.js:11917)
    at updateClassComponent (react-dom.development.js:13492)
    at beginWork (react-dom.development.js:14090)
    at performUnitOfWork (react-dom.development.js:16416)
    at workLoop (react-dom.development.js:16454)
    at HTMLUnknownElement.callCallback (react-dom.development.js:145)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:195)
    at invokeGuardedCallback (react-dom.development.js:248)
    at replayUnitOfWork (react-dom.development.js:15745)
    at renderRoot (react-dom.development.js:16548)
    at performWorkOnRoot (react-dom.development.js:17387)
    at performWork (react-dom.development.js:17295)
    at performSyncWork (react-dom.development.js:17267)
    at requestWork (react-dom.development.js:17155)
    at scheduleWork (react-dom.development.js:16949)
    at scheduleRootUpdate (react-dom.development.js:17637)
    at updateContainerAtExpirationTime (react-dom.development.js:17664)
    at updateContainer (react-dom.development.js:17691)
    at ReactRoot../node_modules/react-dom/cjs/react-dom.development.js.ReactRoot.render (react-dom.development.js:17957)
    at react-dom.development.js:18097
    at unbatchedUpdates (react-dom.development.js:17518)
    at legacyRenderSubtreeIntoContainer (react-dom.development.js:18093)
    at Object.render (react-dom.development.js:18152)
    at Object../src/index.js (index.js:7)
    at __webpack_require__ (bootstrap faccf88ca4ced995451f:678)
    at fn (bootstrap faccf88ca4ced995451f:88)
    at Object.0 (akf.woff?4i0mvx:1)
    at __webpack_require__ (bootstrap faccf88ca4ced995451f:678)
    at ./node_modules/@babel/runtime/helpers/arrayWithoutHoles.js.module.exports (bootstrap faccf88ca4ced995451f:724)
    at bootstrap faccf88ca4ced995451f:724

router definition used:

import { router } from '@k-redux-router/react-k-ramel'

const routes = {
  '/': {
    code: 'HOME',
    '/todos': {
      code: 'TODOS',
      '/add': {
        code: 'TODO_ADD',
      },
    },
  },
}

export default router({
  routes,
  state: 'ui.router',
  getState: state => state.ui.router,
})

is there some configuration missing?
it would be very nice to fire an action when a route is not found, so that we could add some reaction to redirect to a dedicated 404 page :)

first notes

Largely inspired from redux-little-router

But without the react part in it
And simplified

API

Route definition

Same as redux-little-router

Actions

Same as redux-little-router.

  • push()
  • replace()

Moins prio

  • go()
  • goback()

State / Reducer

Same logic as redux-little-router.
Plus:

  • We use k-redux-factory to store state.
  • We store more information
  • Use code as the route key
  • Store the href of a route
  • Store the compiledHref of a route, this is the compiled Regexp version

Selectors

  • getResultParam -> dans les routes en récursif
  • getPathParam

Notes

  • Copier tous les parametres de route dans les enfants avec possibilité de surcharger
    Exemple:
const routes = {
  '/': {
    code: 'main',
    '/login': { code: 'login' },
    '/profile': { code: 'profile' },
    '/search': { code: 'search' },
    '/projects': {
      code: 'projects',
      public: true,
      '/:id': {
        code: 'project',
        '/setup': { code: 'setup' },
        '/summary': { code: 'summary', public: undefined },
        '/measures': { code: 'measures', public: false },
        '/symptoms': { code: 'symptoms' },
        '/diagnostics': { code: 'diagnostics' },
      },
    },
  },
}

  • Va mettre public: true dans toutes les routes enfant de projects
    Sauf dans /measures et dans /summary

  • Pouvoir définir un 404 pour chaque enfant
    Exemple:

const routes = {
  '/': {
    code: 'main',
    '/login': { code: 'login' },
    '/profile': { code: 'profile' },
    '/search': { code: 'search' },
    '/projects': {
      code: 'projects',
      routeNotFound: 'projectNotFound',
      '/404': {
        code: 'projectNotFound',
      },
      '/:id': {
        code: 'project',
        '/setup': { code: 'setup' },
        '/summary': { code: 'summary' },
        '/measures': { code: 'measures' },
        '/symptoms': { code: 'symptoms' },
        '/diagnostics': { code: 'diagnostics' },
      },
    },
  },
}
  • Bien faire les appels historyAPI avant de mettre à jour le store
    • Par contre bien penser à controler qu'on tombe pas dans un not found

An in-range update of jest2 is breaking the build 🚨

There have been updates to the jest2 monorepo:

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the jest2 group definition.

jest2 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint-plugin-import is breaking the build 🚨

The devDependency eslint-plugin-import was updated from 2.16.0 to 2.17.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Commits

The new version differs by 61 commits.

  • 0499050 bump to v2.17.0
  • f479635 [webpack] v0.11.1
  • 8a4226d Merge pull request #1320 from bradzacher/export-ts-namespaces
  • 988e12b fix(export): Support typescript namespaces
  • 70c3679 [docs] make rule names consistent
  • 6ab25ea [Tests] skip a TS test in eslint < 4
  • 405900e [Tests] fix tests from #1319
  • 2098797 [fix] export: false positives for typescript type + value export
  • 70a59fe [fix] Fix overwriting of dynamic import() CallExpression
  • e4850df [ExportMap] fix condition for checking if block comment
  • 918567d [fix] namespace: add check for null ExportMap
  • 2d21c4c Merge pull request #1297 from echenley/ech/fix-isBuiltIn-local-aliases
  • 0ff1c83 [dev deps] lock typescript to ~, since it doesn’t follow semver
  • 40bf40a [*] [deps] update resolve
  • 28dd614 Merge pull request #1304 from bradennapier/feature/typescript-export-type

There are 61 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

rewrite link

currently this is the version binded to redux-little-router

An in-range update of coveralls is breaking the build 🚨

The devDependency coveralls was updated from 3.0.6 to 3.0.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

coveralls is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: Your tests failed on CircleCI (Details).
Commits

The new version differs by 1 commits.

  • 2ed185c added support for GitLab Merge Request IID

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Tous les attributs du composant Link passent en path params.

On observe sur ce code (issu du fichier link.container.js) que tous les attributs du composant Link qui sont différents des attributs onClick, query et code, sont poussés dans l'url comme path params :

const mapDispatch = (
  dispatch,
  {
    onClick,
    code,
    query,
    ...params
  },
) => ({
  onClick: (e) => {
    // parent onClick callback
    if (onClick) onClick(e)

    // sometimes we want to ignore click
    if (shouldIgnoreClick(e)) return

    // dispatch the push
    dispatch(actions.push(code, params, query))

    // prevent default behaviour
    e.preventDefault()
  },
})

C'est plutôt rigide comme fonctionnement car dans beaucoup de cas, il y a des attributs que l'on désire mais qui n'ont rien à voir avec les path params.

Solution potentielle : Tout comme pour les query params, spécifier un attribut pathParams comme ceci : pathParams={ { id: '1' } } par exemple et qui est transmis au container en lieu et place de ...params.
De cette manière on spécifie bien dans l'instance de notre Link, ce qui doit et ce qui ne doit pas être considéré comme path params.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.