unicorn-fail / dreditor Goto Github PK

On issue node edit form.

Screenshot from D6 d.o:

I'm getting "Dreditor got improved! Visit the project page to update?" alerts once in a while when using the Chrome extension. Since the Chrome extension auto-updates, this code should be removed. I've confirmed that I don't have the userscript still loading, this code is in the extension folder.

If we are keeping this code for the userscript version, it may need a refactor to point to GitHub commit log.

My patch review on this issue never pastes: https://drupal.org/node/2059845

I've tried updating Dreditor (and deleting it and re-installing). It seems to be only this issue -- just tried another in the same project and that works.

I can't find the 'Create commit message' button anywhere. I'm thinking it should probably be on the comment form rather than the 'edit issue' form.

Screenshot from D6 d.o:

Link:
https://git7site.devdrupal.org/node/1304470

Before enabling Dreditor:

After enabling Dreditor:

It would be nice right after you upload the patch but before you save the issue, if a review tab appeared that allowed you to give your patch a last once-over before submitting it.

I wonder if dreditor could do something like https://drupal.org/node/2013222#comment-7511433

And for any needs tags on an issue, have a section (near the summary?) that shows what the issue needs and links to the contributor task instructions to do them.

I guess dreditor would have to maintain a list of tags and the corresponding links to the contributor task documents.

why?

1. as a demo, to show d.o infrastructure people or motivate people to help those folks to implement it
2. might be useful on it's own as part of dreditor (but really the idea is to help new contributors and new, or potential new, contributors may not have dreditor)

mock up from @joelpittet

http://screencast.com/t/oIiYtqaOHA

If I want words 5-8 in a line, I click at the beginning of the 5th word, then drag to the end of the 8th, then let go.

I expect to have those words hidden.
Instead I have "marked" that line and nothing is selected.
then I have to do it again.
this is annoying.

Is it solvable?

I think we probably need a separate issue to discuss how much we want to change the patch styling, I see we are now doing quite a bit to change how patches are displayed - commit b3e9301 had quite a few changes beyond fixing #7 :)

This issue is about adding back relevant information, like this example from an auto-generated comment created after hiding a patch from the issue summary:

Without Dreditor:

With Dreditor:

With Dreditor it looks like I am adding the file. To be fair in both cases it looks a bit like I am adding the file, but at least the vanilla version says 'hidden'.

from: https://drupal.org/node/2068157

Updated: Comment #0

Related to [#2068151].

Problem/Motivation

Sometimes, interdiffs are made with filename interdiff.txt
This is hiding information about what it is the diff between,
and d.o has to calculate the number of other files called interdiff.txt and change the name to something like: interdiff_8682.txt

Proposed resolution

Make an interdiff filename suggestion button, similar to [#1294662]

Remaining tasks

• Link to recommended interdiff
• discuss what pattern to use
• make patch

User interface changes

Added button

API changes

No.

Related Issues

• [#1294662]
• [#2068151]

I have the following issue title:

Adicionar "configure" link na lista de módulos

And the generated commit message was:

git commit -m "Issue #2087865 by halth: Added Adicionar 'configure" link na lista de módulos."

As you can see, there's a wrong quote inside the commit message which is breaking the command.

For example if you press the create commit message button on https://drupal.org/node/2036239 the message is "Issue #2036239 by kevee: Color contrast on toolbar sub-menu links." but it should be "Issue #2036239 by kevee, mgifford: Color contrast on toolbar sub-menu links."

I always have to copy-paste the link to a comment like https://drupal.org/node/2022535#comment-7903865 and have to manually convert it to [#2022535-4]. It would be nice if Dreditor could provide me a way to copy this pre-converted to use with the Drupal.org issue-linking filter.

So many times, there are anchors on doc d.o pages that I would like to copy the link (with anchor fragment) to give to someone for quick reference. There's currently no way to get those anchors (or know they exist) unless looking at the source code.

I propose we do something similar to how GH does it. When you hover over an element (hx, a) that has an id or name, show an anchor "link" next to it so you can copy the link.

It is heartbreaking to lose a dreditor review.

Autosave every minute, or every key stroke.

How? I do not know.

One of the things that bothers me is the pain staking process of copying and pasting issue links from issues searches like: https://drupal.org/project/issues/search/bootstrap?status%5B%5D=1&status%5B%5D=13&status%5B%5D=8&status%5B%5D=14&version%5B%5D=1840986&issue_tags_op=not&issue_tags=meta

I would like the ability to simply select the issues I want to create a list of issue numbers of (perhaps even sorting them with something like table drag does).

In dreditor/dreditor#43 the use of issue json was temporarily removed. I'm adding this issue to track the todo that was added.

Another issue now also depends on this. dreditor/dreditor#47

D.o issue that is blocking this: https://drupal.org/node/1710850

I'll see if I can figure this one out :)

https://drupal.org/node/1139088
Got this here and not only when pushing "Create commit message" button
Google Chrome 30.0.1599.69 on win32 XP
dreditor 1.1.7

Chrome 28

The "Create commit message" button can only be clicked when the mouse is in the lower 1/4th of the button.

"make sticky" does not behave this way.

https://drupal.org/node/2073499

from @cottser
"The idea would be to make it work similarly to the Insert module. So instead of appending to the end of the body, embed the image at the current cursor position if the cursor is in the body at the time of clicking 'Embed'."

I have also wished for this.

Steps to reproduce:

Type a comment number in the current issue (e.g. #3) into the comment field. No autocomplete label displays at the bottom of the screen and pressing tab doesn't do anything.

Spin-off from 754190 Auto-switch status to "need work" when pasting a patch review

The new patchname suggestion feature is very nice.

But it has one big flaw IMO: the patch name is "flag.miscellaneous.1658830-3.patch".

Personally, I really dislike patches that start with the module name. EVERYTHING in my module's folder already starts with the module name, so I can't use autocomplete when applying the patch!

Please consider changing this to something that starts with the issue number. (I use the format ISSUE-COMMENT.PROJECT.DESCRIPTION.patch.)

Another benefit of starting with the issue number is that all patches are listed together in a folder :)

I was on d.o (https) and got a popup message offering me to download the latest version of dreditor over at https://dreditor.org/. I clicked yes and was redirected to https://dreditor.org/ which doesn't work. (the http URL works but not the https). that was in FF.

I updated today to the latest version, and now patch review is totally broken.

When I click on the review button, I get a LH sidebar that says 'Diff outline' but other than that, the issue page is unchanged.

I am on the latest Firefox on OS X 10.6.

The 'create commit message' button doesn't account for all people who have worked on a patch. It seems to take only the name of the person who has created the issue.

examples:
https://drupal.org/node/2112705
https://drupal.org/node/2019055

On Drupal.org you now have to go to a seperate page to edit anything. Even the smallest thing. This workflow is modeled after implementation and not ease of use.

Dreditor should bring all this functionality back in line, just like it did with the [edit issue summary] button. This will save people like me, who only do small stuff like uploading an image once in a while, and changing status many countless hours moving back and forth.

Feel free to ping me to get a design.

• review a patch clicking the REVIEW button
• hide the patch clicking the HIDE button
• read on and forget about the hidden patch
• click REVIEW on another patch

This will not open the new patch but the previously hidden patch. This behavious is quite confusing. Clicking REVIEW on a patch should always open THAT patch.

Hi,

I was wondering if there has been any work done on the Drupal 7 dev sites for Drupal.org.

https://git7site.devdrupal.org/

Adding two include lines :
// @include ://devdrupal.org/
// @include ://.devdrupal.org/*

would do the trick to start testing... but the 2.x branch seems to lack these include lines. Any hint on how that works?

Compared dreditor on Firefox & Chrome to gitblame; dreditor numbering is one more.

related to dreditor/dreditor#43
"Insert issue summary template button missing on D7 d.o"

This is a problem caused by the d.o migration to D7, and since a picture is worth a thousand words, here it is:

https://www.evernote.com/shard/s268/sh/0e611c97-21bc-4d09-8f6a-b972762d6e90/b187adccba64ba4c8bcc56601f103647

Screenshot from D6 d.o:

from https://drupal.org/node/1991148

Identifying partial line code changes in traditional diffs can be tedious and error-prone. A fix for a typo in code docs or a variable name in a long expression may require reviewers to carefully read an entire line to make sure they haven't overlooked differences. To help with this, some diff tools offer word-level highlighting. git-diff has the --word-diff option[1], for example, and Github has a very nice dual-highlighting implementation[2]. Similar functionality in Dreditor would be super helpful.

[1]
[2]

When you want to comment on a bunch of lines, drag-n-drop selection has to start from the top to the bottom.

Clicking on the last line and dragging up to the first only selects the last line

(seen on 1.1.7, Chrome / Linux)

Add a clone URL on issue page for the project. To help people creating patches to get access to the code to create the patch against.

git clone --branch master http://git.drupal.org/project/node_export.git cd node_export

Even if this was just a link to git instructions
https://drupal.org/project/node_export/git-instructions

it's to help people making patches get access to the right branch to patch against

v 1.1.7 Chrome / Linux

On a issue like https://drupal.org/node/1497374 (200+ comments, many patches), dreditor adds like 7 / 8 seconds processing time after initial page load (that is, before JS behaviors / extensions like mouse gestures become available)

I could not find an existing open issue here, or on d.o for personalized settings.

Local storage for settings for various dreditor features. Ideas:
set of most used tags,
pattern for patch or interdiff naming,
other?

I recall there be more examples, but cannot think of them at the moment. Suggest some.

I installed NinjaKit and it is installed, but when I click the install button for Dreditor on dreditor.org it just loads the raw JS in the browser.

Safari 6.0.5 on OSX 10.8.4

Hi there,
I'm using Opera 12.16 on x86_64 Linux. I installed dreditor as a userscript and the indicator on dreditor.org also report "dreditor is installed!".

But when I go to issues on drupal.org, there seem to be no enhancements like in Firefox.

By adding these styles to the issue status card you can make it have a fixed position so that it is still present on the screen as you scroll.

[css]
.node-type-project-issue #aside {
width: 31.91489%;
margin-right: 0;
display: inline;
position: fixed;
left: 65.95745% /* same as #main */
}

Actual patch hunk:

@@ -276,7 +284,19 @@ public static function baseFieldDefinitions($entity_type) {
       'description' => t('The revision log message.'),
       'type' => 'string_field',
     );
+    $properties['changed'] = array(
+      'label' => t('Changed'),
+      'description' => t('The time that the custom block was last edited.'),
+      'type' => 'integer_field',
+    );
     return $properties;
   }

+  /**
+   * {@inheritdoc}
+   */
+  public function getChangedTime() {
+    return $this->get('changed')->value;
+  }
+
 }

Presented as:

Note how dreditor makes it look like there is no newline before the new getChangedTime() method.

See it for yourself right here: https://drupal.org/node/2074193#comment-7822281

This is a problem for downloading the patch to apply it:

From issue: https://drupal.org/node/2127487

Rather than coloring the type green/red, I think the background color alone and a dark gray type makes the diff more aesthetically pleasing to read.

Specifically, #dreditor #code .old and #dreditor #code .new could use color: #444

pencil mock up of editing tags on an issue.

Idea:
a) make it easier to tags when a needs.. task is done, or just remove irrelevant tags
by showing current tags on top, as button-like things with an x to remove them, or in a checkbox list, and unchecking them to remove the tags.
b) under the current tags, show a curated list of commonly used tags like: needs reroll, needs issue summary update, etc.

curated list to be maintained in a dreditor issue, based also on https://drupal.org/needs-tags

Why? because the autocomplete drop-down only lists 10 items, alphabetcally, and thus sometimes the one people should be adding is hidden.

Still allow, new tags to be added in the autocomplete for people who know what tags they want added.

dreditor/dreditor#32 save personalized most used.

Separate issues that can build on this later:

1. For needs tags that have a corresponding contributor task document, add a link to instructions on how to do the task to the end of the comment. This allows the author of the comment to remove the instructions if they do not want them in their comment.

2. Have user stored settings to allow them to customize their own list of common tags.

Related
"edit tags / update tags button" dreditor/dreditor#16
"Add checkbox list of tasks an issue needs that links to contributor task docs and adds the cooresponding needs tags" https://drupal.org/node/2013222

The feedback link on http://dreditor.org/ for irc://chat.freenode.net/dreditor should be irc://irc.freenode.net/dreditor (replace chat by irc)

See also https://drupal.org/irc for similar links

After the D7 upgrade this feature is broken.

I've started a feature branch to fix it: https://github.com/helmo/dreditor/compare/patchnamesuggestion-d7?expand=1

I had to disable the Drupal.dreditor.issue.getNewCommentNumber() functions as the previous comments are no longer shown on the edit page.

Before, we could resize the sidebar to help see longer filenames etc.

The sizing on the comment textarea also looks a bit off (it's right up against the edge of the sidebar) but perhaps that's a separate issue.