un-es / eslint-plugin-i Goto Github PK

I'm interested in perhaps using this fork, but I'm curious what real-world performance improvements you've seen compared with the upstream project. It would be great to know how much faster I could expect this fork to be.

https://www.npmjs.com/package/eslint-plugin-import/v/2.28.1

Would it be possible to release a final version ? The last one is a pre-release one

I think the rebase action is broken for a while. Can you please fix it?

after the update from version 2.27.5-1 to 2.27.5-2 i get the error:

Oops! Something went wrong! :(

ESLint: 8.43.0

Error: Failed to load plugin 'import' declared in '.eslintrc.cjs': Cannot find module 'resolve-pkg-maps'

@JounQin

eslint-plugin-i seems to be up of sync from upstream for months:

A manual rebase is required.

The object.groupby package can be replaced with this:

// This is a **non spec compliant** but works in practice replacement of `object.groupby` package.
const groupBy = (array, grouper) => array.reduce((acc, cur) => {
  const key = grouper(cur);
  (acc[key] = acc[key] || []).push(cur);
  return acc;
}, {});

And object.fromentries can be replaced with const { fromEntries } = Object;

I tried to install this using the instructions as given in the README, but I'm using yarn.

~/c/s/s/code ❯❯❯ yarn add  eslint-plugin-import@npm:eslint-plugin-i                                                                                        next ✱
➤ YN0000: ┌ Resolution step
➤ YN0016: │ eslint-plugin-import@npm:eslint-plugin-i: Registry failed to return tag "eslint-plugin-i"

I'll keep looking into a possible solution and report back here if I'm able to find one.

Hey there!

I thought I would follow the same path and create a fork of eslint-plugin-react, eslint-plugin-r, shaving off unnecessary polyfills. It's nowhere near as well done, as it lacks auto-release feature for example, but if anyone's interested, here it is:

https://github.com/wojtekmaj/eslint-plugin-r

Trying to use this package for the first time, I got:

Error: Failed to load plugin 'import' declared in '.eslintrc.js': Cannot find module 'array.prototype.flatmap'

Looks like because 2.28.0 added dependencies on:

• array.prototype.flatmap
• array.prototype.findlastindex
• object.fromentries

Which means they should be added to dependencies here too (unless they're being handled some other way).

Workaround is just to add the missing dependency as a dev dependency in my project.

Affected code:

export { DecodedIdToken } from 'firebase-admin/lib/auth/token-verifier';

Error: Unable to resolve path to module 'firebase-admin/lib/auth/token-verifier' import/no-unresolved

Versions before:

    "firebase-admin": "^11.5.0",
    "eslint-plugin-import": "npm:eslint-plugin-i@^2.26.0-2",

Versions after:

    "firebase-admin": "^11.5.0",
    "eslint-plugin-import": "npm:eslint-plugin-i@^2.27.5",

There are WAY TOO MANY polyfills in the dependencies. Let's target Node.js 14 and drop all of them!

A major issue with eslint-plugin-import is that it doesn't support exports: import-js#1810

I was wondering if you might consider using resolve.exports or enhanced-resolve rather than the outdated resolve package in this library to address that

Since Sep 16, the rebase workflow fails to push. I think you may need to disable branch protection on GitHub UI for it to work again:

 Successfully rebased and updated refs/heads/fork-release.
remote: error: GH006: Protected branch update failed for refs/heads/fork-release.        
remote: error: Changes must be made through a pull request.        
To https://github.com/un-es/eslint-plugin-i
 ! [remote rejected] fork-release -> fork-release (protected branch hook declined)
error: failed to push some refs to 'https://github.com/un-es/eslint-plugin-i'

Looks like there's a merge conflict: https://github.com/un-es/eslint-plugin-i/actions/runs/4781217733/jobs/8499474706

It seems the plugin does not recognize this:

settings:
  i/extensions: [".js", ".jsx", ".ts", ".tsx"]

It only worked after renaming to import/extensions.