The upgraded packages should stay in the context of Microsoft's version 3.x.x

• Adjust the C# project files (the library and the test)
• Eliminate the .NET 7.0 fork and its associated build pipeline
• Update the README file

This has to start with using Microsoft's .NET 6.0's RC NuGet packages.

This issue is related to #75 and the outcome of that issue resulted in adding a new method to return at least one appsettings.json file. In fact, this is the code to retire.

The classes implementing IDisposable and/or IAsyncDisposable need to employ a boolean flag to prevent repeating disposing of resources if it's already done.

This method was already deprecated and therefore its removal is safe.

• Remove the .NET 7.0-related comments from the README.md file
• Upgrade the .NET 7.0 SDK in the build pipeline of the fork
• Merge
• Upgrade the NuGet packages to the latest one

This implementation helps sharing the service provider among multiple test classes to avoid instantiating it per each test class.

• Upgrade .NET SDK in the build pipelines

The current implementation of GetServiceProvider in TestBedFixture class needs to be modified to allow adding any logger providers.

The area to change is the following one:

_services.AddLogging(loggingBuilder => loggingBuilder.AddProvider(new OutputLoggerProvider(testOutputHelper)));

• #167
• #168
• #169
• #170
• #171
• #172

• Making both Clear() and DisposeAsyncCore() virtual methods
• Update the document
• Update the example project
• Update the build pipeline's SDK

background

The reason for this change is that the mentioned methods are not usually implemented in the derived classes. We can still give developers the option of overriding them if they require it by making them virtual.

The provided app settings files may be optional and depending on the scenarios but the current code does not support it. We need to make the following enhancements:

• The current implementation of GetConfigurationFiles() method to be marked as [Obsolete] to generate a proper message to direct developers to the new method
• Introduce a new abstract method called GetTestAppSettings() to return a collection of the following class instead of strings:

public class TestAppSettings
{
   public string? Filename { get; set; }
   public bool IsOptional { get; set; } = false;
}

• Remove the obsolete configuration file getter method
• Update copyright year in the nuget config file
• Upgrade NuGet packages
• Reflect test order setup in the readme file
• Wire up environment variables

The most important NuGet packages to upgrade are Microsoft's. version 3.1.12 to bump up to.

• Remove public IConfigurationBuilder ConfigurationBuilder{ get; private set; } but instead add an Action<IConfigurationBuilder> parameter to GetConfigurationRoot(IEnumerable configurationFiles)`
• Deprecate GetConfigurationFile()
• Enable nullable
• Use latest SDK in the build pipelines

Developers need further clarity on using the library and hence including an example project will be useful.

Hi, based on instructions here, I'm getting an error that you can perhaps help with. Any tips appreciated. I'm stuck!

Here is my fixture:

using Microsoft.Azure.CosmosRepository;
using Microsoft.Extensions.Options;
using OeQb.Modules.QbCoreProducts.BusSvc;
using OeQb.Modules.QbCoreProducts.GrpcDomain.Models;
using Xunit.Microsoft.DependencyInjection;

[CollectionDefinition("Dependency Injection")]
public class BaseTestFixture : TestBedFixture
{
    protected override void AddServices(IServiceCollection services, IConfiguration? configuration)
    {
        services.AddTransient<IRepository<OeProject>>();
        services.AddTransient<IOeProjectDbService, OeProjectDbService>()
            .Configure<TestOptions>(config => configuration?.GetSection("TestOptions").Bind(config));
        
    }

    protected override ValueTask DisposeAsyncCore()
        => new();

    protected override IEnumerable<TestAppSettings> GetTestAppSettings()
    {
        yield return new() { Filename = "appsettings.json", IsOptional = false };
    }
    
}

And here is the xunit test (using all newest NuGet versions):

using OeQb.Modules.QbCoreProducts;
using OeQb.Modules.QbCoreProducts.BusSvc;
using OeQb.Modules.QbCoreProducts.GrpcDomain.Requests;
using Shouldly;

//  https://dev.to/arashsabet/xunit-dependency-injection-nm2  
//  https://umplify.github.io/xunit-dependency-injection/

[TestCaseOrderer("Xunit.Microsoft.DependencyInjection.TestsOrder.TestPriorityOrderer", "Xunit.Microsoft.DependencyInjection")]
[CollectionDefinition("Dependency Injection")]
public class OeProjectTests : TestBed<BaseTestFixture>
{
    public OeProjectTests(ITestOutputHelper testOutputHelper, BaseTestFixture fixture)
        : base(testOutputHelper, fixture)
    {
    }
    
    [Fact, TestOrder(1)]
    public async Task SimpleCrud()
    {
        var oeProjectDbSvc = _fixture.GetService<IOeProjectDbService>(_testOutputHelper);
        var oeCoreProdManufDbSvc = _fixture.GetService<IOeCoreProdManufDbService>(_testOutputHelper);
        var seed = new SeedCoreProdDb(oeProjectDbSvc, oeCoreProdManufDbSvc);
        await seed.SeedAll();

        var oeProj1 = await oeProjectDbSvc.Get(new OeProjectRequest() { OeProjectGuid = "0000OEQB-3008-2023-0000-000000000001" });
        var t1 = oeProj1.ProjectName;
        t1.ShouldBe("230904202510--DefaultCategoryName");
        
    }
}

And here is the error:

System.ArgumentException: Cannot instantiate implementation type 'Microsoft.Azure.CosmosRepository.IRepository`1[OeQb.Modules.QbCoreProducts.GrpcDomai...

System.ArgumentException
Cannot instantiate implementation type 'Microsoft.Azure.CosmosRepository.IRepository`1[OeQb.Modules.QbCoreProducts.GrpcDomain.Models.OeProject]' for service type 'Microsoft.Azure.CosmosRepository.IRepository`1[OeQb.Modules.QbCoreProducts.GrpcDomain.Models.OeProject]'.
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.Populate()
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory..ctor(ICollection`1 descriptors)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider..ctor(ICollection`1 serviceDescriptors, ServiceProviderOptions options)
   at Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(IServiceCollection services, ServiceProviderOptions options)
   at Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(IServiceCollection services)
   at Xunit.Microsoft.DependencyInjection.Abstracts.TestBedFixture.GetServiceProvider(ITestOutputHelper testOutputHelper)
   at Xunit.Microsoft.DependencyInjection.Abstracts.TestBedFixture.GetService[T](ITestOutputHelper testOutputHelper)
   at OeDriveApi.Tests.Modules.QbCoreProducts.OeProjectTests.SimpleCrud() in 

Sincere thanks!

The current code does not dispose the service collection which needs to be taken care of upon the disposal of the fixture object.

• Update NuGet package
• Build pipelines
• Re-run the tests

We need to rename the project to relay the actual mission of this library.

The project template you provider not compile

https://github.com/Umplify/xunit-dependency-injection/tree/main/examples/Xunit.Microsoft.DependencyInjection.ExampleTests

Thanks

There will certainly cases when developers would like to dispose objects that are already supporting asynchronous disposing pattern. For that reason, we do need to ensure the aforementioned classes do support IAsyncDispose too.

The following method should accommodate state in all log levels:

public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception? exception, Func<TState, Exception, string> formatted)

• Apply the fix
• Augment the test project to observe the fix in Calculator test service

The 3rd party NuGet packages must be upgraded to the recent ones.

Apparently it's not easily feasible to use collection fixtures as explained in #48. So, we'd better focus on class fixture implementation and remove the collection fixture to have concise code.

At the moment, we are able to specify the name of the JSON configuration file, which is typically appsettings.json.
We should be able to load configuration settings from other files like appsettings.dev.json
We usually do this by chaining AddJsonFile(...
If you could expose the builder object, then we could implement this directly in our project.

This issue is related to #88

• This task includes upgrading the NuGet packages and updating the language version to C# 10.0
• Update the CI/CD pipelines

The initial full-fledged code should be committed to the repo.

The instructions are found here.

That would include Microsoft's LTS packages and others if available.

We need to have the following property to be able to make IConfigurationRoot available to derived classes:

public IConfigurationRoot Configuration { get; private set; }

• Increase the SDK version
• Include the test project in the PR build pipeline

This enhancement is required to let developers access the configuration builder object to be able to add their environment variables too.

Is your feature request related to a problem? Please describe.
There is no way to read the configuration from the UserSecret, I can only write the secret directly in the appsettings in plain text.

Describe the solution you'd like
Adding a configuration from UserSecrets is very simple.
The only problem that needs to be solved is that you need to expose the ConfigurationBuilder in TestFixture, rather than adding the Configuration by filename, I don't know if the test project has restrictions on this aspect of the implementation, but exposing the ConfigurationBuilder is clearly a better choice.