umbrellio / code-style Goto Github PK

If the subject is code style, it should be named 'javascript' (or 'es6') and if the subject is eslint config, it should be named 'eslint'. It may be a tough choise about naming, but as far as i see, there is no eslint strict dependency so if we want to add config for different linter, it would not be hard to combine it in one npm package, which could be used in both.

Pros of 'eslint' naming:

• We can separate eslint configuration from e.g. JSHint

Pros of 'javascript' / 'es6' naming:

• We can add our code style guide (like ruby style guide in https://github.com/bbatsov/ruby-style-guide)
• I wish to develop 'ruby' style guides with markdown documentation, which would describe all deviatoins from bbatsov/ruby-style-guide we are forcing / allowing and refer it's content in rubocop configuration file, it would be a consistent naming in this case

Right now, all rules are enabled, regardless of whether the user uses React, JSX, Flow and so on. I suggest we do something similar to kentcdodds/eslint-config-kentcdodds.

or possibly configured, but this configuration would take huge amount of time :(

I think, there will be a lot of situations when length of block in rake-task is bigger than 30 lines.
Propose to delete this cop for *.rake

It seems it should be disabled in most cases

See examples in my own gem: https://github.com/0exp/armitage/tree/master/armitage-rubocop

PR coming soon

Same as AS-based (probably) and also optionaly create rails 5 file.

As long as i am no more porject maintainer, can you please remove me from gemspec?

eslint-plugin-jsx-a11y and eslint-plugin-react are out of date and should be updated.

Right now, some rules are disabled or changed because of several small incompatibilities with styled-components. Since we need to use a separate config for styled-components anyways, let's split configs into two - one for regular SCSS and one for styled-components.

• Setup CONTRIBUTING.md
  https://help.github.com/articles/setting-guidelines-for-repository-contributors/
  Add general suggestions there:

  • name PR and commits like [Rubocop] force double quotes
  • name branches like rubocop/force-double-quotes
  • never merge into master, choise from rebase on master and squash and merge

• Setup rubocop, eslint, and stylelint labels for issues and PR

• Setup PR and Issue templates

WDYT?