umbe1987 / shire Goto Github PK

I tried to separate the logic of getting the layers (WMS) info 'map.onclick' in e19c94a.
Right now, getText() uses forEach.

return in forEach loop does not stops function as explained here.

using forEach, you are entering a new function (.foreach(function (e) {…})) and calling return there stops that new function and not the parent (checkIfFollowed) one

I would need to take advantage from it: if it returns "everything", I might check how many undefined or text I get and do something with them. Need to test a bit...

follow PyWPS docs.

Apparently this happens only in Chrome when zooming in or out the map with two fingers on mobile.

Problem
the toc looses the opacity slider and legens under each layer.

Cause
Acoording to openlayers/openlayers#9105, too many change:resolution events are triggered when zooming with two fingers.

Solution proposed
Using debouncing in JavaScript.

• openlayers/openlayers#9105 (comment)
• https://css-tricks.com/the-difference-between-throttling-and-debouncing/
• https://www.npmjs.com/package/lodash.throttle
• https://john-dugan.com/javascript-debounce/

After 16314c4 zoom to layer extent is broken.
Need to find a good way to finish the code.
Found a great help by studying this SO answer.

This can be seen with lengthy services (many layers). In case there are lots of layers and the ToC panel need to be scrolled down, on zoom it gets scrolled up.

Service to test: https://servizigis.regione.emilia-romagna.it/wms/rete_escursionistica?SERVICE=WMS&VERSION=1.3.0&REQUEST=GetCapabilities

• LEGEND

Like in this case:

Layers don't have a legend, and so requesting it leads to:

• WMS Exceptions (example)

• Nasty image within layer list

• GetFeatureInfo

If exception is raised after a GetFeatureInfo request, it goes inside a "info" fancyAlert, rather than an "error" one (e.g. this one).

According to the official OGC WMS 1.3.0 specification:

The <MinScaleDenominator> and <MaxScaleDenominator> elements define the range of scales for which it is appropriate to generate a map of a Layer.

It would be nice to grey out layers in the toc if layers are not visible due to scale.
Use this to get current scale with OL and compare it with WMS capabilities.

With the WMS parser, when I get the extent of a point layer, I then set it in the ol.source.ImageWMS params 'extent' option, but this is cutting the pint image symbol.

As requesting all the records from a WFS which has many rows slows down the rendering of the table, now there's an impse limit to a maximum of feature requests which is 200 (maybe too few).
I can implement a pagination like I do for the Info panel, by paginating the rows with the parameters STARTINDEX combined with MAXFEATURES, as described in https://docs.qgis.org/testing/en/docs/user_manual/working_with_ogc/server/services.html#getfeature.

e.g. 200 records starting from the 200th

https://www.wondermap.it/cgi-bin/qgis_mapserv.fcgi?map=/home/ubuntu/qgis/projects/glaciers_WMS/demo_glaciers.qgs&SERVICE=WFS&VERSION=1.1.0&REQUEST=GetFeature&MAXFEATURES=200&STARTINDEX=200&TYPENAME=glaciers_area&

(without geometry, see also #19)
https://www.wondermap.it/cgi-bin/qgis_mapserv.fcgi?map=/home/ubuntu/qgis/projects/glaciers_WMS/demo_glaciers.qgs&SERVICE=WFS&VERSION=1.1.0&REQUEST=GetFeature&MAXFEATURES=200&STARTINDEX=200&TYPENAME=glaciers_area&GEOMETRYNAME=none&

Reported as BUG to QGIS repo (see https://issues.qgis.org/issues/20549).
Alesandro Pasotti fixed it here qgis/QGIS#8520.
It is now in QGIS 3.4.2, need to wait that it gets to the ubuntu ppa (at present 24/11/2018 I have 3.4.0 and I can only upgrade to 3.4.1).

Now that services are secured with HTTP Basic Auth, accessing the WFS resource from export_wfs.php gives 401 Unauthorized error.

I am experiencing this issue from wondermap.it and not from my dev machine.
Will overwrite soon to see if everything get fixed, otherwise I have to look into it.

It would be very nice if a WMS has the GetLegendGraphic capability to add the legend to the layer.

DOCUMENTATION

• http://mapserver.org/ogc/wms_server.html#getlegendgraphic-request
• https://enterprise.arcgis.com/en/server/latest/publish-services/windows/wms-services.htm
• http://docs.geoserver.org/stable/en/user/services/wms/get_legend_graphic/index.html

EXAMPLE

• https://servizigis.regione.emilia-romagna.it/wms/dbtr?service=wms&request=GetLegendGraphic&version=1.3.0&layer=LAB_Localita_abitata_poligonale&FORMAT=image/png&WIDTH=20&HEIGHT=20

It overwrites some style (e.g the sidebar header).
At present, it is used by the popup.
Follow the official ol example to create popups without bootstrap.

It would be nice to have a zoom icon by the layer list in the panel which, once clicked, zooms at the layer extent.

The limit to requests a maximum of 200 records from WFS to build the Attribute Table causes the download of the same only 200 records.

Either I create a sort of pagination to split the requests in 200 records per page, or I should remove the final part of the WFS URL request passed in the downolad button like url.replace('&MAXFEATURES=200&','');.

If more than one layer is on, the info loop can't reach the layers after the first one.

Can be avoided by appending &GEOMETRYNAME=none to the WFS GetFeature request (probably not supported by other WFS vendors like GeoServer).

Take inspiration from this gis.stackexchange answer.
See also official OL example, which uses jsPDF library.

This is happenign because I am using info_panel.innerHTML = (data); ti inserto the info inside the panel, replacing everything there was before clicking the layer, and thus the <h1> header.
Need to handle this!

It would be nice to have a working example to show the state of the project.