ultimaker / libsavitar Goto Github PK

src/Face.h says this file is released under GPL-3+, while LICENSE and the rest of libSavitar says LGPL-3+.

Was this an oversight, or is this file really GPL-3+?

ThreeMFParser.h includes SavitarExport.h, but this file is not installed by default.

As a result, compiling anything against libSavitar outside the tree will fail.

Please add the include file to savitar_HDRS in CMakeLists.txt .

There is an error with this repository's WhiteSource configuration file that needs to be fixed. As a precaution, scans will stop until it is resolved.

Errors:

• "settingsInteritedFrom" attribute provided in Ultimaker/libSavitar/.whitesource points to a non-existent repository or branch: 'Ultimaker/whitesource-config@master'

Hi

any option for use system pugixml instead of bundled?

when install libsavitar make some file conflicts with pugixml installed in the system

Application version
4.4.0

Platform
windows 10, 64 bit

Printer
none

Reproduction steps

1. load 3mf file which contains metadata, attributes under the correct cura namespace http://software.ultimaker.com/xml/cura/3mf/2015/10 but using a namespace prefix other than cura
2. file is loaded but metadata is ignored because the namespace prefix is not literally set to cura
   (which is incorrect, cura is an xml namespace prefix, and a namespace prefix acts like a handle for the namespace and is otherwise meaningless, so as long as the namespace is correct, the namespace prefix should make no difference whatsoever when loading the 3mf xml, in Cura or any other software)

Screenshot(s)
I have used a 3mf file with this model contents

<model... xmlns:customXMLNS0="http://software.ultimaker.com/xml/cura/3mf/2015/10" ...>
  ... <metadata name="customXMLNS0:extruder_nr" type="string" preserve="1">0</metadata>
</model>

Actual results
Model will be loaded but cura metadata is ignored.

Expected results
The namespace I used (not the prefix) is correct = http://software.ultimaker.com/xml/cura/3mf/2015/10.
Metadata should be loaded independent of the namespace prefix used (in my case customXMLNS0).

Workaround results
By changing the namespace prefix to cura, Ultimaker will correctly load the metadata, which means that you are searching for a specific namespace prefix and not the namespace itself.

This is incorrect according to standard xml functionality. Loading should work the same, no matter what namespace prefix is used.

Project file

Log file

Additional information

see plugins

• plugins/3MFReader/ThreeMFReader.py
• plugins/3MFWriter/ThreeMFWriter.py

https://en.wikipedia.org/wiki/XML_namespace

From #26

There are a number of problems with this pull request:

• It doesn't seem to work. At least, the automated test is failing with that it can't find sip.h. We'd also need to update the build environment to have this SIP version.
• It makes this repository depend on PyQt5. libSavitar doesn't have anything to do with Qt so that's an unreasonable dependency.
• I don't really see a reason for us to update. We're not using anything in SIP 5.

For these reasons I'll reject this pull request, sorry.

Originally posted by @Ghostkeeper in #26 (comment)

Hallo,
i can't compile libSavitar 5.0.0 with Ubuntu 22.04.
=> ModuleNotFoundError: No module named 'sipbuild'

Installed software:

• protobuf 3.17.1
• SIP 6.5.0 and also tested with 6.5.1
• python 3.10.4

cd libSavitar-5.0.0
mkdir build && cd build
cmake ..
-- The C compiler identification is GNU 11.2.0
-- The CXX compiler identification is GNU 11.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Setting BUILD_SHARED_LIBS to ON
-- Setting build type to 'Release' as none was specified.
-- Generating compile commands to /home/klemmh/cura5/libSavitar-5.0.0/build/compile_commands.json
-- Setting POSITION_INDEPENDENT_CODE: ON
-- Setting C++17 support with extensions off and standard required
CMake Deprecation Warning at pugixml/CMakeLists.txt:3 (cmake_minimum_required):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.

Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.

CMake Warning (dev) at pugixml/CMakeLists.txt:5 (option):
Policy CMP0077 is not set: option() honors normal variables. Run "cmake
--help-policy CMP0077" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.

For compatibility with older versions of CMake, option is clearing the
normal variable 'BUILD_SHARED_LIBS'.
This warning is for project developers. Use -Wno-dev to suppress it.

-- Setting SKIP_BUILD_RPATH for target Savitar to FALSE
-- Setting BUILD_WITH_INSTALL_RPATH for target Savitar to FALSE
-- Setting INSTALL_RPATH_USE_LINK_PATH for target Savitar to TRUE
-- Setting install RPATH for target Savitar to $ORIGIN/;$ORIGIN/$<$<PLATFORM_ID:Linux>:usr/bin>;$ORIGIN/$<$<PLATFORM_ID:Linux>:usr/bin/lib>;$ORIGIN/$<$<PLATFORM_ID:Darwin>:../lib>;$ORIGIN/$<$<PLATFORM_ID:Darwin>:../Resources/lib>
-- Setting Python version to 3.10. Set Python_VERSION if you want to compile against an other version.
-- Found Python: /usr/bin/python3.10 (found suitable exact version "3.10.4") found components: Interpreter Development Development.Module Development.Embed
-- Linking and building against Python 3.10.4
-- Found SIP version: 6.5.1
-- Setting SKIP_BUILD_RPATH for target pySavitar to FALSE
-- Setting BUILD_WITH_INSTALL_RPATH for target pySavitar to FALSE
-- Setting INSTALL_RPATH_USE_LINK_PATH for target pySavitar to TRUE
-- Setting install RPATH for target pySavitar to $ORIGIN/;$ORIGIN/$<$<PLATFORM_ID:Linux>:usr/bin>;$ORIGIN/$<$<PLATFORM_ID:Linux>:usr/bin/lib>;$ORIGIN/$<$<PLATFORM_ID:Darwin>:../lib>;$ORIGIN/../../
-- SIP: Generating pyproject.toml
-- SIP: Generating source files
'/usr/bin/cmake' '-E' 'env' 'PYTHONPATH=::/home/klemmh/cura5/libSavitar-5.0.0/build' '/home/klemmh/.local/bin/sip-build' '--pep484-pyi' '--no-protected-is-public'
Using the CMake builder
These bindings will be built: pySavitar.
Generating the source files
Generating the pySavitar bindings...
Generating the pySavitar .pyi file...
The project has been built.
-- SIP: Touching the source files
-- SIP: Collecting the generated source files
-- SIP: Collecting the user specified source files
-- SIP: Linking the interface target against the shared library
-- SIP: Installing Python module and PEP 484 file in /usr/lib/python3/dist-packages
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Configuring done
CMake Warning (dev) at pugixml/CMakeLists.txt:42 (add_library):
Policy CMP0069 is not set: INTERPROCEDURAL_OPTIMIZATION is enforced when
enabled. Run "cmake --help-policy CMP0069" for policy details. Use the
cmake_policy command to set the policy and suppress this warning.

INTERPROCEDURAL_OPTIMIZATION property will be ignored for target 'pugixml'.
This warning is for project developers. Use -Wno-dev to suppress it.

-- Generating done
-- Build files have been written to: /home/klemmh/cura5/libSavitar-5.0.0/build

make
[ 4%] Building CXX object pugixml/CMakeFiles/pugixml.dir/src/pugixml.cpp.o
[ 8%] Linking CXX static library libpugixml.a
[ 8%] Built target pugixml
[ 12%] Building CXX object CMakeFiles/Savitar.dir/src/Namespace.cpp.o
[ 16%] Building CXX object CMakeFiles/Savitar.dir/src/ThreeMFParser.cpp.o
[ 20%] Building CXX object CMakeFiles/Savitar.dir/src/SceneNode.cpp.o
[ 24%] Building CXX object CMakeFiles/Savitar.dir/src/Scene.cpp.o
[ 28%] Building CXX object CMakeFiles/Savitar.dir/src/MeshData.cpp.o
[ 32%] Building CXX object CMakeFiles/Savitar.dir/src/Vertex.cpp.o
[ 36%] Building CXX object CMakeFiles/Savitar.dir/src/Face.cpp.o
[ 40%] Linking CXX shared library libSavitar.so
[ 40%] Built target Savitar
[ 44%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/array.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/array.c:25:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 48%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/descriptors.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/descriptors.c:22:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 52%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/int_convertors.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/int_convertors.c:24:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 56%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/objmap.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/objmap.c:23:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 60%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/siplib.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/siplib.c:30:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 64%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/threads.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/threads.c:22:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 68%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/voidptr.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/voidptr.c:25:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 72%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/bool.cpp.o
[ 76%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart0.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart0.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 80%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart1.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart1.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 84%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart2.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart2.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 88%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart3.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart3.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 92%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart4.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart4.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 96%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart5.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart5.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[100%] Linking CXX shared library pySavitar.so
Using the CMake builder
These bindings will be built: pySavitar.
Generating the source files
Generating the pySavitar bindings...
Generating the pySavitar .pyi file...
The project has been built.
[100%] Built target sip_pySavitar

sudo make install
Consolidate compiler generated dependencies of target pugixml
[ 8%] Built target pugixml
Consolidate compiler generated dependencies of target Savitar
[ 40%] Built target Savitar
Consolidate compiler generated dependencies of target sip_pySavitar
[ 44%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/array.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/array.c:25:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 48%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/descriptors.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/descriptors.c:22:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 52%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/int_convertors.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/int_convertors.c:24:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 56%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/objmap.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/objmap.c:23:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 60%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/siplib.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/siplib.c:30:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 64%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/threads.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/threads.c:22:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 68%] Building C object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/voidptr.c.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipint.h:26,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/voidptr.c:25:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 72%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/bool.cpp.o
[ 76%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart0.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart0.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 80%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart1.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart1.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 84%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart2.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart2.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 88%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart3.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart3.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 92%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart4.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart4.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[ 96%] Building CXX object CMakeFiles/sip_pySavitar.dir/pySavitar/pySavitar/sippySavitarpart5.cpp.o
In file included from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sipAPIpySavitar.h:10,
from /home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sippySavitarpart5.cpp:7:
/home/klemmh/cura5/libSavitar-5.0.0/build/pySavitar/pySavitar/sip.h:62: warning: "SIP_VERSION" redefined
62 | #define SIP_VERSION 0x60501
|
: note: this is the location of the previous definition
[100%] Linking CXX shared library pySavitar.so
Traceback (most recent call last):
File "/home/klemmh/.local/bin/sip-build", line 5, in
from sipbuild.tools.build import main
ModuleNotFoundError: No module named 'sipbuild'
make[2]: *** [CMakeFiles/sip_pySavitar.dir/build.make:309: pySavitar.so] Fehler 1
make[2]: *** Datei „pySavitar.so“ wird gelöscht
make[1]: *** [CMakeFiles/Makefile2:129: CMakeFiles/sip_pySavitar.dir/all] Fehler 2
make: *** [Makefile:136: all] Fehler 2

The error messages are:

jiaoyedeMacBookPro:build jiaoye$ make
Scanning dependencies of target pugixml
[  5%] Building CXX object pugixml/CMakeFiles/pugixml.dir/src/pugixml.cpp.o
[ 10%] Linking CXX static library libpugixml.a
[ 10%] Built target pugixml
Scanning dependencies of target Savitar
[ 15%] Building CXX object CMakeFiles/Savitar.dir/src/ThreeMFParser.cpp.o
[ 21%] Building CXX object CMakeFiles/Savitar.dir/src/SceneNode.cpp.o
[ 26%] Building CXX object CMakeFiles/Savitar.dir/src/Scene.cpp.o
[ 31%] Building CXX object CMakeFiles/Savitar.dir/src/MeshData.cpp.o
[ 36%] Building CXX object CMakeFiles/Savitar.dir/src/Vertex.cpp.o
[ 42%] Building CXX object CMakeFiles/Savitar.dir/src/Face.cpp.o
[ 47%] Linking CXX shared library libSavitar.dylib
Undefined symbols for architecture x86_64:
  "_PyBytes_AsString", referenced from:
      Savitar::MeshData::setVerticesFromBytes(_object*) in MeshData.cpp.o
      Savitar::MeshData::setFacesFromBytes(_object*) in MeshData.cpp.o
  "_PyBytes_FromStringAndSize", referenced from:
      Savitar::MeshData::getVerticesAsBytes() in MeshData.cpp.o
      Savitar::MeshData::getFlatVerticesAsBytes() in MeshData.cpp.o
      Savitar::MeshData::getFacesAsBytes() in MeshData.cpp.o
  "_PyBytes_Size", referenced from:
      Savitar::MeshData::setVerticesFromBytes(_object*) in MeshData.cpp.o
      Savitar::MeshData::setFacesFromBytes(_object*) in MeshData.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libSavitar.0.1.0.dylib] Error 1
make[1]: *** [CMakeFiles/Savitar.dir/all] Error 2
make: *** [all] Error 

My python3 is installed via Homebrew.

Hi, in order to compile Cura (and all the libs) I had to patch up the CMakeLists.txt to correctly use Lib_Suffix.
I share my lib64.patch, if you found it acceptable can you add it to the code?
lib64.txt

Class Face is exported, but not in the Savitar namespace.

This should probably be fixed to avoid conflicts.

1. standardprojectsettings is not a proper dependency usable outside of Conan
2. Conan is not really usable in an offline scenario

This is a kind request to:

1. Make standardprojectsettings usable with a standard build, e.g. git clone; git checkout; cmake; make. I.e. find_package(standardprojectsettings) should be working outside Conan
2. Install libraries with make install
3. Install CMake config files with make install

See e.g. https://repology.org/project/cura/versions - nobody packages Cura > 4.13.1 (AUR is just repackaged AppImage).

Hi, I noticed that libSavitar does not have any release tags.

Since Cura 2.5.0 has been out for a while and 2.6 is already in the pipeline, could you tag the commit that was used for 2.5.0?

Thanks!

Updates fail:
Distro: EndeavourOS
Kernel: 6.8.2-arch2-1

-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:4 (find_package):
By not providing "Findstandardprojectsettings.cmake" in CMAKE_MODULE_PATH
this project has asked CMake to find a package configuration file provided
by "standardprojectsettings", but CMake did not find one.

Could not find a package configuration file provided by
"standardprojectsettings" with any of the following names:

standardprojectsettingsConfig.cmake
standardprojectsettings-config.cmake

Add the installation prefix of "standardprojectsettings" to
CMAKE_PREFIX_PATH or set "standardprojectsettings_DIR" to a directory
containing one of the above files. If "standardprojectsettings" provides a
separate development package or SDK, be sure it has been installed.

-- Configuring incomplete, errors occurred!
==> ERROR: An error occurred in build().
Break off...
-> Error building: libsavitar-exit status 4
-> The following packages could not be installed. Manual intervention is required:
libsavitar - exit status 4