Issues with count_hosts_by_os example about nmap HOT 3 OPEN

Hi @mikemadden42 ! Thanks for opening this issue :) It indeed requires root privileges, since in order to detect operating systems, nmap needs to do TCP/IP fingerprinting.

As for the inaccurate counts, I think I know what is happening, but just to be sure, could you please run the following on your machine?

sudo nmap -F -O 192.168.0.0/24

I think what happens is that the OS detection counts multiple times per host, in some cases. I am unable to reproduce it on my network though, which is why it would be helpful to see the output you are getting :)

Either way, the fix is as simple as adding a break statement when we increase the count for a host, to avoid counting more than once per host.

from nmap.

Hi @Ullaakut , is there a subset of information I could provide? The full output of the nmap command you listed above could expose a lot of internal information.

from nmap.

Hi @mikemadden42,

Sure, you could just manually check whether or not it shows multiple OSes per host, and let us know here :)

from nmap.