Comments (12)
Hey! Thanks for reporting this. It's wrong indeed, I'll remove the v2 tag and remake it on the commit
8d64c8e
. Does it sound good to you? If I understand the issue correctly, that should fix the problem.
Unfortunately a v2.*
go module must have set the /v2
path in the go.mod file, so I think commit 2d0165c
should be the right one.
If you do not want to point two tags to the same commit I suggest to set:
2d0165c
-> v2.0.03b6d4c8
-> v2.0.15b56187
-> v2.0.2
Let's hope that go's sum database will accept these changes. :-)
from nmap.
Unfortunately a v2.* go module must have set the /v2 path in the go.mod file, so I think commit 2d0165c should be the right one.
Confirming this should work! 👍
However, in this case there wouldn't be a real change between v2.0.0 and v2.0.1, so you might completely ditch v2.0.2 and set v2.0.1 to commit 5b56187 which is the actual minor change @elivlo introduced (seen from actual code changes), while keeping v2.0.0 with 2d0165c as already suggested.
But this is a non-technical proposal seen from a semver and code-changes and not Go Module compatibility point-of-view.
from nmap.
Confirming the issue, seems that the v2.0.0 tag is set to the same commit as v1.0.0 is which must be wrong:
5b56187 (HEAD -> master, origin/master, origin/HEAD) Feature/run scan with progress sync function (#60)
3b6d4c8 (tag: v2.0.2) modify test dependency to /v2, update doc badge (#58)
2d0165c (tag: v2.0.1) Update go module to current version (v2.0.0) (#56)
8d64c8e Create go module (#55)
19c88ce Fix multiple with port calls (#52)
36b6e94 Feature add scan options after creation (#51)
227aaf3 Added error type and enhanced the error checking (#45)
bdc60e5 Update readme for updated scanner.run interface (#41)
55097e9 (tag: v2.0.0, tag: v1.0.0) Fix ScanRunner interface (#40)
from nmap.
Hey! Thanks for reporting this. It's wrong indeed, I'll remove the v2 tag and remake it on the commit 8d64c8e
. Does it sound good to you? If I understand the issue correctly, that should fix the problem.
from nmap.
Should be good now, can you confirm? :)
$> git push --tags -f
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:Ullaakut/nmap.git
+ 55097e9...2d0165c v2.0.0 -> v2.0.0 (forced update)
+ 2d0165c...3b6d4c8 v2.0.1 -> v2.0.1 (forced update)
+ 3b6d4c8...55097e9 v2.0.2 -> v2.0.2 (forced update)
from nmap.
- 3b6d4c8...55097e9 v2.0.2 -> v2.0.2 (forced update)
You accidently set this to the wrong commit, needs to be:
- 3b6d4c8...5b56187 v2.0.2 -> v2.0.2 (forced update)
from nmap.
Oh right nice catch, my bad! The tag should work now!
from nmap.
Did you publish?
from nmap.
The tags have been pushed yes, it should be enough for the go module to work, no?
from nmap.
I cloned it but tag v2.0.2 still has the wrong commit:
commit 55097e94556ea667f5b89b6dc25dc81856d2c527 (tag: v2.0.2, tag: v1.0.0)
Author: Brendan Le Glaunec <[email protected]>
Date: Sat Nov 30 16:41:46 2019 +0100
Fix ScanRunner interface (#40)
from nmap.
Alright this time should be the one. Turns out I hadn't pulled so I didn't have that commit and did not notice it errored 😅
from nmap.
No problem. The Issue should be fixed.
from nmap.
Related Issues (20)
- RunWithProgress goes from 100% to 0% and back again HOT 2
- Still timing out after 5 minutes HOT 2
- RunAsync lost s.cmd.Wait() ? HOT 1
- How should I get the json output of the Run HOT 4
- How i use this in windows10 , i have go build , but can't user, please tell me, thank you ! HOT 2
- Run the nmap scanned with custom arguments HOT 3
- Run nmap without runtime interaction HOT 6
- If the service recognises that there is a "?", how to deal with it? HOT 4
- Memory Usage is too high when using Progress(...) HOT 6
- XML to JSON support HOT 1
- The basic_scan_async demo cannot output the results in real time on the console HOT 3
- unable to create nmap scanner: nmap binary was not found HOT 2
- How we can do the OS scan with root privileges HOT 2
- unable to parse nmap output, see warnings for details: XML syntax error on line 7: unexpected EOF HOT 12
- nmap.WithOSDetection() HOT 1
- what's the equivalent of `-n` and `--defeat-rst-ratelimit` flag? HOT 1
- Example should be updated
- Error running scan: exit status 1 HOT 1
- when I run the code whit WithScripts hava warning HOT 1
- Memory Usage is too high HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nmap.