Broken module version management about nmap HOT 12 CLOSED

Hey! Thanks for reporting this. It's wrong indeed, I'll remove the v2 tag and remake it on the commit 8d64c8e. Does it sound good to you? If I understand the issue correctly, that should fix the problem.

Unfortunately a v2.* go module must have set the /v2 path in the go.mod file, so I think commit 2d0165c should be the right one.
If you do not want to point two tags to the same commit I suggest to set:

• 2d0165c -> v2.0.0
• 3b6d4c8 -> v2.0.1
• 5b56187 -> v2.0.2

Let's hope that go's sum database will accept these changes. :-)

from nmap.

Unfortunately a v2.* go module must have set the /v2 path in the go.mod file, so I think commit 2d0165c should be the right one.

Confirming this should work! 👍

However, in this case there wouldn't be a real change between v2.0.0 and v2.0.1, so you might completely ditch v2.0.2 and set v2.0.1 to commit 5b56187 which is the actual minor change @elivlo introduced (seen from actual code changes), while keeping v2.0.0 with 2d0165c as already suggested.

But this is a non-technical proposal seen from a semver and code-changes and not Go Module compatibility point-of-view.

from nmap.

Confirming the issue, seems that the v2.0.0 tag is set to the same commit as v1.0.0 is which must be wrong:

5b56187 (HEAD -> master, origin/master, origin/HEAD) Feature/run scan with progress sync function (#60)
3b6d4c8 (tag: v2.0.2) modify test dependency to /v2, update doc badge (#58)
2d0165c (tag: v2.0.1) Update go module to current version (v2.0.0) (#56)
8d64c8e Create go module (#55)
19c88ce Fix multiple with port calls (#52)
36b6e94 Feature add scan options after creation (#51)
227aaf3 Added error type and enhanced the error checking (#45)
bdc60e5 Update readme for updated scanner.run interface (#41)
55097e9 (tag: v2.0.0, tag: v1.0.0) Fix ScanRunner interface (#40)

from nmap.

Hey! Thanks for reporting this. It's wrong indeed, I'll remove the v2 tag and remake it on the commit 8d64c8e. Does it sound good to you? If I understand the issue correctly, that should fix the problem.

from nmap.

Should be good now, can you confirm? :)

$> git push --tags -f
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:Ullaakut/nmap.git
 + 55097e9...2d0165c v2.0.0 -> v2.0.0 (forced update)
 + 2d0165c...3b6d4c8 v2.0.1 -> v2.0.1 (forced update)
 + 3b6d4c8...55097e9 v2.0.2 -> v2.0.2 (forced update)

from nmap.

• 3b6d4c8...55097e9 v2.0.2 -> v2.0.2 (forced update)

You accidently set this to the wrong commit, needs to be:

• 3b6d4c8...5b56187 v2.0.2 -> v2.0.2 (forced update)

from nmap.

Oh right nice catch, my bad! The tag should work now!

from nmap.

Did you publish?

from nmap.

The tags have been pushed yes, it should be enough for the go module to work, no?

from nmap.

I cloned it but tag v2.0.2 still has the wrong commit:

commit 55097e94556ea667f5b89b6dc25dc81856d2c527 (tag: v2.0.2, tag: v1.0.0)
Author: Brendan Le Glaunec <[email protected]>
Date:   Sat Nov 30 16:41:46 2019 +0100

    Fix ScanRunner interface (#40)

from nmap.

Alright this time should be the one. Turns out I hadn't pulled so I didn't have that commit and did not notice it errored 😅

from nmap.

No problem. The Issue should be fixed.

from nmap.