ulabox / money Goto Github PK

I'm trying to use your library with Doctrine 2.5 embeddable objects. Unfortunately, this is impossible because I'm using annotations instead of YAML and the docblock must be applied to the properties. I can't extend the class to do it because you marked it as final. I know there has already been a long discussion about why you decided to restrict users from inheriting the Money class, but this makes this whole library unusable for anyone using annotations (that are really common on Symfony).

As the title says, just readme seems is not updated to last version as Money::EUR method no longer exists.

An example is the following

$money = Money::fromAmount('-3.9813', Currency::fromCode('EUR'));
$money->round(2)->amount() => -3.97

In this case the expected value is -3.98, we don't need to round.

In the following example we need to round but the expected and the expected value is -3.99.

$money = Money::fromAmount('-3.9863', Currency::fromCode('EUR'));
$money->round(2)->amount() => -3.98

Does it make sense to mark it as such, knowing that it's a public library and users are expected to tinker with it? It's currently preventing us from adding everyday helpers like format() or toFloat(), and we don't really see the benefit.