ukrainian-history / autobwf Goto Github PK

When creating initial MD for a "fresh" WAV file saved from Audacity or SoX, the MD5 calculation takes some time (as expected), but then the subsequent saves of the other BWF MD as well as RIFF and XMP are also extremely slow when they should be almost instantaneous. Is this a bwfmetaedit issue, or is something misconfigured in the CLI calls?

Changes to existing RIFF title field (INAM) metadata appears not be written to the file.

template data shows up as black on the RIFF tab but grey italic on XMP tab, even if the corresponding fields in the target file are empty

Looks familiar: 8608e4b

BWFMetaEdit bug?

might be nice to have a progress bar, since save can take a while, especially if a data chunk MD5 is being calculated. otherwise user may think it's hung.

Clicking on "Save metadata" a second time produces "Malformed input (xmp=file://filename.wav.XMP.xml, File does not exist)" error from bwfmetaedit.

Need to escape quotes in textbox fields.

either an "about" menu element, or a command line switch

Particularly when exporting mp3, there needs to be some visual indication that the export is occurring and when it is finished.

If there is preexisting metadata in CodingHistory and the default values in config have changed, then choosing a drop-down item that happens to match an existing value causes the text to change to the new config value without the text turning red and without enabling the switcher menu.

When concatenating very large files (e.g. 2 GB each), the component files get truncated. This is probably a SoX issue. It might be useful to to migrate from SoX to pydub.

Using the quit button on the save completion dialog leaves behind the .XMP.xml temp file because it never reaches the cleanup code.

Total up the number of "changed_bwf_riff" and set the max accordingly.

Copying text from the XMP Description field using "cmd-C" or from the right-click context menu on Ubuntu 18.04 causes the following:

Traceback (most recent call last): File "/home/uhec/.local/pipx/venvs/autoBWF/lib/python3.6/site-packages/autoBWF/autoBWF.py", line 484, in <lambda> widget.textChanged.connect(lambda element=field: self.text_changed(element)) File "/home/uhec/.local/pipx/venvs/autoBWF/lib/python3.6/site-packages/autoBWF/autoBWF.py", line 244, in text_changed del self.edited_md[input_widget] KeyError: 'xmp_description' Aborted (core dumped)

Add "ok and quit" button to completion dialog to avoid extra mouse click.

So that the user doesn't have to determine the file duration when splicing in the contents of an entire file.

RIFF ICRD tag should get prepopulated from the template file if it exists, but it doesn't.

Create expanded documentation using Sphinx

It's currently only used by autolame.

add "pip install" instructions to README

The warning pops up if the file has an empty description (e.g. it is a "virgin" Wave file with no BWF).

$ autoBWF uheca_2017-21_RL2_01_prod_20170731.wav
2022-01-25 18:56:26 uheca_2017-21_RL2_01_prod_20170731.wav: File does not exist

Traceback (most recent call last):
File "/home/andrec/.local/bin/autoBWF", line 33, in
sys.exit(load_entry_point('autoBWF', 'console_scripts', 'autoBWF')())
File "/home/andrec/Documents/autoBWF/autoBWF/autoBWF.py", line 816, in main
form = MainWindow(filename, config, template)
File "/home/andrec/Documents/autoBWF/autoBWF/autoBWF.py", line 187, in init
self.original_md = self.load_file(filename)
File "/home/andrec/Documents/autoBWF/autoBWF/autoBWF.py", line 212, in load_file
md = bwfio.check_wave(file)
File "/home/andrec/Documents/autoBWF/autoBWF/BWFfileIO.py", line 196, in check_wave
md = get_bwf_tech(filename)
File "/home/andrec/Documents/autoBWF/autoBWF/BWFfileIO.py", line 224, in get_bwf_tech
tech_csv = subprocess.check_output(command, universal_newlines=True)
File "/usr/lib/python3.8/subprocess.py", line 415, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/usr/lib/python3.8/subprocess.py", line 516, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['bwfmetaedit', '--specialchars', '--accept-nopadding', '--out-tech', 'uheca_2017-21_RL2_01_prod_20170731.wav']' returned non-zero exit status 1.

cp virgin.wav blah_1999-01_CA668_010101_pres_20160203.wav 
 cp virgin.wav blah_1999-01_CA666_010101_pres_20160203.wav 
 autoBWF blah_1999-01_CA666_010101_pres_20160203.wav 
 md5sum blah_1999-01_CA666_010101_pres_20160203.wav

f9a1f08707c15dccc35d21b6f8366e58 blah_1999-01_CA666_010101_pres_20160203.wav

autoBWF blah_1999-01_CA668_010101_pres_20160203.wav  -t blah_1999-01_CA666_010101_pres_20160203.wav 
 md5sum blah_1999-01_CA666_010101_pres_20160203.wav 

43f765c2048cf53de7991fa963572a46 blah_1999-01_CA666_010101_pres_20160203.wav

ITCH is not pre-filling with top menu item when working with a "virgin" Wave file with no BWF headers. The choice is in the dropdown, but it's in grey italics, which becomes red if you click on it...

File "autoBWF/autoBWF.py", line 688, in export_metadata dialog = Export(self.filepath) AttributeError: 'MainWindow' object has no attribute 'filepath'

self.filepath is set only when autoBWF is called with a file name in the command line. Needs to be set in file open dialog.

Would it make sense to have all CLI tools in one command with options (implemented with "click")?

When using bwfmetaedit 20.08, any text entered in any of the XMP fields appears not to get saved. However, after downgrading to bwfmetaedit 1.3.8, they magically materialize.

It seems that something has changed in bwfmetaedit's XMP import/export mechanism after v1.3.8 that conflicts with autoBWF's XMP XML serialization.

need to somehow deal with the case where the target file has existing MD that conflicts with the template

Traceback (most recent call last):
File "/home/andrec/.local/pipx/venvs/autoBWF/lib/python3.8/site-packages/autoBWF/autoBWF.py", line 704, in export_metadata
write_pbcore(vals["outfile"], md, self.filename, ohms_file, vals["audacity_button"])
File "/home/andrec/.local/pipx/venvs/autoBWF/lib/python3.8/site-packages/autoBWF/bwf2pbcore.py", line 156, in write_pbcore
pbcore = generate_pbcore(bwf_filename, metadata, ohms_root)
File "/home/andrec/.local/pipx/venvs/autoBWF/lib/python3.8/site-packages/autoBWF/bwf2pbcore.py", line 99, in generate_pbcore
add_multivalue_child(pbcore_root, "pbcoreSubject", metadata["names"], {"subjectType": "name"})
File "/home/andrec/.local/pipx/venvs/autoBWF/lib/python3.8/site-packages/autoBWF/bwf2pbcore.py", line 58, in add_multivalue_child
child.set(attribute, attributes[attribute])
AttributeError: 'NoneType' object has no attribute 'set'

Might be a bit hard to reproduce...

Check to make sure at least the Description data matches reality, and give warning if it isn't. The earlier template modification bug could have created erroneous MD.

Need to refresh the GUI if the user saves but does not quit: any newly-saved fields need to be grayed-out, etc.