Seems most projects do it this way. Will have to fix all the permalinks in issues that point to specific tests.

When using a XAML like the following:

<Activity x:Class=""WFTemplate""
          xmlns=""http://schemas.microsoft.com/netfx/2009/xaml/activities""
          xmlns:x=""http://schemas.microsoft.com/winfx/2006/xaml"">
  <Sequence>
    <WriteLine>
      <Content>
        <Text>""HelloWorld""</Text>
      </Content>
    </WriteLine>
  </Sequence>
</Activity>

I get this exception:

Result Message:	Portable.Xaml.XamlObjectWriterException : The value  for 'Text' property is null
Result StackTrace:	
at Portable.Xaml.XamlObjectWriterInternal.OnWriteGetObject()
   at Portable.Xaml.XamlWriterInternalBase.WriteGetObject()
   at Portable.Xaml.XamlServices.Transform(XamlReader xamlReader, XamlWriter xamlWriter, Boolean closeWriter)
   at CoreWf.XamlIntegration.FuncFactory`1.Evaluate() in C:\dev\corewf\src\CoreWf\XamlIntegration\FuncFactory.cs:line 91
   at CoreWf.DynamicActivity.OnInternalCacheMetadata(Boolean createEmptyBindings) in C:\dev\corewf\src\CoreWf\DynamicActivity.cs:line 122
   at CoreWf.Activity.InternalCacheMetadata(Boolean createEmptyBindings, IList`1& validationErrors) in C:\dev\corewf\src\CoreWf\Activity.cs:line 1074
   at CoreWf.ActivityUtilities.ProcessActivity(ChildActivity childActivity, ChildActivity& nextActivity, Stack`1& activitiesRemaining, ActivityCallStack parentChain, IList`1& validationErrors, ProcessActivityTreeOptions options, ProcessActivityCallback callback) in C:\dev\corewf\src\CoreWf\ActivityUtilities.cs:line 647
   at CoreWf.ActivityUtilities.ProcessActivityTreeCore(ChildActivity currentActivity, ActivityCallStack parentChain, ProcessActivityTreeOptions options, ProcessActivityCallback callback, IList`1& validationErrors) in C:\dev\corewf\src\CoreWf\ActivityUtilities.cs:line 910
   at CoreWf.ActivityUtilities.CacheRootMetadata(Activity activity, LocationReferenceEnvironment hostEnvironment, ProcessActivityTreeOptions options, ProcessActivityCallback callback, IList`1& validationErrors) in C:\dev\corewf\src\CoreWf\ActivityUtilities.cs:line 826
   at CoreWf.Hosting.WorkflowInstance.ValidateWorkflow(WorkflowInstanceExtensionManager extensionManager) in C:\dev\corewf\src\CoreWf\Hosting\WorkflowInstance.cs:line 376
   at CoreWf.Hosting.WorkflowInstance.RegisterExtensionManager(WorkflowInstanceExtensionManager extensionManager) in C:\dev\corewf\src\CoreWf\Hosting\WorkflowInstance.cs:line 182
   at CoreWf.WorkflowApplication.EnsureInitialized() in C:\dev\corewf\src\CoreWf\WorkflowApplication.cs:line 611
   at CoreWf.WorkflowApplication.RunInstance(WorkflowApplication instance) in C:\dev\corewf\src\CoreWf\WorkflowApplication.cs:line 1215
   at CoreWf.WorkflowApplication.Invoke(Activity activity, IDictionary`2 inputs, WorkflowInstanceExtensionManager extensions, TimeSpan timeout) in C:\dev\corewf\src\CoreWf\WorkflowApplication.cs:line 1245
   at CoreWf.WorkflowInvoker.Invoke(Activity workflow, TimeSpan timeout, WorkflowInstanceExtensionManager extensions) in C:\dev\corewf\src\CoreWf\WorkflowInvoker.cs:line 298
   at CoreWf.WorkflowInvoker.Invoke(Activity workflow, TimeSpan timeout) in C:\dev\corewf\src\CoreWf\WorkflowInvoker.cs:line 87
   at CoreWf.WorkflowInvoker.Invoke(Activity workflow) in C:\dev\corewf\src\CoreWf\WorkflowInvoker.cs:line 81
   at XamlTestCases.XamlTests.XamlWorkflowNoInputs(String xamlString) in C:\dev\corewf\src\XamlTestCases\XamlTests.cs:line 92

The Content element must not be setting the value of the Text property on WriteLine. Need to investigate why not.

The last change was three months ago and there has not been any activity since, best I can tell. So, if we are planning to move to .NET Core, should we write off Workflow Foundation altogether?

Will you be building a Nuget available somewhere so that people can directly include corewf in .net core apps?

Created a local nuget feed to consume it.

And thank you for this!

Tests like UnloadFlowchartWhileExecutingFlowConditionalCondition use a TestBlockingActivity that doesn't serialize correctly in the JSON serializer:

                Body = new TestBlockingActivity("Block");

The way the .NET Framework version of WF parses expressions is with a custom, unsupported compiler for VB and an MSBuild task for C#. It would be a significant improvement to use Roslyn for the .NET Standard/Core version of WF.

The file src/CoreWf/WfEventSource.cs includes a doubled Opcode definition:

public class Opcodes
        {
            //...
            public const EventOpcode ExecuteFlowchartBegin = (EventOpcode)11;
            public const EventOpcode BufferOutOfOrderNoInstance = (EventOpcode)11;
          //...

A lot of tests were left out because the features weren't implemented. Those tests can be ported and then disabled. As features are added, we can enable their tests.

Test is here

Using ASP.NET Core

This should either be replaced with a reflection-based implementation or use the System.ComponentModel pieces from the .NET Standard 2.0.

This is in reference to an issue with Portable.Xaml: cwensley/Portable.Xaml#105

Portable.Xaml isn't paying attention to the XmlnsDefinitionAttribute in a referenced assembly. WF uses these pretty heavily. Even when the attributes are copied into the test assembly's AssemblyInfo.cs, they're still not recognized.

The tests are temporarily getting around this by using CLR namespaces. But that will be a blocker for migrating from .NET Framework WF to CoreWF.

This project still uses the old project.json system. Upgrade to csproj.

Trackback to the guy (Ron) who really made a great effort for WF.

Seemed to have a great heart, and I learned how to code when he started his videos.

In the traditional build path in the .NET Framework, we have a tool called resxcodefilegenerator that turns a resx file into a cs file. Developers can then reference use properties to reference the various resource strings instead of calling ResourceManager directly. A new library introduced with .NET Core called Microsoft.Extensions.Localization includes the IStringLocalizer. The default language can be used as keys directly in the code since it will use the key if there is no resource string to be found for that culture. This also makes it easier to find where a particular error message comes from in the code.

If the WriteLine tests are run in a particular order, they can sometimes fail. Particularly the WriteTextExplicitPassConsole test

This doesn't seem useful. It's a carryover from .NET Framework.

We need dotnet/wpf#46.

As I understand from readme file you need a c# expression parser to complete WWF this implementation. I have one. I could 'clean' it from unrelated stuff and constricting licensing. If you specify an contract/interface to implement and location/folder where this code should be I would provide PR.

This is referring to @cwensley's port of Portable.Xaml to the .NET Standard here: https://github.com/cwensley/Portable.Xaml

It seems the most promising choice in terms of implementing the features of XAML that WF needs.

Have you considered using OmniXAML?

Have read that in the past it didn't support x:Class that was needed for WF, but now it does (in v2):
OmniGUI/OmniXAML#12

Microsoft is backing out of Newtonsoft JSON package in favor of it's own implementation. If we were to serialize the InstanceStore without depending on Newtonsoft to deep serialize object type to be able to later deseralize it, two changes to code should be made:

• ActivityInstance

[DataContact(IsReference = true)]

• InstanceValue

[KnownType(typeof(ActivityExecutor))]
    [KnownType(typeof(Variable<int>.VariableLocation))]
    [KnownType(typeof(Variable<string>.VariableLocation))]

Having done these we can use DataContractSerializer.WriteObject(), resulting in an xml we may persist.

Hi guys first let me say thanks you for this excellent work.

There is a guide o doc to port activities from a existing project?

Due to changes made during last couple of months. Prior to that, it used to work. The PersistableIdle fails if returns PersistableIdleAction.Persist when reaching end of flow.

As .NET Core 3 supports WPF, so I want to make experiments to port the Workflow Designer.
Where can I find the source code and unit tests of these dlls:
System.Activities.Presentation
System.Activities.Core.Presentation
Thank you.

WorkflowApplication.ResumeBookmark starts workflow from beginning, prior to attempting resumption

A lot of the resource strings used in CoreWF are the same as in the .NET Framework. These could be copied over.

I tried to compile CoreWf, but nuget cannot restore the "Microsoft.CodeAnalysis.VisualBasic.Scripting" package.

Where should that come from?

Test is here

This issue is for track the c# code behind generation based on the XAML activity representation.

Resuming a bookmark should not call Activity.Execute at all. Instead, it should only call the callback.

SWIS implements the InstanceStore abstract class and uses the client for SQL Server. It should be a straightforward port to .NET Standard.

Console writing is not included in all forms of the .NET standard. The WriteLine activity includes a default to write to the console. Separating it to its own package would allow us to support a lower .NET standard and be available to more platforms.

Will DynamicActivity be ported to CoreWF? Or is the functionality covered in some other way?

This would allow "To create an activity at runtime using imperative code" as described in the upper part of https://msdn.microsoft.com/en-us/library/ee358722(v=vs.110).aspx

when Install-Package CoreWf -Version 1.2.0, got an error message: 'Unable to find package CoreWf.Transactions. No packages exist with this id in source(s): '

Resx files allow you to include other things such as images into your localized resources. That's not necessary for a library like WF. The resx format is a clunky, old XML format that was intended to be edited with a tool. Restext, however, is much easier to read and less verbose.

System.Transactions is part of .NET Core 2.0. It only supports local transactions, but that should be enough for some workflow scenarios.

You can look at the https://github.com/AvaloniaUI/Avalonia. This is XAML-inspirated UI engine. And it can be cross platform.

When working on Xaml workflows generated by visual studio with CSharpValue and CSharpReference elements, I get a Workflow not compiled error even after setting compilation to true in the settings.

I’ll try and resolve this down to a simple test case, the WF I built was too ambitious.

Has anyone else managed to use a Visual Studio defined Xaml Workflow?

Also with the assembly name change, you have to change the Xaml declaration at the beginning of the Xaml to make it work.

This is related to my testing this in my wfRunnerCore repo.

Related to #7

Hallo

in our company we use .NET Framework Rehosted Workflow Designer to create and edit workflows.
Actually we use it only on windows machines. But we want to switch to .NET Standard to also able to use Linux machines.

Creating and executing activities with CoreWF works perfect acutally. But we need the ability to create and edit workflows with .NET rehosted workflow designer.

When I try to load a workflow file into the designer I will get a message that the contextproperty is not set.
The workflow file was created by CoreWF (and Portable.Xaml).

Is there a change to get it work ?

Thanks in advance!

BPML is an industry standard for workflow definitions. If we have something that can read BPML, then we may not need to create a WF workflow designer.

Add test failing due to different date formats:

Put these in the tests folder

For backward compatibility. Everything still works as far as I can tell.

I try to run FileInstanceStore Samples Project (BookmarkConsoleApp) and I encounter an error in the LoadWorkflow function.

{"Could not convert string 'e0f9ec98-30a2-4641-b760-5abcbb2fa5bb' to dictionary key type 'CoreWf.Bookmark'. Create a TypeConverter to convert from the string to the key type object. Path 'Value.bookmarkMgr.bookmarks.e0f9ec98-30a2-4641-b760-5abcbb2fa5bb', line 12, position 47."} | Newtonsoft.Json.JsonSerializationException

Remove Microsoft from the name since this is not an official Microsoft project.