ufdada / quicktable Goto Github PK

Great plugin! Would you consider placing the quicktable configuration variables under the "config.quicktable" namespace to minimize potential name conflicts, and to facilitate cleaner automated installation processes?

In plugin.js, I believe changing line 5 would accomplish the job.
Old:
var conf = editor.config,
New:
var conf = editor.config.quicktable || {},

Usage would change to:
config.quicktable.varName = value;
Or:

config.quicktable = {
    varName1: 0,
    varName2: 5,
    ...
    varNameN: true
}

The latest commits made aren't in a release tag, so the changes made in those commits aren't making it in to the CKEditor builder or addon viewer (downloader). On the CKEditor site, version 1.0.5 is being pulled in, which is missing the ability to set the cellpadding/spacing to null etc. So it would be great to get a 1.0.6 tag in order to get the latest changes to be shown on the CKEditor site.

Useful for e.g. if you want to use it together with Bootstrap. Which, for responsive tables needs to wrap them in a <div> with the css-class table-responsive.

The plugin does not work in inline editing mode. I see the quick table feature but on selecting and clicking it does not add the table. Is it not adapted for inline editing mode ??

editor.insertElement is used to insert the table into the document. This works, but it does not appear to respect the Advanced Content Filter settings. For example, I don't want to insert tables with the border, cellpadding, and cellspacing attributes present. I can configure the ACF to filter these out, but editor.insertElement does not appear to respect the filter.

Consider switching instead to editor.insertHtml, which, by default, filters the content through the ACF.

First things first: nice plugin. I would like to use it in my environment, but it does not suit the GPL license. On the ckeditor.com plugin site, the quicktable plugin is marked "GPL / LGPL / MPL", but the repository only contains a GPL license. If "GPL-only" was intended by you, that's fine. If not, could you add the option of using this under LGPL as well?